Commit Graph

624 Commits (e3188191d9da0e49dd156ea70f59b92776216e8c)
 

Author SHA1 Message Date
OpenGnSys Support Team e3188191d9 rest: add and use http error code to improve error reporting
Use http error code to improve better error reporting:

- 404 Not Found
  + object is not found

- 409 Conflict
  + object already exists

- 423 Locked
  + object is in use

- 500 Internal Server Error:
  + database query fails
  + out of memory

- 501 Service Unavailable
  + Cannot connect to database

- 507 Insufficient Storage
  + Disk is full
2024-12-10 12:12:43 +01:00
OpenGnSys Support Team 8f52b8911e rest: extend og_rest_ctx to provide http error
this is to improve error reporting for ogcp and ogcli
2024-12-05 17:12:30 +01:00
OpenGnSys Support Team ef3bad6e14 rest: consolidate rest API handlers
add struct og_rest_ctx and use it to consolidate rest API handlers and to
ease future extensibility.
2024-12-03 10:08:24 +01:00
OpenGnSys Support Team da31efb4e0 rest: statify image restore and create function
only used in rest.c, remove the forward declaration in json.h
2024-12-02 23:55:35 +01:00
Alejandro Sirgo Rica 00d54325d3 rest: update POST /shell/run for cmd execution
Remove legacy "echo" parameter.
Add boolean "inline" parameter to determine if the execution is
an inline command or a predefined script in /opt/opengnsys/shell/
2024-11-27 14:06:29 +01:00
OpenGnSys Support Team 113472d5c0 src: add built-in ogrelive grub2 boot mode template
Add built-in ogrelive grub2 boot mode template and use it to generate the grub2
boot file for each computer for the new live system.

Use grub2 http to download vmlinuz, initrd.img.

Use live support to download filesystem.squashfs through http.

check for vmlinuz in cache, as usual, otherwise fallback to network boot.
2024-11-25 12:18:34 +01:00
OpenGnSys Support Team 232e6eb308 rest: add og_boot_params_find() and og_boot_params_free() and use them
Prepare to reuse this code for the new live system.

Add two new fields to represent server and repository IP.
2024-11-25 10:33:47 +01:00
OpenGnSys Support Team c110bd7d8d rest: do not release dbi in og_get_client_mode_params()
caller function releases this, this results in double free.
2024-11-25 10:33:47 +01:00
Alejandro Sirgo Rica aebf2281bf rest: allow creation of folder with same name in different nodes
Check the parent node along with the folder name to identify if
the folder already exists.

Fix error when using a folder name defined in any other folder.
2024-11-21 17:07:28 +01:00
Alejandro Sirgo Rica 0ea0394709 rest: rename "name" to "directory" in GET /oglive/list
Rename name field for the contents of the new live format.
2024-11-21 13:34:27 +01:00
Alejandro Sirgo Rica 16baa88541 refresh: update client login status from "status" field value
Update the session status based on the value of the "status" field
in the refresh response, the possible values are:
LINUXS, LINUX, WINS, WIN.
2024-11-18 10:09:08 +01:00
Alejandro Sirgo Rica 4103945785 rest: add POST /oglive/add and POST /oglive/delete
Add API to register and delete oglives from the database.

POST /oglive/add
Register an installed oglive in the database, if the entry already
exists update its creation date.

Example request payload:
{"name": "ogrelive-6.1.0-26"}

POST /oglive/delete
Remove an installed oglive from the database

Example request payload:
{"name": "ogrelive-6.1.0-26"}
2024-11-11 12:29:11 +01:00
Alejandro Sirgo Rica 892a8fa2e5 rest: update GET /oglive/list to include oglive data from database
Append oglive info at the end of the array of the "oglive" entry.
Each entry defines the name of the oglive and the creation date.
2024-11-11 12:29:11 +01:00
OpenGnSys Support Team 55179decb7 client: improve error reporting for image creation reponse
provide a bit more information in the logs to identify the error
2024-11-07 19:01:38 +01:00
OpenGnSys Support Team 1fd62a4850 client: use image id in last command context
instead of using image id that client reports
2024-11-07 18:57:32 +01:00
OpenGnSys Support Team e67cdafb71 client: no need to update repository id after creating image
this repository id is already added to the database when the image creation is
requested, remove this code to update it again when the client replies
2024-11-07 18:52:07 +01:00
OpenGnSys Support Team 24e70ac3ff rest: switch to use grub2 templates as base directory
use grub2 template for GET /mode to list boot modes
2024-10-31 16:45:30 +01:00
OpenGnSys Support Team bff3d1dc9d client: remove image stub entry image creation registration fails
if client succeeds to create the image but server fails to register this image,
then remove the image stub in the database.
2024-10-31 01:19:46 +01:00
OpenGnSys Support Team 479998d76f src: add last client command context and use it for image creation
Add last client command context that is used in the request to client.

This allows to remove the stub image entry in the database in case that the
image creation fails.
2024-10-31 01:18:57 +01:00
OpenGnSys Support Team 83b1be6589 client: add helper function to reset last client command information
just a preparation, no functional changes are intended.
2024-10-31 00:39:43 +01:00
OpenGnSys Support Team 16cc22df3e src: place last client command information in struct
just a preparation, no functional changes are intended.
2024-10-31 00:37:03 +01:00
OpenGnSys Support Team 2febb50a92 rest: do not remove image on center delete
if center is removed, leave images in place, image belongs to
repository, not to center.

This comes from b4870733 ('#942 Add REST POST /center/delete method')
2024-10-30 12:20:42 +01:00
Alejandro Sirgo Rica e679925bd0 src: add safe_strtoull for safe string to number conversion
Add safe_strtoull to validate the execution of strtoull.
Definining the base of the number is required becase partition
codes are base 16 but they lack the 0x prefix.

Replace uses of atoi and strtoull/strtoul and log the conversion
errors.
2024-10-25 15:09:31 +02:00
Alejandro Sirgo Rica e960063a13 rest: add conditional boot mode configuration for ogReLive
Add a different boot mode configuration for the legacy live and the
new live.

Remove outdated params for ogReLive.
2024-10-24 13:45:49 +02:00
OpenGnSys Support Team 1d36d6c652 Revert "rest: add fetch param to boot mode configuration"
Some equipment reports this error:

  Error 28: Selected item cannot fit into memory

because line is too long, revert this commit until there is a better way
to add fetch= only on new live images.
2024-10-15 11:08:06 +02:00
Alejandro Sirgo Rica 65b397f59f rest: fix GET /session payload structure
Split partition data by client instead of a single array with every
partition.

Old payload structure:
{
  'sessions': [{'disk': 1, 'partition': 1, 'name': 'unknown'}, {'disk': 1, 'partition': 2, 'name': 'unknown'}, {'disk': 1, 'partition': 1, 'name': 'Ubuntu 22.04.4 LTS 64 bits'}]
}

New payload structure:
{
  'sessions': [
     {'addr': '1.1.1.1', 'partitions': ['disk': 1, 'partition': 1, 'name': 'Ubuntu 22.04.4 LTS 64 bits']},
     {'addr': '1.1.1.2', 'partitions': [{'disk': 1, 'partition': 1, 'name': 'unknown'}, {'disk': 1, 'partition': 2, 'name': 'unknown'}]}
  ]
}
2024-10-11 12:17:28 +02:00
Alejandro Sirgo Rica ca3503b716 src: remove placeholder image in failed image/create
Delete image data after a failed image creation.
2024-10-04 12:39:22 +02:00
Alejandro Sirgo Rica d6d15a753e src: move og_delete_image to dbi.c
Move og_delete_image into dbi.c as og_dbi_delete_image to use it
from client.c

no functional changes.
2024-10-04 12:00:22 +02:00
Alejandro Sirgo Rica d1734b30ec rest: add fetch param to boot mode configuration
Add "fetch=http://IP_REPO/OGLIVEDIR/filesystem.squashfs" string
to the client boot mode configuration.
2024-10-03 12:17:00 +02:00
OpenGnSys Support Team 89ba3f1b4f src: inet_aton() returns 0 on error
not < 0, fix this.
2024-10-01 12:35:13 +02:00
OpenGnSys Support Team e81685bba0 rest: do not allow two repositories to use the same IP address
repository need to have unique IP address, otherwise bail out.
2024-10-01 12:33:59 +02:00
OpenGnSys Support Team 85ca21be00 rest: validate name in repository/{add,update}
do not allow request without name.
2024-09-30 14:41:49 +02:00
OpenGnSys Support Team 760a82af2c rest: remove unused probe
unused since 87be2ce08
2024-09-30 14:41:49 +02:00
Alejandro Sirgo Rica 491bf6f5e9 rest: add free and used cache to GET /cache/list
Add "used_cache" and "free_cache" fields to the payload of GET
/cache/list.
2024-09-26 12:45:11 +02:00
OpenGnSys Support Team 3c395ecea2 client: move image list to cache data to consolidate it
Move list of images in the cache to cache_data. Add new functions to
initialize cache data (image list) and release it.
2024-09-25 14:49:17 +02:00
OpenGnSys Support Team 65aee8f3f3 json: move list_head at the tip of struct og_cache_image
this is accessed on list iterations in first place, improve cache locality.
2024-09-25 14:48:49 +02:00
Alejandro Sirgo Rica c7bfc370ae src: add used_size and free_size to partition data
Extend database table ordenadores_particiones to add new "used_size" and "free_size" fields.

  FIELD       TYPE
| tamano    | bigint   |
| uso       | tinyint  |
| used_size | bigint   |
| free_size | bigint   |

"tamano" is the field storing the total size of the partition.
"uso" is a field storing the integer percentage of use, it is preserved for backwards compatibility with scritps that access the database.
"used_size" and "free_size" contain the used and free partition
size in bytes.

Old response from ogClient for /cache/delete, /cache/fetch
and /image/restore:
{
  'cache': [
    {'name': 'windows.img', 'size': 2432370213, checksum: '5d4dcc677bc19f40a647d0002f4ade90'},
    {'name': 'linux.img', 'size': 243234534213, checksum: '3eb22f888f88a55ad954f55644e1192e'}
  ]
}

New response:
{
  'cache': {
    'used_size': 4520232322423,
    'free_size': 48273465287452945,
    'images': [
      {'name': 'windows.img', 'size': 2432370213, checksum: '5d4dcc677bc19f40a647d0002f4ade90'},
      {'name': 'linux.img', 'size': 243234534213, checksum: '3eb22f888f88a55ad954f55644e1192e'}
    ]
  }
}

Parse the new "free_size" and "used_size" fields of each partition data in the response payload of /refresh

Parse "free_size" and "used_size" fields of the cache data in the reponse payload of /image/restore, /cache/delete and /cache/fetch

Replace "used_size" field of GET /client/setup with the value
of the new database field "used_size"
2024-09-25 12:09:32 +02:00
OpenGnSys Support Team b74a05cf38 client: log error on refresh
Report failure when trying to refresh client information.
2024-09-23 13:51:14 +02:00
OpenGnSys Support Team bdf4c60411 client: remove redundant refresh validation
json parser already validates attributes must be set on.
2024-09-23 13:51:14 +02:00
OpenGnSys Support Team 5d97a721d0 ogAdmServer: replace old actualizaConfiguracion
Reimplement the legacy funcion actualizaConfiguracion with
og_update_client_config in src/client.c

if disk does not exist, add it, otherwise update disk contents.

if partition size, code, filesystem or os is different, reset image id,
otherwise update partition usage only.

delete partitions that are gone at the end.
2024-09-23 13:51:07 +02:00
OpenGnSys Support Team ad31c3832d rest: remove scheduler code
Put ogserver into diet, remove this feature, including pending command queue.
2024-09-17 17:46:07 +02:00
OpenGnSys Support Team 32b9a53f57 rest: better json clients validation
- check maximum limit of clients
- reject empty array
2024-09-17 17:46:00 +02:00
Alejandro Sirgo Rica e3a73a504f rest: add GET /efi
Add GET /efi request to obtain information about the client's
boot entries.

Field inside the /refresh payload
'efi': {
  'entries': [
    {
      "order": 0,
      "name": "Boot0000",
      "active": false,
      "description": "grub"
    },
    {
      "order": 1,
      "name": "Boot0001",
      "active": true,
      "description": "UEFI: PXE IP4 Realtek PCIe GBE Family Controller"
    }
  ]
}

If the client is not a EFI system it won't add the 'efi' field.
If an entry is not in the boot order it won't have the 'order' field.

GET /efi resquest payload structure:
{
    'clients': ['10.141.10.21', '10.141.10.22']
}

GET /efi response's structure:
{
  'clients': [
    {
      'ip': '10.141.10.21',
      'entries': [
        {
          "order": 0,
          "name": "Boot0000",
          "active": false,
          "description": "grub"
        },
        {
          "order": 1,
          "name": "Boot0001",
          "active": true,
          "description": "UEFI: PXE IP4 Realtek PCIe GBE Family Controller"
        }
      ]
    },
    {
      'ip': '10.141.10.22',
      'entries': []
    }
  ]
}

The client with ip 10.141.10.22 is a BIOS system.

If an entry does not appear in the boot order it won't have the
'order' field.
2024-09-11 14:09:51 +02:00
OpenGnSys Support Team 1fa3813b92 rest: restore change client repository
use correct format for mac SQL query to fix 568d709
2024-09-10 14:22:38 +02:00
OpenGnSys Support Team 7f325a4b67 repo: allow 128 IPs per repository
rise this artificial limit.
2024-09-10 12:05:05 +02:00
OpenGnSys Support Team 568d709361 rest: use integer for repository ID
ID is integer, fix inconsistency in dc68d0f ('rest: add POST /client/repo')
2024-09-09 16:18:26 +02:00
OpenGnSys Support Team 4567bce90b src: fallback to use first repository/server found
use first repository/server in the list in case no specific repository/server
is found in the same network, this is a fallback that works if repository/server
is reachable through gateway.
2024-09-04 12:19:58 +02:00
OpenGnSys Support Team 7977711ee9 rest: use integer for server id
id is not a string, use integer instead
2024-09-03 14:24:09 +02:00
OpenGnSys Support Team 38076677c7 rest: memleak in error path of image/create
if obtaining repository IP fails, json object for client is leaked, move it
after query to infer repository IP.
2024-08-30 13:04:34 +02:00
OpenGnSys Support Team 8c37aa3688 rest: adapt cache/fetch to support repository with multiple IP adddress
take repository_id as json attributo, then infer repository IP from client.
2024-08-30 13:03:22 +02:00