48k.eu-mirror
/
ogserver
mirror of https://git.48k.eu/ogserver
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rest: better json clients validation 

- check maximum limit of clients
- reject empty array
master
OpenGnSys Support Team 2024-09-04 01:12:13 +02:00
parent e3a73a504f
commit 32b9a53f57
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/rest.c
View File

@ -173,16 +173,22 @@ static int og_json_parse_clients(json_t *element, struct og_msg_params *params)
return -1;
for (i = 0; i < json_array_size(element); i++) {
if (params->ips_array_len >= OG_CLIENTS_MAX)
return -1;
k = json_array_get(element, i);
if (json_typeof(k) != JSON_STRING)
return -1;
params->ips_array[params->ips_array_len++] =
json_string_value(k);
params->flags |= OG_REST_PARAM_ADDR;
}
if (params->ips_array_len == 0)
return -1;
params->flags |= OG_REST_PARAM_ADDR;
return 0;
}
@ -1800,9 +1806,6 @@ static int og_cmd_get_client_setup(json_t *element,
if (!og_msg_params_validate(params, OG_REST_PARAM_ADDR))
return -1;
if (params->ips_array_len != 1)
return -1;
root = json_object();
if (!root)
return -1;
@ -2072,9 +2075,6 @@ static int og_cmd_get_client_info(json_t *element,
if (!og_msg_params_validate(params, OG_REST_PARAM_ADDR))
return -1;
if (params->ips_array_len != 1)
return -1;
if (inet_aton(params->ips_array[0], &addr) == 0)
return -1;