Commit Graph

220 Commits (1d801be52c05e89532b945f58b2d302d15a55297)
 

Author SHA1 Message Date
OpenGnSys Support Team 1d801be52c #941 use dbi layer from respuestaEstandar()
And update all callers.

Some of the db.Open() calls cannot be removed yet, since there are still
more function dependencies that need to be converted too.
2020-03-04 14:54:49 +01:00
OpenGnSys Support Team 39157320ec #941 Consolidate CrearSoftIncremental, RestaurarImagenBasica, RestaurarSoftIncremental, Configurar and EjecutarScript
These functions are identical, remove duplicated code.
2020-03-04 14:54:46 +01:00
OpenGnSys Support Team fbc783c090 #941 Consolidate RESPUESTA_Reiniciar, RESPUESTA_IniciarSesion and RESPUESTA_Apagar
They are identical, remove duplicated code.
2020-03-04 14:54:43 +01:00
OpenGnSys Support Team d3239f70eb #941 Consolidate RESPUESTA_Configurar and RESPUESTA_EjecutarScript
These function are almost identical, remove duplicated code.
2020-03-04 14:54:39 +01:00
OpenGnSys Support Team ad70969c2f #941 use dbi layer from buscaComandos() 2020-03-04 14:54:31 +01:00
OpenGnSys Support Team ecff9948e7 #941 use dbi layer from AutoexecCliente() 2020-03-04 14:54:21 +01:00
OpenGnSys Support Team 0fbdcf260c #941 use dbi layer from procesoInclusionClienteWinLnx() 2020-03-04 14:54:05 +01:00
OpenGnSys Support Team 2629906b6d #941 add basic database-independent abstraction (dbi)
Add basic infrastructure to support for the independent database layer.
2020-03-04 14:53:01 +01:00
Javier Sánchez Parra a245411ab2 #924 Fix that only the commands without session were checked
Irina reports that the bug fixed in 78a97c5 happens again when you run a
command with a session (queue of actions).

The bug was introduced in 78a97c5, the goal of the commit was
to change the behaviour of respuestaEstandar to always check
the result of a command, whether it has a session or not. But, instead
of this behaviour, the commit changes respuestaEstandar to only check the
commands without session.
2019-11-25 13:19:41 +01:00
Ramón M. Gómez 696c5bbaf0 #839: Always update the partition types when obtaining the computer configuration. 2019-11-21 17:42:57 +01:00
Roberto Hueso Gómez abd2b913d8 #915 Test malformed payload for POST commands
This patch includes tests for the remaining REST API commands:

	POST /shell/output
	POST /session
	POST /poweroff
	POST /reboot
	POST /stop
	POST /refresh
	POST /hardware
	POST /software
	POST /image/create
	POST /image/restore
	POST /setup
	POST /image/create/basic
	POST /image/create/incremental
	POST /image/restore/basic
	POST /image/restore/incremental
	POST /run/schedule

This test covers requests that are missing one of the parameters in its
payload.
2019-11-14 14:51:13 +01:00
Roberto Hueso Gómez 1cdbc5facf #915 Test malformed payload for POST /shell/run
This test covers requests that do not contain 1 of the parameters in their
payloads.
2019-11-13 14:16:02 +01:00
Roberto Hueso Gómez 682d3b6b17 #915 Test malformed payload for POST /wol
This test covers requests that do not contain 1 of the parameters in their
payloads.
2019-11-13 14:16:01 +01:00
Roberto Hueso Gómez 4d98bdf5f6 #915 Test malformed payload for POST /clients
This test covers requests that do not contain 1 of the parameters in their
payloads.
2019-11-13 14:15:58 +01:00
Roberto Hueso Gómez 8fa082d4c5 #915 Return HTTP 400 error code in og_client_state_process_payload_rest
This patch meets RFC 7235 and returns an HTTP 400 error code when ogAdmServer
recieves a wrong request.
2019-11-13 14:15:57 +01:00
Roberto Hueso Gómez 65cc7c17e2 #915 Extend REST API POST no payload tests to all remaining tests.
This patch extends tests for requests without any payload in the following REST
API POST functions:

- /clients
- /wol
- /shell/run
- /shell/output
- /session
- /poweroff
- /reboot
- /stop
- /refresh
- /hardware
- /software
2019-11-13 14:15:56 +01:00
Roberto Hueso Gómez 6c91d147c1 #915 Rename POST /image/setup for /setup in REST API
This patch renames the setup command to avoid semantic confusion.
2019-11-13 14:15:43 +01:00
Roberto Hueso Gómez ee2e16ac96 #915 Adapt POST /shell/run test to the 'echo' parameter 2019-11-12 21:37:11 +01:00
Roberto Hueso Gómez ffd2965b33 #915 Add 'echo' parameter to POST /shell/run
'echo' parameter makes possible for users to request the console output.
2019-11-12 21:37:11 +01:00
Roberto Hueso Gómez 280df58917 #915 Fix og_json_parse_clients flags for empty arrays
This patch prevents the flag OG_REST_PARAM_ADDR to be activated when the array
is empty.
2019-11-12 21:37:11 +01:00
Roberto Hueso Gómez 6066b32603 #915 Validate POST /run/schedule REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-12 21:37:11 +01:00
Roberto Hueso Gómez 4f785531e6 #915 Validate POST /image/restore/incremental REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-12 21:37:11 +01:00
Roberto Hueso Gómez f51c245c93 #915 Validate POST /image/restore/basic REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-12 21:37:11 +01:00
Roberto Hueso Gómez 6a0e5fa1c0 #915 Validate POST /image/create/incremental REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-12 21:37:11 +01:00
Roberto Hueso Gómez 82a1d5a142 #915 Validate POST /image/create/basic REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-12 21:37:11 +01:00
Roberto Hueso Gómez 3bc3b45e5f #915 Validate POST /image/setup REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-12 21:37:11 +01:00
Ramón M. Gómez 184510412c #839: Do not check partition type when obtaining computer configuration to hide/unhide NTFS partitions. 2019-11-11 12:37:05 +01:00
Roberto Hueso Gómez ec4189b18f #915 Validate POST /image/restore REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-06 11:29:42 +01:00
Roberto Hueso Gómez abe2a888ab #915 Validate POST /image/create REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-06 11:27:47 +01:00
Roberto Hueso Gómez 1a1ecf7791 #915 Validate POST /software REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-06 11:26:45 +01:00
Roberto Hueso Gómez 7803e13adf #915 Validate POST /hardware REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-06 11:26:33 +01:00
Roberto Hueso Gómez 93028bd055 #915 Validate POST /refresh REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-06 11:26:15 +01:00
Roberto Hueso Gómez bc1b958ceb #915 Validate POST /stop REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-06 11:26:06 +01:00
Roberto Hueso Gómez 0a41d5d02f #915 Validate POST /reboot REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-06 11:25:54 +01:00
Roberto Hueso Gómez acf9cdf8d1 #915 Validate POST /poweroff REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-06 11:25:24 +01:00
Roberto Hueso Gómez 8901505bb5 #915 Validate POST /session REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-06 11:24:24 +01:00
Roberto Hueso Gómez 61059e1b2e #915 Validate POST /shell/output REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-06 11:22:35 +01:00
Roberto Hueso Gómez b403c7ae6c #915 Validate POST /shell/run REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-06 11:17:19 +01:00
Roberto Hueso Gómez ec5fe704cc #915 Validate POST /wol REST API parameters
This patch ensures that all required parameters are sent in the request.
2019-11-06 11:16:59 +01:00
Roberto Hueso Gómez 54ecdbbdf1 #915 Validate POST /clients parameters
This patch adds og_msg_params_validate function as well as some flags that can
be used to validate parameters of a REST API request.

This patch ensures that all required parameters are sent in the request.
2019-11-06 11:16:36 +01:00
Roberto Hueso Gómez 64b470514b #915 Fix ogAdmServer POST /software test parameters
This patch adds missing parameters to the test JSON.
2019-11-06 11:16:22 +01:00
Javier Sánchez Parra 8082efd6de #924 Always check the result of a command to avoid errors
Irina reports that if you try to restore an image without success
(for example: the disk does not have enough space), the database changes
as if no error would happen. So you see the computer in the WebConsole
with an image/OS that, actually, does not have.

The bug is caused because the function respuestaEstandar only checks
the result of a command if it has a session. So the problem is that the
commands which use respuestaEstandar without a session can return an
error, but the ogAdmServer always works as no error would occur.

This commit changes the behaviour of respuestaEstadar to always check
the result of a command, whether it has a session or not.
2019-11-04 15:09:04 +01:00
Roberto Hueso Gómez 2bc2490d00 #915 Add test for POST /run/schedule REST API
This test covers 3 scenarios:

1. Correct usage.
2. Incorrect usage, without payload.
3. Incorrect usage, use this command with GET.
2019-10-31 13:18:48 +01:00
Roberto Hueso Gómez 1f55beb8f5 #915 Add test for POST /image/restore/incremental REST API
This test covers 3 scenarios:

1. Correct usage.
2. Incorrect usage, without payload.
3. Incorrect usage, use this command with GET.
2019-10-31 13:18:48 +01:00
Roberto Hueso Gómez 20f935bb65 #915 Add test for POST /image/restore/basic REST API
This test covers 3 scenarios:

1. Correct usage.
2. Incorrect usage, without payload.
3. Incorrect usage, use this command with GET.
2019-10-31 13:18:48 +01:00
Roberto Hueso Gómez b5722de3fb #915 Add test for POST /image/create/incremental REST API
This test covers 3 scenarios:

1. Correct usage.
2. Incorrect usage, without payload.
3. Incorrect usage, use this command with GET.
2019-10-31 13:18:48 +01:00
Roberto Hueso Gómez 713070ab10 #915 Add test for POST /image/create/basic REST API
This test covers 3 scenarios:

1. Correct usage.
2. Incorrect usage, without payload.
3. Incorrect usage, use this command with GET.
2019-10-31 13:18:48 +01:00
Roberto Hueso Gómez 1436d44cc6 #915 Add test for POST /image/setup REST API
This test covers 3 scenarios:

1. Correct usage.
2. Incorrect usage, without payload.
3. Incorrect usage, use this command with GET.
2019-10-31 13:18:48 +01:00
Roberto Hueso Gómez ba3b1ad543 #915 Add test for POST /image/restore REST API
This test covers 3 scenarios:

1. Correct usage.
2. Incorrect usage, without payload.
3. Incorrect usage, use this command with GET.
2019-10-31 13:18:48 +01:00
Roberto Hueso Gómez b4d2890460 #915 Add test for POST /image/create REST API
This test covers 3 scenarios:

1. Correct usage.
2. Incorrect usage, without payload.
3. Incorrect usage, use this command with GET.
2019-10-31 13:18:48 +01:00