#915 Test malformed payload for POST commands

This patch includes tests for the remaining REST API commands:

	POST /shell/output
	POST /session
	POST /poweroff
	POST /reboot
	POST /stop
	POST /refresh
	POST /hardware
	POST /software
	POST /image/create
	POST /image/restore
	POST /setup
	POST /image/create/basic
	POST /image/create/incremental
	POST /image/restore/basic
	POST /image/restore/incremental
	POST /run/schedule

This test covers requests that are missing one of the parameters in its
payload.

tests/units/test_0005_post_shell_output.py

@@ -16,6 +16,10 @@ class TestPostShellOutputMethods(unittest.TestCase):
         returned = requests.post(self.url, headers=self.headers, json=None)
         self.assertEqual(returned.status_code, 400)
 
+    def test_malformed_payload(self):
+        returned = requests.post(self.url, headers=self.headers, json={})
+        self.assertEqual(returned.status_code, 400)
+
     def test_get(self):
         returned = requests.get(self.url, headers=self.headers)
         self.assertEqual(returned.status_code, 405)

tests/units/test_0006_post_session.py

@@ -17,6 +17,15 @@ class TestPostSessionMethods(unittest.TestCase):
         returned = requests.post(self.url, headers=self.headers, json=None)
         self.assertEqual(returned.status_code, 400)
 
+    def test_malformed_payload(self):
+        for parameter in self.json:
+            malformed_payload = self.json.copy()
+            malformed_payload.pop(parameter)
+            returned = requests.post(self.url,
+                                     headers=self.headers,
+                                     json=malformed_payload)
+            self.assertEqual(returned.status_code, 400)
+
     def test_get(self):
         returned = requests.get(self.url, headers=self.headers)
         self.assertEqual(returned.status_code, 405)

tests/units/test_0007_post_poweroff.py

@@ -16,6 +16,10 @@ class TestPostPoweroffMethods(unittest.TestCase):
         returned = requests.post(self.url, headers=self.headers, json=None)
         self.assertEqual(returned.status_code, 400)
 
+    def test_malformed_payload(self):
+        returned = requests.post(self.url, headers=self.headers, json={})
+        self.assertEqual(returned.status_code, 400)
+
     def test_get(self):
         returned = requests.get(self.url, headers=self.headers)
         self.assertEqual(returned.status_code, 405)

tests/units/test_0008_post_reboot.py

@@ -16,6 +16,10 @@ class TestPostRebootMethods(unittest.TestCase):
         returned = requests.post(self.url, headers=self.headers, json=None)
         self.assertEqual(returned.status_code, 400)
 
+    def test_malformed_payload(self):
+        returned = requests.post(self.url, headers=self.headers, json={})
+        self.assertEqual(returned.status_code, 400)
+
     def test_get(self):
         returned = requests.get(self.url, headers=self.headers)
         self.assertEqual(returned.status_code, 405)

tests/units/test_0009_post_stop.py

@@ -16,6 +16,10 @@ class TestPostStopMethods(unittest.TestCase):
         returned = requests.post(self.url, headers=self.headers, json=None)
         self.assertEqual(returned.status_code, 400)
 
+    def test_malformed_payload(self):
+        returned = requests.post(self.url, headers=self.headers, json={})
+        self.assertEqual(returned.status_code, 400)
+
     def test_get(self):
         returned = requests.get(self.url, headers=self.headers)
         self.assertEqual(returned.status_code, 405)

tests/units/test_0010_post_refresh.py

@@ -16,6 +16,10 @@ class TestPostRefreshMethods(unittest.TestCase):
         returned = requests.post(self.url, headers=self.headers, json=None)
         self.assertEqual(returned.status_code, 400)
 
+    def test_malformed_payload(self):
+        returned = requests.post(self.url, headers=self.headers, json={})
+        self.assertEqual(returned.status_code, 400)
+
     def test_get(self):
         returned = requests.get(self.url, headers=self.headers)
         self.assertEqual(returned.status_code, 405)

tests/units/test_0011_post_hardware.py

@@ -16,6 +16,10 @@ class TestPostHardwareMethods(unittest.TestCase):
         returned = requests.post(self.url, headers=self.headers, json=None)
         self.assertEqual(returned.status_code, 400)
 
+    def test_malformed_payload(self):
+        returned = requests.post(self.url, headers=self.headers, json={})
+        self.assertEqual(returned.status_code, 400)
+
     def test_get(self):
         returned = requests.get(self.url, headers=self.headers)
         self.assertEqual(returned.status_code, 405)

tests/units/test_0012_post_software.py

@@ -18,6 +18,15 @@ class TestPostSoftwareMethods(unittest.TestCase):
         returned = requests.post(self.url, headers=self.headers, json=None)
         self.assertEqual(returned.status_code, 400)
 
+    def test_malformed_payload(self):
+        for parameter in self.json:
+            malformed_payload = self.json.copy()
+            malformed_payload.pop(parameter)
+            returned = requests.post(self.url,
+                                     headers=self.headers,
+                                     json=malformed_payload)
+            self.assertEqual(returned.status_code, 400)
+
     def test_get(self):
         returned = requests.get(self.url, headers=self.headers)
         self.assertEqual(returned.status_code, 405)

tests/units/test_0016_post_image_create.py

@@ -22,6 +22,15 @@ class TestPostCreateImageMethods(unittest.TestCase):
         returned = requests.post(self.url, headers=self.headers, json=None)
         self.assertEqual(returned.status_code, 400)
 
+    def test_malformed_payload(self):
+        for parameter in self.json:
+            malformed_payload = self.json.copy()
+            malformed_payload.pop(parameter)
+            returned = requests.post(self.url,
+                                     headers=self.headers,
+                                     json=malformed_payload)
+            self.assertEqual(returned.status_code, 400)
+
     def test_get(self):
         returned = requests.get(self.url, headers=self.headers)
         self.assertEqual(returned.status_code, 405)

tests/units/test_0017_post_image_restore.py

@@ -23,6 +23,15 @@ class TestPostRestoreImageMethods(unittest.TestCase):
         returned = requests.post(self.url, headers=self.headers, json=None)
         self.assertEqual(returned.status_code, 400)
 
+    def test_malformed_payload(self):
+        for parameter in self.json:
+            malformed_payload = self.json.copy()
+            malformed_payload.pop(parameter)
+            returned = requests.post(self.url,
+                                     headers=self.headers,
+                                     json=malformed_payload)
+            self.assertEqual(returned.status_code, 400)
+
     def test_get(self):
         returned = requests.get(self.url, headers=self.headers)
         self.assertEqual(returned.status_code, 405)

tests/units/test_0018_post_setup.py

@@ -39,6 +39,15 @@ class TestPostSetupMethods(unittest.TestCase):
         returned = requests.post(self.url, headers=self.headers, json=None)
         self.assertEqual(returned.status_code, 400)
 
+    def test_malformed_payload(self):
+        for parameter in self.json:
+            malformed_payload = self.json.copy()
+            malformed_payload.pop(parameter)
+            returned = requests.post(self.url,
+                                     headers=self.headers,
+                                     json=malformed_payload)
+            self.assertEqual(returned.status_code, 400)
+
     def test_get(self):
         returned = requests.get(self.url, headers=self.headers)
         self.assertEqual(returned.status_code, 405)

tests/units/test_0019_post_image_create_basic.py

@@ -30,6 +30,15 @@ class TestPostCreateBasicImageMethods(unittest.TestCase):
         returned = requests.post(self.url, headers=self.headers, json=None)
         self.assertEqual(returned.status_code, 400)
 
+    def test_malformed_payload(self):
+        for parameter in self.json:
+            malformed_payload = self.json.copy()
+            malformed_payload.pop(parameter)
+            returned = requests.post(self.url,
+                                     headers=self.headers,
+                                     json=malformed_payload)
+            self.assertEqual(returned.status_code, 400)
+
     def test_get(self):
         returned = requests.get(self.url, headers=self.headers)
         self.assertEqual(returned.status_code, 405)

tests/units/test_0020_post_image_create_incremental.py

@@ -32,6 +32,15 @@ class TestPostCreateIncrementalImageMethods(unittest.TestCase):
         returned = requests.post(self.url, headers=self.headers, json=None)
         self.assertEqual(returned.status_code, 400)
 
+    def test_malformed_payload(self):
+        for parameter in self.json:
+            malformed_payload = self.json.copy()
+            malformed_payload.pop(parameter)
+            returned = requests.post(self.url,
+                                     headers=self.headers,
+                                     json=malformed_payload)
+            self.assertEqual(returned.status_code, 400)
+
     def test_get(self):
         returned = requests.get(self.url, headers=self.headers)
         self.assertEqual(returned.status_code, 405)

tests/units/test_0021_post_image_restore_basic.py

@@ -33,6 +33,15 @@ class TestPostRestoreBasicImageMethods(unittest.TestCase):
         returned = requests.post(self.url, headers=self.headers, json=None)
         self.assertEqual(returned.status_code, 400)
 
+    def test_malformed_payload(self):
+        for parameter in self.json:
+            malformed_payload = self.json.copy()
+            malformed_payload.pop(parameter)
+            returned = requests.post(self.url,
+                                     headers=self.headers,
+                                     json=malformed_payload)
+            self.assertEqual(returned.status_code, 400)
+
     def test_get(self):
         returned = requests.get(self.url, headers=self.headers)
         self.assertEqual(returned.status_code, 405)

tests/units/test_0022_post_image_restore_incremental.py

@@ -35,6 +35,15 @@ class TestPostRestoreIncrementalImageMethods(unittest.TestCase):
         returned = requests.post(self.url, headers=self.headers, json=None)
         self.assertEqual(returned.status_code, 400)
 
+    def test_malformed_payload(self):
+        for parameter in self.json:
+            malformed_payload = self.json.copy()
+            malformed_payload.pop(parameter)
+            returned = requests.post(self.url,
+                                     headers=self.headers,
+                                     json=malformed_payload)
+            self.assertEqual(returned.status_code, 400)
+
     def test_get(self):
         returned = requests.get(self.url, headers=self.headers)
         self.assertEqual(returned.status_code, 405)

tests/units/test_0023_post_run_schedule.py

@@ -16,6 +16,10 @@ class TestPostRunScheduleMethods(unittest.TestCase):
         returned = requests.post(self.url, headers=self.headers, json=None)
         self.assertEqual(returned.status_code, 400)
 
+    def test_malformed_payload(self):
+        returned = requests.post(self.url, headers=self.headers, json={})
+        self.assertEqual(returned.status_code, 400)
+
     def test_get(self):
         returned = requests.get(self.url, headers=self.headers)
         self.assertEqual(returned.status_code, 405)