48k.eu-mirror
/
ogserver
mirror of https://git.48k.eu/ogserver
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#941 memleak in actualizaConfiguracion 

Missing dbi_result_free(), use syslog() for logging.
master
OpenGnSys Support Team 2020-03-31 11:31:04 +02:00
parent 26736edcd0
commit bf8ba6ce4c
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sources/ogAdmServer.c
View File

@ -528,9 +528,11 @@ bool actualizaConfiguracion(struct og_dbi *dbi, char *cfg, int ido)
ser, ido); ser, ido);
if (!result) { if (!result) {
dbi_conn_error(dbi->conn, &msglog); dbi_conn_error(dbi->conn, &msglog);
og_info((char *)msglog); syslog(LOG_ERR, "failed to query database (%s:%d) %s\n",
__func__, __LINE__, msglog);
return false; return false;
} }
dbi_result_free(result);
} }
continue; continue;
} }
@ -595,7 +597,8 @@ bool actualizaConfiguracion(struct og_dbi *dbi, char *cfg, int ido)
ido, disk, par, cpt, tam, uso, idsfi, idsoi); ido, disk, par, cpt, tam, uso, idsfi, idsoi);
if (!result_update) { if (!result_update) {
dbi_conn_error(dbi->conn, &msglog); dbi_conn_error(dbi->conn, &msglog);
og_info((char *)msglog); syslog(LOG_ERR, "failed to query database (%s:%d) %s\n",
__func__, __LINE__, msglog);
return false; return false;
} }
dbi_result_free(result_update); dbi_result_free(result_update);
@ -643,6 +646,7 @@ bool actualizaConfiguracion(struct og_dbi *dbi, char *cfg, int ido)
dbi_result_free(result_update); dbi_result_free(result_update);
} }
dbi_result_free(result);
} }
lon += sprintf(tbPar + lon, "(0,0)"); lon += sprintf(tbPar + lon, "(0,0)");
// Eliminar particiones almacenadas que ya no existen // Eliminar particiones almacenadas que ya no existen