48k.eu-mirror
/
ogserver
mirror of https://git.48k.eu/ogserver
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#941 Missing error in actualizaSoftware() and memleak in result 

This patch fixes e052fdceec013 that adds a missing error in case
the insertion fails. This also releases the result in case the
entry exists.
master
OpenGnSys Support Team 2020-03-26 10:45:51 +01:00
parent 4f850d5acc
commit 26736edcd0
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sources/ogAdmServer.c
View File

@ -2372,16 +2372,17 @@ bool actualizaSoftware(struct og_dbi *dbi, char *sft, char *par,char *ido,
" VALUES(2,'%s',%s,0)", tbSoftware[i], idc);
if (!result) { // Error al insertar
dbi_conn_error(dbi->conn, &msglog);
og_info((char *)msglog);
syslog(LOG_ERR, "failed to query database (%s:%d) %s\n",
__func__, __LINE__, msglog);
return false;
}
dbi_result_free(result);
// Recupera el identificador del software
tbidsoftware[i] = dbi_conn_sequence_last(dbi->conn, NULL);
} else {
tbidsoftware[i] = dbi_result_get_uint(result, "idsoftware");
}
dbi_result_free(result);
}
// Ordena tabla de identificadores para cosultar si existe un pefil con esas especificaciones