Commit Graph

259 Commits (d9f8c9561823daf234e2348b5ea0db2e92d29216)
 

Author SHA1 Message Date
Jose M. Guisado d9f8c95618 views: better dhcp conf parsing when importing clients
This new regex allows parsing of:

	- Irrelevant options that the user may paste from its config
	  file, eg. 'option host-name'.
	- Allows linebreaks.

Hosts still require to have 'hardware ethernet' first, and then
'fixed-address'.

For example this regex admits dhcp host declarations such as

	host pir36-22_78 {
	      hardware ethernet d8:5e:d3:25:28:9d;
	      fixed-address 10.1.36.78;
	      option host-name "pc_78";
	}

Summary of the regex:

(?: *host *)			# Match host keyword and spaces
([\w.-]*)     			# Match any word character (alphanum and underscore)
(?:[ \n\r]*{[ \n\r]*)  		# Match any space or newline, then match { and any following space or newline
(?:[ \t]*hardware *ethernet *)  # Match any space or tab character followed by 'hardware ethernet'
((?:[0-9A-Fa-f]{2}[:-]){5}(?:[0-9A-Fa-f]{2}))  # Match the mac address using ':' or '-' as separator
(?: *;)				# Match any space character before a ';'
(?:[ \t\n\r]*fixed-address *)	# Match any space, tab or newline followed by 'fixed address' and any following space
(\d+\.\d+\.\d+\.\d+)		# Match an ip address (no validity check)
(?: *;)(?:[ \r\n]*[^}]*})	# Match any space followed by ';', then match any character except '}'
2023-06-27 17:06:34 +02:00
Jose M. Guisado 9c91fb16b4 views: add placeholder text inside dhcp conf textarea
Help user by hinting the current expected format via a placeholder in
the textarea box.

Current regex has its limitations when parsing dhcpd host declarations.
It does not support multi line host declarations or different options
outside "hardware ethernet ..." and "fixed-address ...".
2023-06-27 08:56:49 +02:00
Javier Sánchez Parra d029df8e84 Show warning when formatting clients without disks
If an administrator selects a client without disks and goes to
"Partition & Format", ogCP redirects it again to "Commands" and shows a
floating message indicating that the client has no disks.
2022-11-17 17:36:15 +01:00
Javier Sánchez Parra fc02d891cd Fix typo in save_user() function 2022-11-17 17:36:15 +01:00
Javier Sánchez Parra eeda698f40 Open real time log in a new tab 2022-11-17 17:36:15 +01:00
Javier Sánchez Parra 93758f3831 Disable scopes tree and add Back button in log view
All views from Commands section have this two attributes.
2022-11-17 17:36:15 +01:00
Javier Sánchez Parra 6aad8535f0 Update Spanish translations 2022-11-17 17:36:15 +01:00
Javier Sánchez Parra 46682c3ff9 Rename "Scopes" section to "Scopes management" 2022-11-17 17:36:15 +01:00
Javier Sánchez Parra 5d265aa532 Show scopes section only to administrators 2022-11-17 17:36:15 +01:00
Javier Sánchez Parra e1908c2543 Show servers section only to administrators 2022-11-17 17:36:15 +01:00
Javier Sánchez Parra 42bf42f580 Add clients in Linux and Windows mode
Scopes tree shows clients booted in Linux and Windows with ogClient
installed. It also shows if the user logs in.
2022-11-17 17:36:15 +01:00
Javier Sánchez Parra 693f5255b1 Assign servers to users
Instead of give permissions on all centers of a server selecting each one
of them, you can select the server that contains all this centers.
2022-11-07 12:58:27 +01:00
Javier Sánchez Parra 0f6641d92f Set server variable on GET /action/image/update
Otherwise, ogCP crashes on image update.

Fixes: 8726ade ("Adapt commands to work with several ogServers")
2022-11-07 12:58:27 +01:00
Javier Sánchez Parra f834253a80 Remove unused variable "g.server"
Since ogCP multi ogServer support, g.server is not used anymore. The
list of available servers is stored in the global variable "servers" at
og_server.py
2022-09-29 13:01:28 +02:00
Javier Sánchez Parra cb2f534f64 Get available scopes from all the servers
When creating o editing a user, you can select in which scopes from all
servers the user has permission.
2022-09-29 13:01:28 +02:00
Javier Sánchez Parra 4f3c66f04a Fix ogServer deletion from the configuration file
Otherwise, users can not remove from the web a server declared in the
deprecated way.
2022-09-29 13:01:28 +02:00
Javier Sánchez Parra 328ead9168 Create servers list if do not exists
Otherwise, if the configuration file do not have 'SERVERS' array, ogCP
crashes trying to append a new server.
2022-09-29 13:01:28 +02:00
Javier Sánchez Parra 178f253092 Always try to load servers list from config file
Otherwise, servers list is not loaded if the configuration file also
have an ogServer declared in the deprecated way.
2022-09-29 13:01:28 +02:00
Javier Sánchez Parra 30d27c8951 Adapt aux function to work with several ogServers
Otherwise, get_repositories() and get_repository() functions only get
the repositories of the first ogServer of the list.
2022-09-29 13:01:28 +02:00
Javier Sánchez Parra 6142a171fd Fix repositories retrieving
Commit X wrongly changed the URI to retrieve the repositories of an
ogServer.

Fixes: cf02e0c ("Add Servers section")
2022-09-27 09:48:36 +02:00
Javier Sánchez Parra a010f11224 Set server variable on GET /action/image/restore
Otherwise, ogCP crashes on image restore.

Fixes: 8726ade ("Adapt commands to work with several ogServers")
2022-09-27 09:48:36 +02:00
Javier Sánchez Parra 9961c4bc8d Improve scopes tree from Commands
Commit 648a1a315e1d35f67c5301833bddd3753cc51793 changes do not work well
with large scopes trees. It takes several minutes to check a scope.

Improve javascript code to speed up scope selection.
2022-09-27 09:48:36 +02:00
Javier Sánchez Parra 58f295fb1c Fix client room retrieving
Otherwise, retrieving do not work on clients inside folders.
2022-09-27 09:48:36 +02:00
Javier Sánchez Parra 49db9dc779 Replace parentheses in pills ids
From MDN:
Technically, the value for an id attribute may contain any character,
except whitespace characters. However, to avoid inadvertent errors, only
ASCII letters, digits, '_', and '-' should be used and the value for an
id attribute should start with a letter.

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id
2022-09-27 09:48:36 +02:00
Javier Sánchez Parra 5af589a94d Collapse servers images
Users can collapse images list by clicking on the server.
2022-09-27 09:48:36 +02:00
Daniel García Moreno 0c66443db8 Add multiple servers to the dashboard view 2022-09-27 09:48:36 +02:00
Daniel García Moreno ea18207998 Implement single room selection for commands view 2022-09-27 09:48:36 +02:00
Daniel García Moreno efe9731753 Add different selection mode for the tree view 2022-09-27 09:48:36 +02:00
Javier Sánchez Parra 1db12230f9 Adapt Delete clients to work with several ogServers
This commit makes Delete clients view to use "get_server_from_clients()"
function to send the deletion request to the correct ogServer.
2022-09-27 09:48:36 +02:00
Javier Sánchez Parra d74ad9336e Ignore unreachable ogServers
Otherwise, ogCP crashes trying to connect to unreachable ogServers.
2022-09-27 09:48:36 +02:00
Javier Sánchez Parra 3459de36f3 Add Servers section
In Servers section/view, users can add or delete ogServers from ogCP
configuration file.

Replaces Repositories views and recycle some of its code.
2022-09-27 09:48:36 +02:00
Javier Sánchez Parra 07c5cb25d2 Store configuration file path on a global variable
Otherwise, users may change the file path on one place of the code and
forget to change the other places.
2022-09-27 09:48:36 +02:00
Javier Sánchez Parra 083cb7af7f Adapt MAC retrieving to support several ogServers
Clients pills show MACs regardless of the ogServer they belong to. Flask
GET /client/mac API uses "get_server_from_clients()" function to send
the command to the correct ogServer.
2022-09-27 09:48:36 +02:00
Javier Sánchez Parra 083caf00c6 Adapt Delete image to work with several ogServers
This commit makes Delete image view to use ogServer field from
imagesForm to send the deletion request to the correct ogServer.
2022-09-27 09:48:36 +02:00
Javier Sánchez Parra 70eb7389bb Add ogServer parameter to imagesForm
When users select an image, its ogServer is sent too. Then, the back-end
(flask) processes the form to obtain this ogServer and send it the
pertinent requests.

It also makes "Image details" view use this new parameter, and adds
javascript code to ensure that users can only work with several images
at the same time if they belong to the same ogServer.
2022-09-27 09:48:36 +02:00
Javier Sánchez Parra c543ba25a6 Adapt images tree to work with several ogServers
Images view fetch images from all ogServers configured and show them in
the left tree as a nested list. ogServers are represented as the parents
of their images.
2022-09-27 09:48:36 +02:00
Javier Sánchez Parra 873bee30aa Adapt Delete center to work with several ogServers
This commit makes Delete center view to use ogServer field from
scopesForm to send the command to the correct ogServer.
2022-09-27 09:48:35 +02:00
Javier Sánchez Parra 43d2df0e7d Delete center using the scopes tree
With this commit users can select a center from the scopes tree, and
then delete it.
2022-09-27 09:48:35 +02:00
Javier Sánchez Parra 9ca010a981 Adapt Add center to work with several ogServers
This commit adds a new select input with all available ogServers to "Add
center" view. The ogCP creates the center in the ogServer selected by
the user.
2022-09-27 09:48:35 +02:00
Javier Sánchez Parra 3d42c2c66c Adapt Delete room to work with several ogServers
This commit makes Delete room view to use ogServer field from scopesForm
to send the command to the correct ogServer.
2022-09-27 09:48:35 +02:00
Javier Sánchez Parra f009a188b1 Delete room using the scopes tree
With this commit users can select a room from the scopes tree, and then
delete it.
2022-09-27 09:48:35 +02:00
Javier Sánchez Parra bf4192a5d4 Adapt Add room to work with several ogServers
This commit makes Add room view to use ogServer field from
scopesForm to send the command to the correct ogServer.
2022-09-27 09:48:35 +02:00
Javier Sánchez Parra 0cc65a057d Add a room to a center using the scopes tree
With this commit users can select a center from the scopes tree, and then
add a room to that center.
2022-09-27 09:48:35 +02:00
Javier Sánchez Parra 0db56d5eee Adapt Import Clients to work with several ogServers
This commit makes Import Clients view to use ogServer field from
scopesForm to send the command to the correct ogServer.
2022-09-27 09:48:35 +02:00
Javier Sánchez Parra f16b1a0347 Import clients to a room using the scopes tree
With this commit users can select a room from the scopes tree, and then
import clients to that room.
2022-09-27 09:48:35 +02:00
Javier Sánchez Parra 028f810a47 Fix selection of scopes with empty IPs list
This commit prevents ogcp from always mark as selected/checked scopes
that have an empty IP list.
2022-09-27 09:48:35 +02:00
Javier Sánchez Parra 229ad311be Add current ogServer to scopesForm
With this commit when users select a scope, the ogServer to
which it belongs is also sent. Then when processing the form we obtain
this ogServer and we can send it the pertinent requests.

This commit also makes action "Add client" to use the ogServer sent in
the form.
2022-09-27 09:48:35 +02:00
Javier Sánchez Parra 2614c9304e Add a client to a room using the scopes tree
With this commit users can select a room from the scopes tree, and then
add a client to that room.
2022-09-27 09:48:35 +02:00
Javier Sánchez Parra 75dc842284 Adapt commands to work with several ogServers
This commit makes commands views to use "get_server_from_clients()"
function to send the command to the correct ogServer.
2022-09-27 09:48:35 +02:00
Javier Sánchez Parra b4c0bd5c5e Fix ogServer names on the scopes tree
This commit adapt how "get_scopes()" accesses the name of the ogServer
because commit eae64dd changes how "multi_request()" returns it.

Fixes: eae64dd ("Initial support of ogServer requests routing")
2022-09-27 09:48:35 +02:00