narenas
/
opengnsys_ipxe
mirror of https://github.com/ipxe/ipxe.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[iscsi] Fix interoperability with QNAP TS-639Pro 

Modified-by: Michael Brown <mcb30@etherboot.org>
Signed-off-by: Michael Brown <mcb30@etherboot.org>
pull/1/head
Danny Volkind 2010-02-22 04:51:46 +00:00 committed by Michael Brown
parent f9f7863c55
commit cd9c94851b
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/net/tcp/iscsi.c
View File

@ -434,9 +434,9 @@ static int iscsi_tx_data_out ( struct iscsi_session *iscsi ) {
* *
* HeaderDigest=None * HeaderDigest=None
* DataDigest=None * DataDigest=None
* MaxConnections is irrelevant; we make only one connection anyway * MaxConnections is irrelevant; we make only one connection anyway [4]
* InitialR2T=Yes [1] * InitialR2T=Yes [1]
* ImmediateData is irrelevant; we never send immediate data * ImmediateData is irrelevant; we never send immediate data [4]
* MaxRecvDataSegmentLength=8192 (default; we don't care) [3] * MaxRecvDataSegmentLength=8192 (default; we don't care) [3]
* MaxBurstLength=262144 (default; we don't care) [3] * MaxBurstLength=262144 (default; we don't care) [3]
* FirstBurstLength=262144 (default; we don't care) * FirstBurstLength=262144 (default; we don't care)
@ -459,6 +459,11 @@ static int iscsi_tx_data_out ( struct iscsi_session *iscsi ) {
* these parameters, but some targets (notably OpenSolaris) * these parameters, but some targets (notably OpenSolaris)
* incorrectly assume a default value of zero, so we explicitly * incorrectly assume a default value of zero, so we explicitly
* specify the default values. * specify the default values.
*
* [4] We are quite happy to use the RFC-defined default values for
* these parameters, but some targets (notably a QNAP TS-639Pro) fail
* unless they are supplied, so we explicitly specify the default
* values.
*/ */
static int iscsi_build_login_request_strings ( struct iscsi_session *iscsi, static int iscsi_build_login_request_strings ( struct iscsi_session *iscsi,
void *data, size_t len ) { void *data, size_t len ) {
@ -516,7 +521,9 @@ static int iscsi_build_login_request_strings ( struct iscsi_session *iscsi,
used += ssnprintf ( data + used, len - used, used += ssnprintf ( data + used, len - used,
"HeaderDigest=None%c" "HeaderDigest=None%c"
"DataDigest=None%c" "DataDigest=None%c"
"MaxConnections=1%c"
"InitialR2T=Yes%c" "InitialR2T=Yes%c"
"ImmediateData=No%c"
"MaxRecvDataSegmentLength=8192%c" "MaxRecvDataSegmentLength=8192%c"
"MaxBurstLength=262144%c" "MaxBurstLength=262144%c"
"DefaultTime2Wait=0%c" "DefaultTime2Wait=0%c"
@ -525,7 +532,7 @@ static int iscsi_build_login_request_strings ( struct iscsi_session *iscsi,
"DataPDUInOrder=Yes%c" "DataPDUInOrder=Yes%c"
"DataSequenceInOrder=Yes%c" "DataSequenceInOrder=Yes%c"
"ErrorRecoveryLevel=0%c", "ErrorRecoveryLevel=0%c",
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ); 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 );
} }
return used; return used;