narenas
/
opengnsys_ipxe
mirror of https://github.com/ipxe/ipxe.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[intel] Refill receive ring only after enabling receiver 

On 82576 (and probably others), the datasheet states that "the tail
register of the queue (RDT[n]) should not be bumped until the queue is
enabled".  There is some confusion over exactly what constitutes
"enabled": the initialisation blurb says that we should "poll the
RXDCTL register until the ENABLE bit is set", while the description
for the RXDCTL register says that the ENABLE bit is set by default
(for queue zero).  Empirical evidence suggests that the ENABLE bit
reads as set immediately after writing to RCTL.EN, and so polling is
not necessary.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
pull/598/head
Michael Brown 2012-07-10 09:32:58 +01:00
parent 2c72ce04ae
commit 8391ff3ee0
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/drivers/net/intel.c
View File

@ -491,9 +491,6 @@ static int intel_open ( struct net_device *netdev ) {
if ( ( rc = intel_create_ring ( intel, &intel->rx ) ) != 0 ) if ( ( rc = intel_create_ring ( intel, &intel->rx ) ) != 0 )
goto err_create_rx; goto err_create_rx;
/* Fill receive ring */
intel_refill_rx ( intel );
/* Program MAC address */ /* Program MAC address */
memset ( &mac, 0, sizeof ( mac ) ); memset ( &mac, 0, sizeof ( mac ) );
memcpy ( mac.raw, netdev->ll_addr, sizeof ( mac.raw ) ); memcpy ( mac.raw, netdev->ll_addr, sizeof ( mac.raw ) );
@ -515,6 +512,9 @@ static int intel_open ( struct net_device *netdev ) {
INTEL_RCTL_BAM | INTEL_RCTL_BSIZE_2048 | INTEL_RCTL_SECRC ); INTEL_RCTL_BAM | INTEL_RCTL_BSIZE_2048 | INTEL_RCTL_SECRC );
writel ( rctl, intel->regs + INTEL_RCTL ); writel ( rctl, intel->regs + INTEL_RCTL );
/* Fill receive ring */
intel_refill_rx ( intel );
/* Update link state */ /* Update link state */
intel_check_link ( netdev ); intel_check_link ( netdev );