narenas
/
opengnsys_ipxe
mirror of https://github.com/ipxe/ipxe.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[iscsi] Report SCSI response only when applicable 

iSCSI generally includes a full SCSI response only when an error
occurs.  iscsi_scsi_done() currently passes the NULL response through
to scsi_response(), which ends up causing scsicmd_response() to
dereference a NULL pointer.

Fix by calling scsi_response() only if we have a non-NULL response.

Reported-by: Brendon Walsh <brendonwalsh@niamu.com>
Tested-by: Brendon Walsh <brendonwalsh@niamu.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
pull/6/head
Michael Brown 2012-05-16 10:50:56 +01:00
parent a33298dcda
commit 73b21174b2
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/net/tcp/iscsi.c
View File

@ -337,6 +337,7 @@ static void iscsi_scsi_done ( struct iscsi_session *iscsi, int rc,
iscsi->command = NULL; iscsi->command = NULL;
/* Send SCSI response, if any */ /* Send SCSI response, if any */
if ( rsp )
scsi_response ( &iscsi->data, rsp ); scsi_response ( &iscsi->data, rsp );
/* Close SCSI command, if this is still the same command. (It /* Close SCSI command, if this is still the same command. (It