narenas
/
opengnsys_ipxe
mirror of https://github.com/ipxe/ipxe.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[tcpip] Fix dubious calculation of min_port 

Detected using sparse.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
pull/35/head
Michael Brown 2015-03-13 10:19:44 +00:00
parent 7f80eb511e
commit 57bab4e1d3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/net/tcpip.c
View File

@ -235,7 +235,7 @@ int tcpip_bind ( struct sockaddr_tcpip *st_local,
/* Otherwise, find an available port in the range [1,1023] or /* Otherwise, find an available port in the range [1,1023] or
* [1025,65535] as appropriate. * [1025,65535] as appropriate.
*/ */
min_port = ( ( ( ! flags ) & TCPIP_BIND_PRIVILEGED ) + 1 ); min_port = ( ( ( ~flags ) & TCPIP_BIND_PRIVILEGED ) + 1 );
max_port = ( ( flags & TCPIP_BIND_PRIVILEGED ) - 1 ); max_port = ( ( flags & TCPIP_BIND_PRIVILEGED ) - 1 );
offset = random(); offset = random();
for ( i = 0 ; i <= max_port ; i++ ) { for ( i = 0 ; i <= max_port ; i++ ) {