narenas
/
opengnsys_ipxe
mirror of https://github.com/ipxe/ipxe.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[efi] Always map full length of coherent DMA buffer allocation 

The EFI PCI API takes a page count as the input to AllocateBuffer()
but a byte count as the input to Map().  There is nothing in the UEFI
specification that requires us to map exactly the allocated length,
and no systems have yet been observed that will fail if the map length
does not exactly match the allocated length.  However, it is plausible
that some implementations may fail if asked to map a length that does
not match the length of the corresponding allocation.

Avoid potential future problems by always mapping the full allocated
length.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
pull/331/head
Michael Brown 2021-04-20 14:37:08 +01:00
parent e4afaa2246
commit 3efdbef2f0
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/interface/efi/efi_pci.c
View File

@ -523,7 +523,8 @@ static void * efipci_dma_alloc ( struct dma_device *dma,
/* Map buffer */ /* Map buffer */
if ( ( rc = efipci_dma_map ( dma, map, virt_to_phys ( addr ), if ( ( rc = efipci_dma_map ( dma, map, virt_to_phys ( addr ),
len, DMA_BI ) ) != 0 ) ( pages * EFI_PAGE_SIZE ),
DMA_BI ) ) != 0 )
goto err_map; goto err_map;
/* Increment allocation count (for debugging) */ /* Increment allocation count (for debugging) */