narenas
/
opengnsys_ipxe
mirror of https://github.com/ipxe/ipxe.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Restore the "shared symbol found only in a single object should be 

treated as being provided by that object" code.
pull/1/head
Michael Brown 2007-07-17 01:39:06 +01:00
parent 62d92348fe
commit 19904804da
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/util/symcheck.pl
View File

@ -97,7 +97,7 @@ while ( ( my $object, my $symbols ) = each %$symtab ) {
} else { } else {
$category = "provides"; $category = "provides";
} }
$globals->{$symbol}->{$category}->{$object} = $info->{section}; $globals->{$symbol}->{$category}->{$object} = 1;
} }
} }
} }
@ -110,6 +110,13 @@ while ( ( my $symbol, my $info ) = each %$globals ) {
my @requires = keys %{$info->{requires}}; my @requires = keys %{$info->{requires}};
my @shares = keys %{$info->{shares}}; my @shares = keys %{$info->{shares}};
if ( ( @provides == 0 ) && ( @shares == 1 ) ) {
# A symbol "shared" by just a single file is actually being
# provided by that file; it just doesn't have an initialiser.
@provides = @shares;
@shares = ();
}
if ( ( @requires > 0 ) && ( @provides == 0 ) && ( @shares == 0 ) ) { if ( ( @requires > 0 ) && ( @provides == 0 ) && ( @shares == 0 ) ) {
# No object provides this symbol, but some objects require it. # No object provides this symbol, but some objects require it.
$problems->{$_}->{nonexistent}->{$symbol} = 1 foreach @requires; $problems->{$_}->{nonexistent}->{$symbol} = 1 foreach @requires;
@ -120,7 +127,7 @@ while ( ( my $symbol, my $info ) = each %$globals ) {
foreach my $provide ( @provides ) { foreach my $provide ( @provides ) {
if ( $provide eq "LINKER" ) { if ( $provide eq "LINKER" ) {
# Linker-provided symbols are exempt from this check. # Linker-provided symbols are exempt from this check.
} elsif ( $info->{provides}->{$provide} =~ /^\.tbl\./ ) { } elsif ( $symtab->{$provide}->{$symbol}->{section} =~ /^\.tbl\./ ) {
# Linker tables are exempt from this check. # Linker tables are exempt from this check.
} else { } else {
$problems->{$provide}->{unused}->{$symbol} = 1; $problems->{$provide}->{unused}->{$symbol} = 1;