narenas
/
opengnsys_ipxe
mirror of https://github.com/ipxe/ipxe.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[hermon] Work around missing mport support in current BOFM implementations 

Current BOFM versions are unable to create entries with mport>1, which
means that only the port 1 MAC address can be explicitly specified.

Work around this by using the provided MAC address as a base address
for all subsequent ports.  For example, if BOFM assigns the address

   00:1A:64:76:00:09 for port 1

then we will assign the addresses

   00:1A:64:76:00:09 for port 1
   00:1A:64:76:00:0a for port 2

Future BOFM versions that may correctly support mport will work with
this scheme without modification provided that the BOFM entries are
created in increasing order of mport.  Since BOFM tools tend to
generate entries in increasing order (of slot, port, etc), this is not
an unreasonable compromise.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
pull/5/head
Michael Brown 2011-04-07 13:53:28 +01:00
parent 08f122ae42
commit 15c120041d
1 changed files with 39 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/drivers/infiniband/hermon.c
View File

@ -3382,13 +3382,32 @@ static int hermon_bofm_update ( struct bofm_device *bofm, unsigned int mport,
union {
uint8_t bytes[8];
uint32_t dwords[2];
uint64_t qword;
} buf;
uint8_t *mac_copy = &buf.bytes[ sizeof ( buf.bytes ) - ETH_ALEN ];
int rc;
/* Prepare MAC address */
memset ( &buf, 0, sizeof ( buf ) );
memcpy ( &buf.bytes[ sizeof ( buf.bytes ) - ETH_ALEN ], mac,
ETH_ALEN );
memcpy ( mac_copy, mac, ETH_ALEN );
/* Current BOFM versions are unable to create entries with
* mport>1, which means that only the port 1 MAC address can
* be explicitly specified. Work around this by using the
* provided MAC address as a base address for all subsequent
* ports. For example, if BOFM assigns the address
*
* 00:1A:64:76:00:09 for port 1
*
* then we will assign the addresses
*
* 00:1A:64:76:00:09 for port 1
* 00:1A:64:76:00:0a for port 2
*
* Note that hermon->cap.num_ports is not yet defined at this
* point.
*/
for ( ; mport <= HERMON_MAX_PORTS ; mport++ ) {
/* Modify static configuration */
memset ( &stat_cfg, 0, sizeof ( stat_cfg ) );
@ -3401,12 +3420,17 @@ static int hermon_bofm_update ( struct bofm_device *bofm, unsigned int mport,
HERMON_MOD_STAT_CFG_OFFSET ( mac_m ),
&stat_cfg ) ) != 0 ) {
DBGC ( hermon, "Hermon %p port %d could not modify "
"configuration: %s\n", hermon, mport, strerror ( rc ) );
"configuration: %s\n",
hermon, mport, strerror ( rc ) );
return rc;
}
DBGC ( hermon, "Hermon %p port %d updated MAC address to %s\n",
hermon, mport, eth_ntoa ( mac ) );
hermon, mport, eth_ntoa ( mac_copy ) );
/* Increment MAC address */
buf.qword = cpu_to_be64 ( be64_to_cpu ( buf.qword ) + 1 );
}
return 0;
}