narenas
/
opengnsys_ipxe
mirror of https://github.com/ipxe/ipxe.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[usb] Improve debug messages for failed control transactions 

Signed-off-by: Michael Brown <mcb30@ipxe.org>
pull/35/head
Michael Brown 2015-03-23 20:18:02 +00:00
parent b418af26d9
commit 026b3446b9
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/drivers/bus/usb.c
View File

@ -708,10 +708,6 @@ static void usb_control_complete ( struct usb_endpoint *ep,
/* Record completion status in buffer */ /* Record completion status in buffer */
pshdr = iob_push ( iobuf, sizeof ( *pshdr ) ); pshdr = iob_push ( iobuf, sizeof ( *pshdr ) );
pshdr->rc = rc; pshdr->rc = rc;
if ( rc != 0 ) {
DBGC ( usb, "USB %s control transaction failed: %s\n",
usb->name, strerror ( rc ) );
}
/* Add to list of completed I/O buffers */ /* Add to list of completed I/O buffers */
list_add_tail ( &iobuf->list, &usb->complete ); list_add_tail ( &iobuf->list, &usb->complete );
@ -793,6 +789,9 @@ int usb_control ( struct usb_device *usb, unsigned int request,
/* Fail immediately if completion was in error */ /* Fail immediately if completion was in error */
if ( rc != 0 ) { if ( rc != 0 ) {
DBGC ( usb, "USB %s control %04x:%04x:%04x "
"failed: %s\n", usb->name, request,
value, index, strerror ( rc ) );
free_iob ( cmplt ); free_iob ( cmplt );
return rc; return rc;
} }
@ -809,8 +808,8 @@ int usb_control ( struct usb_device *usb, unsigned int request,
mdelay ( 1 ); mdelay ( 1 );
} }
DBGC ( usb, "USB %s timed out waiting for control transaction\n", DBGC ( usb, "USB %s timed out waiting for control %04x:%04x:%04x\n",
usb->name ); usb->name, request, value, index );
return -ETIMEDOUT; return -ETIMEDOUT;
err_message: err_message: