Commit Graph

232 Commits (9891276246b96ca1bc43383b3e434a7d8f0ed91f)

Author SHA1 Message Date
Jose M. Guisado b6b1040997 #1065 client: add support for ogclient win state
ogClient can be run in windows mode, enabling connection with ogServer
when running on a Windows machine.

Don't expect the same payload in windows mode as a in live or virtual.
Client in windows mode does not send partition setup information, only
the status/state. (same case for linux mode)
2021-11-17 10:36:50 +01:00
Jose M. Guisado 5a3fd51261 #1065 client: add support for ogclient linux state
ogClient can be run in linux mode, intended for exposing some
ogServer commands when running in a linux distribution.

When connecting with a client in linux mode, do not expect a full
partition setup response. Just expect a 'status', and then accept
the connection without updating any partition information in
the database.
2021-11-17 09:07:57 +01:00
OpenGnSys Support Team ac3ce22c35 #1064 revisit error handling from ogClient
200 => successful command, run next pending command
202 => successful command in progress, do not run next pending command
403 => server sent a malformed HTTP header, should not ever happen,
       close connection (server is buggy?).
500 => client fails to run command, report error and run next pending command
503 => client is busy, report error and do not run next pending command

Anything else, should not ever happen (client is buggy?), close connection with
client.

On error, when processing response from ogClient, do not close the connection,
instead annotate in the database that command was not successful and run next
pending command.

*Only* if client replies status code 500 set last_cmd to UNSPEC so its state is
not BSY as reported by og_client_status function and pending cmds can be
sent.
2021-11-12 11:06:13 +01:00
OpenGnSys Support Team 6fc89cdfc4 #1042 incorrect initialization of software profiles array
The position 0 of the software profiles array is not initialized,
this triggers a bug randomly on image creation if the position 0
comes zero. Adjust the loop to initialize position 0 accordingly.
2021-10-20 09:57:41 +02:00
Jose M. Guisado e16f36cdef #915 Fix create image payload parsing
Commit 141b0797e1 introduced command scheduling rest api to
ogserver. Part of this changeset included
og_json_parse_create_image as a utility funtion to parse the json
payload of a "create image" command.

og_json_parse_create_image did not include the parsing of optional
parameters "description", "center_id" and "group_id". New components
like ogCP or ogCLI use these parameters.

Fix this by adding a struct og_image member to the struct og_msg_params
and assigning it when processing a "create image" command.

This could be extended to further payload parsing for image related
commands in the future.
2021-10-19 07:54:35 +00:00
Javier Sánchez Parra 36f02324e0 #915 Add POST /image/delete method
Delete operation for images stored in the server. It deletes an image
from the database and filesystem, thus images must exists in both places.

POST /image/delete
{
	"image": "3"
}
2021-10-04 17:44:50 +02:00
Jose M. Guisado 2d68f8a0ec #1061 add timeout to pending scheduled commands
Pending schedule commands can deny ogLive boot of clients due
to filling of pending cmd queue with commands such as "Iniciar Sesión".

For example: Using RemotePC to serve clients that do not boot into
ogLive will fill up the pending command queue with "Iniciar Sesión".

Introduce a safety timeout for pending (scheduled) commands to
avoid this situation.
2021-09-06 12:32:38 +02:00
Jose M. Guisado 047677bb4b #1054 Fix og_legacy_partition code buffer size
The "code" member of the og_legacy_partition is used to hold the string of
the partition type *name* for legacy parameter strings. Example:

par=2*cpt=LINUX-SWAP*sfi=LINUX-SWAP*tam=10000000*ope=0

Problem: Buffer size is smaller than possible values for this member.
Fix: Increase buffer size up to the max length defined in the DB
for the corresponding column.
2021-07-26 16:58:40 +02:00
Jose M. Guisado 8190c6f6df #1051 Initialize task_id once in og_cmd_post_schedule_command
Fixes task_id re-initialization in commit 33d8cecfe.

Task id is to be initialized with the "session" value and can be done
out of the for loop it was before. Avoiding unnecesary snprintf's with
the same value.
2021-07-22 16:06:26 +02:00
Jose M. Guisado 261d490c4e #1052 Populate session column when adding actions
If the scope of a command, procedure or task is related to a group of
computers then actions associated with that schedule can share the same
session value.

og_dbi_add_action was not initializing session value, as it is only used
for visualization purposes in the legacy web interface.

This patch enables og_dbi_add_action to populate session column by
assigning it the id value of the first action related to the scope.

Example: Power off command for a room scope of 4 clients will result in
4 actions, a power off for each client. The first action id will determine
the session value for the rest.
2021-07-22 15:52:12 +02:00
Jose M. Guisado 33d8cecfe1 #1051 Fix command schedule for several clients
A single command can be schedule for several clients.

Commit 141b0797e1 introduces a regression when scheduling a command for
several clients, the command only executes successfuly for the first
one.

Fix it by reintroducing the usage of the 'session' column to group
a single command into several actions (one for each client), the web
console interface already expects this 'session' column to be set
accordingly.
2021-07-21 17:55:55 +02:00
Javier Sánchez Parra 7325a8629e #915 Add POST /task/add method
Adds the possibility to create a task with procedures and other tasks
integrated as steps.

Note: "steps" parameter is optional and "steps" array object order
defines execution order.

Request:
POST /task/add
{
  "center": "1",
  "name": "task",
  "description": "My task",
  "steps": [
             {
               "procedure": 4
             },
             {
               "task": 1
             },
             {
               "procedure": 24
             }
           ]
}

Response:
200 OK

This commit also add task case to procedure's step processing.
Otherwise, gcc prints the following warning:

src/rest.c: In function ‘og_procedure_add_steps’:
src/rest.c:4089:17: warning: enumeration value ‘OG_STEP_TASK’ not handled in switch [-Wswitch]
 4089 |                 switch (step->type) {
      |                 ^~~~~~
2021-07-01 09:20:46 +02:00
Javier Sánchez Parra a496da17ea #915 Add POST /procedure/update method
Adds the possibility to update a procedure with commands and other
procedures integrated as steps.

Note: "steps" parameter is optional and "steps" array object order
defines execution order. Also, if the body has empty steps, the
procedure loses its previous steps.

Request:
POST /procedure/update
{
  "procedure": "34",
  "center": "1",
  "name": "procedure-edited",
  "description": "My procedure edited",
  "steps": [
             {
               "command": "wol",
               "params": { "type": "broadcast" }
             },
             {
               "procedure": 24
             },
             {
               "command": "reboot",
               "params": {}
             }
           ]
}

Response:
200 OK
2021-06-29 11:48:33 +02:00
Javier Sánchez Parra cf7d0742a3 Fix procedure id retrieving in steps creation
Otherwise, procedure id is always zero.

Fixes: 1fdb7e6d1c
2021-06-29 11:48:28 +02:00
Javier Sánchez Parra 66ba6d045e #915 Filter queued commands by id
ogServer searches queued commands (formerly actions) in the DB by
session. This can lead to problems because session is not an uniquely
identifier but an identifier that several commands can share to group
them.

This commit changes query filter from session to id, ensuring correct
results

This reverts commit d9b6aadf66.
2021-06-16 12:16:37 +02:00
Javier Sánchez Parra c03b87dcc6 #915 Add POST /procedure/run method
Add ogServer support procedure execution. Now users can send a procedure
and a list of clients to ogServer, then ogServer breaks down the
procedure into commands (formerly actions) and queues them for each
indicated client.

TODO: Do not reply 200 OK when the procedure do not exist.

Request:
POST /procedure/run
{
  "clients": ["192.168.56.11", "192.168.56.12"],
  "procedure": "33"
}

Response:
200 OK
2021-06-15 12:11:16 +02:00
Jose M. Guisado 830c321062 #915 Add procedure/delete
Delete operation for procedures stored in the database.

POST /procedure/delete
{
	"id": "7"
}

If no procedure is found returns 200 OK but a syslog call is issued to
warn so. Such behavior will likely change in the future.
2021-06-11 11:34:59 +02:00
Jose M. Guisado d9b6aadf66 #915 Revert filtering actions by id to "sesion" in og_dbi_queue_command
Commit 141b079 introduced a slight change in how rows from table
"acciones" are filtered when queuing a command, from "sesion" column to
"idaccion" column.

This seemed reasonable, as id column is the one autoincrementing. But
remotepc queued commands inserting actions id using a timestamp instead
of the action row id.

See c17ffa5d03/admin/WebConsole/rest/remotepc.php (L188)

Revert said change as long as remotepc keeps such behavior.
2021-06-10 17:36:51 +02:00
OpenGnSys Support Team 87774ab087 constify json parse helper function
json_t * parameter is not modified, constify to allow compiler to spew warnings
in case the function tries to modify it.
2021-06-10 17:05:07 +02:00
OpenGnSys Support Team 88c8b52e88 move json function declarations to json.h
These function declarations belong to json.h:

int og_json_parse_partition_setup(json_t *element, struct og_msg_params *params);
int og_json_parse_create_image(json_t *element, struct og_msg_params *params);
int og_json_parse_restore_image(json_t *element, struct og_msg_params *params);
2021-06-10 17:00:43 +02:00
Javier Sánchez Parra 1fdb7e6d1c #915 Add commands and procedures to procedure creation
Adds the possibility to create a procedure with commands and other
procedures integrated as steps.

Note: "steps" parameter is optional and "steps" array object order
defines execution order.

Request:
POST /procedure/add
{
  "center": "1",
  "name": "procedure",
  "description": "My procedure",
  "steps": [
             {
               "command": "wol",
               "params": { "type": "broadcast" }
             },
             {
               "procedure": 22
             },
             {
               "command": "poweroff",
               "params": {}
             }
           ]
}

Response:
200 OK

This commit also updates unit tests for /procedure/add POST method to
include steps.
2021-06-10 17:00:01 +02:00
OpenGnSys Support Team 893101ffc6 missing copyright header to new src/legacy.c file 2021-06-09 23:17:51 +02:00
Jose M. Guisado 141b0797e1 #915 Add schedule/command
Enables ogserver to schedule commands (also referred as actions in
legacy web console jargon).

This feature enables ogserver to write in the "acciones" table in order
to have full capabilities for command scheduling purposes, thus not
depending in the legacy web console to insert into "acciones" table.
2021-06-09 13:41:28 +02:00
Jose M. Guisado cb7fa569b2 #941 Free dbi_inst when og_dbi_open fails to connect
When trying to open a connection to a database, an instance of
libdbi is created before any connection attempt. If connection is
unsuccessful then the og_dbi struct is freed but not the
libdbi instance member, thus leaking its memory.

Use libdbi dbi_shutdown_r to shutdown libdbi instance member
before freeing og_dbi struct inside og_dbi_open.
2021-06-01 14:14:15 +02:00
Javier Sánchez Parra 41fad11408 #942 Add POST /procedure/add method
This method adds a procedure associated with a center to the database.
Required payload parameters are center and name, description is
optional.

Note: ogServer does not allow to add more than one procedure with the
same name and center.

Request:
POST /procedure/add
{
  "center": "1"
  "name": "procedure1"
  "description": "My procedure"
}

Response:
200 OK

This commit also adds unit tests for /procedure/add POST method.
2021-05-31 13:01:47 +02:00
OpenGnSys Support Team ee2f909dbe #1042 fix multiple definition of ogconfig
/usr/bin/ld: src/schema.o:/home/soleta/opengnsys/ogServer/src/schema.c:50: multiple definition of `ogconfig'; src/main.o:/home/soleta/opengnsys/ogServer/src/main.c:31: first defined here
 collect2: error: ld returned 1 exit status
 make: *** [Makefile:411: ogserver] Error 1
2021-05-27 12:22:49 +02:00
Javier Sánchez Parra a00eccc767 #1037 Simplify database update v3 code
Simplify database update v3, no need for iteration.

Fixes: 12d8fff (#1037 Add disk type)
2021-05-27 11:02:42 +02:00
Javier Sánchez Parra 12d8fff3ef #1037 Add disk type
Add ogServer support for parsing and storing in the DB disk type data
from ogClient refresh response.

See also commits with #1037 in ogClient and WebConsole repo.
2021-05-26 17:19:30 +02:00
Javier Sánchez Parra 10c9559dfc #1037 Make partition parameter validation permissive
Otherwise, ogServer rejects the response if ogClient sends more
parameters than required.
2021-05-26 17:19:30 +02:00
Javier Sánchez Parra bc9424724d Add REST POST /room/delete method
This method deletes a room (lab) from the DB and deletes on cascade
computers and computers partitions.

Note: if the room id do not exists in the database, ogserver still
tries to delete it and replies with 200 OK.

Request:
POST /room/delete
{
  "id": "1"
}

Response:
200 OK
2021-05-10 13:39:38 +02:00
Javier Sánchez Parra b48707333f #942 Add REST POST /center/delete method
This method deletes a center from the DB and deletes on cascade
rooms/labs, computers and computers partitions.

Note: if the center id do not exists in the database, ogserver still
tries to delete it and replies with 200 OK.

Request:
POST /center/delete
{
  "id": "1"
}

Response:
200 OK
2021-05-10 12:07:53 +02:00
OpenGnSys Support Team d3e9b5727a #980 ignore unknown attributes
If ogClient sends an unknown attribute, ignore it.
2021-05-04 18:29:15 +02:00
Jose M. Guisado 40d4279b31 #995 Add link speed parsing to client probe response
If a probe response contains speedinformation, parse and store
it inside the client struct. Speed is interpreted as an unsigned
integer representing Mbit/s.
2021-05-04 18:13:35 +02:00
OpenGnSys Support Team a7cce8d442 ogServer is AGPLv3+
Update license header in files.
2021-05-04 17:59:11 +02:00
OpenGnSys Support Team 79e7e2b8c8 #915 only API REST is supported
Socket hidra API has been removed, all connections use a REST API.
2021-05-04 16:14:38 +02:00
OpenGnSys Support Team 8a0a32cea1 #580 remove old keepalive code
Needed by the old socket Hydra that does not exist anymore
2021-05-04 16:11:34 +02:00
Jose M. Guisado 927d42bdf8 #1043 don't create wol entries when client is connected
Avoids multiple entries of a same client like

{"clients": [{"addr": "192.168.2.230", "state": "WOL_SENT"}, {"addr": "192.168.2.230", "state": "OPG"}]

These can arise when ogserver processes a WoL request for an already
connected client.

When processing the WoL request, search for the target address in the
clients list, if found we avoid creating the wol entry.
2021-04-29 13:11:34 +02:00
OpenGnSys Support Team 1f13855e41 #1043 add WOL_SENT state
WOL_SENT tells that WakeOnLan was sent to computer, after 60 seconds,
if computer does not boot, this state is released.
2021-04-29 11:52:32 +02:00
OpenGnSys Support Team c05f1345e7 #1043 add function to append client to json tree
og_json_client_append() adds a client objet to the json tree.
2021-04-29 11:52:04 +02:00
Jose M. Guisado 8775c06d36 #1042 Add schema version 2
Add foreign keys (version 1 introduced innoDB as default db engine)
allowing cascade deletions for some tables:

	- perfilessoft_softwares

	If a software profile or a software component is deleted, the
	corresponding row in this table will be deleted too.

	- ordenadores_particiones

	If a computer or a partition is deleted from the DB, delete the
	corresponding row inside this table.

	- aulas

	If the center the room is in is removed, delete the room too.

	- ordenadores

	If the room in which a computer is in is removed, the computer
	will be deleted accordingly.

We should take into account that this schema superseeds some code
regarding deletions inside WebConsole that probably are not needed any
more, at least for the tables mentioned.
(See admin/WebConsole/gestores/relaciones/*.php in OpenGnsys repo)
2021-04-28 12:10:27 +02:00
OpenGnSys Support Team 3b1f2c293f #980 Broken TCP connection times out after 120 seconds through keepalive
Enable TCP keepalive to detect if the ogClient is gone (hard reset). If no reply
after 120 seconds, then release the connection to the client.
2021-04-22 12:24:42 +02:00
Javier Sánchez Parra 29e7641e91 #915 Add /room/add POST method
Adds POST method to add rooms (labs), required payload parameters are
name, netmask and center; any additional attributes are optional.

Required JSON:
        { "center": 0,
          "name": "classroom10",
          "netmask": "255.255.255.0" }

Full JSON:
        { "center": 0,
          "name": "classroom11",
          "netmask": "255.255.255.0",
          "group": 0,
          "location": "First floor",
          "gateway": "192.168.56.1",
          "ntp": "hora.cica.es",
          "dns": "1.1.1.1",
          "remote": True }

This commit also adds unit tests for /room/add POST method.
2021-04-20 12:05:42 +02:00
Jose M. Guisado 7d74d42c79 #1042 Update database schema automatically
This patch adds database schema management capabilities to ogServer:

- ogServer now tracks the version of its database schema, if no version
is detected, creates a 'version' table with a single row starting at 0.
- ogServer can upgrade its database schema to a newer version if
detected. (ogServer ships required SQL commands to do so)

If ogServer is unable to upgrade the schema at startup (if needed be) it
*will not* start.

Defines schema update v1 which upgrades database engine tables of
ogServer database (usually named 'ogAdmBD') from myISAM to innoDB.
2021-04-20 11:27:21 +02:00
Javier Sánchez Parra 49fc6c5c5c #915 increase maximum API REST response size
GET /scope could generate a response larger than 64 Kbytes.
Rise the maximum API REST response size to 256 Kbytes.
2021-04-19 12:01:39 +02:00
Javier Sánchez Parra 90eab86796 #915 fix "response too large" error path
Otherwise, ogServer sends "200 OK" after a "500 Internal Server Error
error" response.
2021-04-19 12:01:16 +02:00
Javier Sánchez Parra 2c6cef71d8 #915 validate response json size
Otherwise, copying response json to response buffer could lead to stack
smashing is the json response is too large.

stdout example:
*** stack smashing detected ***: <unknown> terminated
2021-04-19 12:00:27 +02:00
Jose M. Guisado 746166e4c2 #971 Remove sql bottleneck when removing software profiles
Several universities have reported that creating a software profile
hangs the machine running the ogServer for a while, sometimes up to
minutes.

Legacy SQL code is producing said bottleneck, responsible for pruning a
intermediate table between "perfilessoft" and "softwares". There is
redundant code, "perfilssoft" should be pruned first, speeding up the
later task of pruning the intermediate table "perfilessoft_softwares"

There is no need to execute:

DELETE FROM perfilessoft_softwares
WHERE idperfilsoft IN (
	SELECT idperfilsoft
	FROM perfilessoft
	WHERE idperfilsoft NOT IN (
		SELECT DISTINCT idperfilsoft
		from ordenadores_particiones)
		AND idperfilsoft NOT IN (
			SELECT DISTINCT idperfilsoft from imagenes))

When afterwards "perfilessoft" is going to be pruned and
"perfilessoft_softwares" pruned again:

DELETE FROM perfilessoft WHERE idperfilsoft NOT IN
                (SELECT DISTINCT idperfilsoft from ordenadores_particiones)
                AND  idperfilsoft NOT IN
                (SELECT DISTINCT idperfilsoft from imagenes)

DELETE FROM perfilessoft_softwares WHERE idperfilsoft NOT IN
                        (SELECT idperfilsoft from perfilessoft)

The two latter commands suffice.

This should not happen when using a relational database supporting
foreign keys and ON DELETE CASCADE, like innoDB, which will be adopted
soon.
2021-04-16 13:31:45 +02:00
Jose M. Guisado 42c22539a3 schedule: fix daylight saving problem with mktime()
mktime modifies the struct tm it receives and takes into account whether DST is
active or not (tm_isdst). tm_isdst == 0 adjusts the time, which causes the time
mismatch error.

All fields are being initialized to 0 and therefore it is assumed that the time
that has been passed is not in daylight saving time.

When the value is negative in tm.tm_isdst it delegates to mktime to guess if it
is in daylight saving time or not, this works 99% of the time.

Best way would be that ogserver knows what is its timezone and when daylight
saving applies, so tm_isdst is set to 0 or 1 accordingly.

Meanwhile, "tm_isdst = -1" provides the hotfix.
2021-04-12 17:08:00 +02:00
Jose M. Guisado 0212091e7f #915 Add /center/add POST method
Adds POST method to add centers (organizational unit), required payload
parameter is the name, and an additional comment is optional.

	{"name": "ACME"}

	{"name": "ACME", "comment": "Some comment"}
2021-04-08 11:12:23 +02:00
Jose M. Guisado 11d6e84b8e #915 Avoid duplicate db entries in /create/image
/create/image adds an entry to the database for the given partition
image created when payload contains a "description" attribute. This
insertion into the database is lacking a check for duplicates, which are
not supported for the images table.

Add a prior duplicate check before inserting. Exit with -1 code if an
image with the same name is found.
2021-04-06 13:11:50 +02:00
Javier Sánchez Parra 8015f85b04 #915 Add GET /oglive/test REST API function
This function returns the installed and available ogLiveS in the server
to be booted from.

Request:
GET /oglive/list
NO BODY

Response
200 OK
{
  "oglive": [
    {
      "distribution": "bionic",
      "kernel": "5.4.0-40-generic",
      "architecture": "amd64",
      "revision": "r20200629",
      "directory": "ogLive-5.4.0-r20200629",
      "iso": "ogLive-bionic-5.4.0-40-generic-amd64-r20200629.85eceaf.iso"
    },
    {
      "distribution": "bionic",
      "kernel": "5.0.0-27-generic",
      "architecture": "amd64",
      "revision": "r20190830",
      "directory": "ogLive-5.0.0-r20190830",
      "iso": "ogLive-bionic-5.0.0-27-generic-amd64-r20190830.7208cc9.iso"
    }
  ],
  "default": 0
}

This commit also adds tests for GET /oglive/test.
2021-04-05 18:00:56 +02:00
Diego Crespo Quinta d9e1521a16 #1004 Add GET /images test
Fix incorrect error if json is missing.
2021-03-30 16:11:45 +02:00
OpenGnSys Support Team a71cba4df1 #990 fix crash in wol with malformed IP address
==28831== 1 errors in context 1 of 2:
==28831== Invalid read of size 1
==28831==    at 0x55AC6FD: inet_aton (inet_addr.c:127)
==28831==    by 0x10ECCA: WakeUp (ogAdmServer.c:337)
==28831==    by 0x10EED6: Levanta (ogAdmServer.c:292)
==28831==    by 0x11651E: og_cmd_wol (rest.c:498)
==28831==    by 0x11651E: og_client_state_process_payload_rest (rest.c:3970)
==28831==    by 0x110CF3: og_client_read_cb (core.c:143)
==28831==    by 0x4E41D72: ev_invoke_pending (in /usr/lib/x86_64-linux-gnu/libev.so.4.0.0)
==28831==    by 0x4E453DD: ev_run (in /usr/lib/x86_64-linux-gnu/libev.so.4.0.0)
==28831==    by 0x10E3E5: ev_loop (ev.h:835)
==28831==    by 0x10E3E5: main (main.c:100)
==28831==  Address 0x0 is not stack'd, malloc'd or (recently) free'd

Use number of matching ip addresses in the database, skip if zero.
2021-03-30 13:58:31 +02:00
OpenGnSys Support Team ab32ed87c4 #1004 update size to 64-bits
Otherwise dbi_result_get_uint returns 0.
2021-03-19 16:58:50 +01:00
OpenGnSys Support Team f844a1b6bc #971 check for NULL serial number
ogclient might return an empty serial number.
2021-03-19 14:48:34 +01:00
Javier Sánchez Parra e6c2c26f09 #990 Use lab netmask to calculate broadcast address
ogServer gets netmask address from computer (ordenadores) table, see
commit a35b7c4. Netmask field is empty in most cases, is only filled
when the user adds computers with dhcpd.conf syntax and cannot be edited
in computer properties view.

Labs/rooms (aulas) table also have netmask field, WebConsole backend
ensures it is not empty and can be edited in lab properties view.

Get netmask from labs table to ensure it is not empty.
2021-03-17 19:50:40 +01:00
OpenGnSys Support Team 4bd409774c #990 incorrect inet_aton() error check
inet_aton() reports 0 on failure
2021-03-17 12:12:14 +01:00
Jose M. Guisado 41bc66d0e7 #997 Fix og_tm_hours_mask
Tests for e68fefe were made after 00pm (12:00) so we did not cover <12:00 cases
for immediate commands that are logged (scheduled for the exact moment
they are processed and ignored the fact they are stale so they are executed
right away)

In addition, libdbi was complaining about the data type used to
represent the hours, they were not being inserted properly. From syslog:

	failed to query database (og_dbi_schedule_create:3288) 1264: Out of
	range value for column 'horas' at row 1

Fix og_tm_hours_mask so <12:00 immediate schedule is handled correctly.
Change return type to uint16_t, as the 'hours' column type is smallint(4)

Fixes e68fefe ("#997 Set stale check flag when processing schedule/create")
2021-03-15 12:17:56 +01:00
Jose M. Guisado 8b7b5f33a1 #997 Use stale check flag in schedule/update
Commit e68fefe introduced 'check_stale' flag to better distinguish
real scheduled actions that do not execute if they are stale from
immediate actions that we want them to be logged in the action queue
(by creating a decoy schedule for the exact moment they are processed,
meaning that we ignore if the are stale).

Add this feature into schedule update too, in order to avoid executing
stale commands that were not meant to, ie. real scheduled commands.

Follows e68fefe ("Set stale check flag when processing schedule/create")
2021-03-15 12:17:56 +01:00
OpenGnSys Support Team e7e80cdde6 #942 return error if API REST parser fails
Return error if json parser fails, ignore unknown json attributes.
Missing uninitialized error value.
2021-03-15 12:17:56 +01:00
Jose M. Guisado 829f8d8ac9 #997 Remove unnecessary strdup in og_dbi_queue_*
After executing an scheduled command/proc/task valgrind reported
leaks inside og_dbi_queue_{command,procedure,task}. String
duplication is not being freed after using them.

==21281== 36 bytes in 1 blocks are definitely lost in loss record 470 of
592
...
==21281==    by 0x113DCB: og_dbi_queue_procedure (rest.c:2748)
==21281==    by 0x113F91: og_dbi_queue_task (rest.c:2804)
==21281==    by 0x114392: og_schedule_run (rest.c:2916)
==21281==    by 0x112059: og_agent_timer_cb (schedule.c:441)
...
==21281==    by 0x10E2A5: main (main.c:100)

These strdup are not necessary because the dbi result is not freed
before using them, it's safe to use the dbi result's reference to
this string.

Fix previous memleaks when executing scheduled commands, procedures
and tasks.
2021-03-11 14:39:07 +01:00
Jose M. Guisado e68fefeac7 #997 Set stale check flag when processing schedule/create
If you schedule a command in the past, the scheduler executes such
command immediately.

When expanding a schedule that result in commands that run weekly,
commands in the past are also executed, which is not expected.

Fix this by using the check_stale flag (formerly on_start) so
commands in the past that result from expansions are skipped.
2021-03-11 12:22:36 +01:00
Jose M. Guisado 76e6375720 #1004 Fix memleak in og_cmd_images
image_json object is created to store the json representation of
an image returned by the database. This object is going to be appended
to a json list that will compose the overall root json object.

Use json_array_append_new to let "images" steal the reference of
image_json so when further decref(root) there is no json reference
hanging around.
2021-02-24 14:33:22 +01:00
OpenGnSys Support Team 1c52b78e72 #942 memleak in og_send_request() 2021-02-23 12:35:53 +01:00
OpenGnSys Support Team 0d9d72eb42 #980 memleak in json ogclient path 2021-02-23 12:35:16 +01:00
OpenGnSys Support Team 9b708e0a7b #942 memleak in error path
Fix memleaks in error path.

json_decref() checks for null objects.
2021-02-23 12:32:57 +01:00
Jose M. Guisado a46b69b590 #990 Fix og_cmd_wol memory leak
Allocated strings using dbi_result_get_string_copy are not being freed
after using them. This patch fix this memory leak.

Fixes: e4cb91b ("#990 wol: migrate mac and netmask query to ogServer")
2021-02-23 10:49:12 +01:00
OpenGnSys Support Team 3b3405bc2f #1019 UAF in schedule run
Otherwise accessing IP address results in use-after-free.
2021-02-23 10:48:13 +01:00
Javier Sánchez Parra ed0d86b010 #1019 Fix queued Wake on LAN
UMA and UPV report that Wake on LAN command (in queue mode) does not
work.

We improved WoL command, now ogServer calculates the broadcast address
of the network to which the client belongs. To calculate this address
ogServer needs the IP and the netmask of the client. We updated ogServer
to retrieve the netmask from the database in non-queue mode, but we forgot
to add this in queue mode.

This patch adds netmask retrieving to queued WoL.
2021-02-22 11:05:34 +01:00
Jose M. Guisado e4cb91b5f6 #990 wol: migrate mac and netmask query to ogServer
ogServer WoL rest function is expecting ip, mac and netmask from the
request's payload. This makes the client responsible for providing such
data.

ogServer should be the owner of the database, this patch adjusts the
parameter expected in a request payload for /wol action so clients only
need to provide the ips and wol type (broadcast, unicast).

Database is expected to contain valid data for the netmask and mac of
target computers.
2021-02-15 16:26:21 +01:00
Jose M. Guisado 4d2e1dd31c #1004 Fix client setup disk size showing as 0
og_cmd_get_client_setup is querying the database for computers disk
setup information. This includes the size of a disk or a partition,
which are stored as BIGINT in the database.

Using dbi_result_get_int will result in an error as libdbi expects to
store this kind of data type in a long long instead of an int.

Fix disk size variable declaration and use the correct dbi_result_get
function for this particular data column.
2021-02-09 13:13:53 +01:00
Javier Sánchez Parra 6a7a846e6e #1019 Fix setup legacy string parser
UMA reports that the setup command (in queue mode) does not work.

WebConsole stores queued commands in the database using the deprecated
SocketHidra legacy string format and ogServer parses them with sscanf().
The setup command has a new field "ttp" since commit 0dd3edd, however,
the ogServer legacy parser was not updated to use this new field.

This patch adds legacy setup support to work with GPT tables. Add new field
table type to legacy setup that expects a string with "MSDOS" or "GPT".
2021-02-08 22:38:25 +01:00
Javier Sánchez Parra 0e4857a538 #1019 Fix restore-image legacy string parser
UMA reports that the restore image command (in queue mode) does not work,
the non-queue mode works fine though.

WebConsole stores queued commands in the database using the deprecated
SocketHidra legacy string format and ogServer parses them with sscanf().
The restore-image command has the field "ptc" which stores a string
with whitespaces, however, ogServer expects no whitespaces ("%s").

Update parser to read until carriage return, whitespaces included.
2021-02-08 22:36:29 +01:00
OpenGnSys Support Team f3905fe0f9 #1021 remove LOG_DEBUG syslog
Some distros enable *.* in syslog.conf to add all logging information
to /var/log/syslog. The existing LOG_DEBUG syslog() entries that ogserver
generates fill up the log files very quickly. Remove most of the LOG_DEBUG
syslog() calls.
2021-02-04 13:36:15 +01:00
OpenGnSys Support Team 0a09c5b09c #1022 increase maximum API REST request size
Software inventory generates a request larger that 64 Kbytes.
Rise the maximum API REST request size to 128 Kbytes.
2021-02-04 13:29:24 +01:00
Jose M. Guisado 85d092864c #802 add uefi folder for post_modes pxe template lookup
When executing og_cmd_post_modes ogServer is looking up for the template
related to the mode coming as a parameter. This lookup is only done for
the bios boot mode. (ie. /opt/opengnsys/tftpboot/menu.lst/templates/)

Templates can be created for a given boot mode, for example you can
create a UEFI-only template (it.
/opt/opengnsys/tftpboot/grub/templates).

When a UEFI only template was coming as a parameter to og_cmd_post_modes
the file can't be located because the UEFI template folder is never
tested.

Add UEFI folder to the lookup of pxe templates, try this folder if bios
mode fails.

PS: Later on a bash script "setclientmode" is to be executed, which will
take its own way of updating these pxe files (ie. templates/../), this
script updates every boot mode if an available template is found.
2021-01-13 09:58:22 +01:00
Javier Sánchez Parra 6d628dc1b2 #1010 Fix /software missing body in queued mode
ogServer do not send /software parameters to ogClient in queued mode.

Add parameters as JSON body.
2020-12-02 14:11:55 +01:00
Javier Sánchez Parra 8d914564c8 #1010 Adapt ogServer to send GET /software
ogClient changed /software from POST to GET.

Adapt ogServer to work with ogClient /software new method.
2020-12-02 14:11:49 +01:00
Diego Crespo Quinta aeb53bd351 #915 Test GET /scopes
And fix ogserver, report error if GET /scopes have a JSON body.
2020-12-01 19:29:37 +01:00
Javier Sánchez Parra 0dd3edd27c #1008 Add support to work with GPT tables
ogServer /setup do not support to indicate which table type the user
want to use. It always supposes that the partition table is MBR/MSDOS.

Add ogServer support to work with GPT tables. Add new field table type
to /setup that expects a string with "MSDOS" or "GPT".

Example old JSON:
{
  "clients": [...],
  "disk": "1",
  "cache": "0",
  "cache_size": "0",
  "partition_setup": [...]
}

Example new JSON:
{
  "clients": [...],
  "type": "GPT",
  "disk": "1",
  "cache": "0",
  "cache_size": "0",
  "partition_setup": [...]
}
2020-11-27 12:52:21 +01:00
Javier Sánchez Parra 24e6fbf1de #1008 Restore support for 4 disks and 16 partitions
ogServer expects to receive information of 1 disk and 4 partitions
from ogClient. Previous ogServer versions support several disks and
partitions.

Add ogServer support for 4 disks and 16 partitions.
2020-11-18 13:10:34 +01:00
Javier Sánchez Parra 4f5c357dcd #941 Fix get computer center id
Creating a software profile failed. ogServer obtained the information of
a computer without center id because commit cbd9421 removed it
unintentionally, making all computer had center id equal to zero.

This commit restores the gathering of computer center id from the
database.
2020-10-27 17:04:26 +01:00
Roberto Hueso Gómez 7f5ab4ac35 #942 Add GET /session REST API function
This function returns the installed and available OSs in a client to be
booted from.

Request:
GET /session
{
  "client": ["192.168.56.11"]
}

Response
200 OK
{
  "sessions": [
    {
      "disk": 1,
      "name": "Ubuntu 18.04.4 LTS",
      "partition": 1
    }
  ]
}
2020-10-20 15:34:15 +02:00
Roberto Hueso Gómez 2958d23db2 #942 Use client's IP as filter in GET /hardware
This patch uses client's IP instead of scope ID as a filter for the
request.

Request:
GET /hardware
{
  "client": ["192.168.56.11"]
}

Response:
200 OK
{
  "hardware": [
    {
      "description": "BIOS",
      "type": "Tipo de proceso de arranque"
    },
    {
      "description": "QEMU Standard PC (i440FX + PIIX, 1996)  v.pc-i440fx-5.1",
      "type": "Marca y modelo del equipo"
    },
    {
      "description": "Intel Corp. Intel Core Processor (Haswell, no TSX, IBRS) 2GHz v.pc-i440fx-5.1",
      "type": "Microprocesadores"
    },
    {
      "description": "QEMU  2049MiB  (DIMM 0)",
      "type": "Memorias"
    },
    {
      "description": "Red Hat, Inc. Virtio network device  v.00",
      "type": "Tarjetas de Red"
    }
  ]
}
2020-10-20 13:44:44 +02:00
Roberto Hueso Gómez 25c1c16e99 #942 Add GET /software REST API function
This function retrieves a list of the software installed in a specific
disk and partition of a client. This list can be updated by using POST
/software beforehand.

Request:
GET /software
{
  "client": ["192.168.56.11"],
  "disk": 1,
  "partition": 1
}

Response:
200 OK
{
  "software": [
    "grub-pc-bin 2",
    "grub-pc 2.02",
    "grub2-common 2.02",
    "groff-base 1.22.3",
    "gpg 2.2.4",
    "gnupg-utils 2.2.4",
    "gnupg-l10n 2.2.4",
    "gnupg 2.2.4",
    "gnome-video-effects 0.4.3",
    "gnome-user-guide 3.28.2+git20180715",
    "gnome-user-docs 3.28.2+git20180715",
    "gnome-todo-common 3.28.1",
    "gnome-mines 3.28.0",
    "gnome-menus 3.13.3",
    "gnome-mahjongg 3.22.0",
    "gnome-keyring-pkcs11 3.28.0.2",
    "gnome-keyring 3.28.0.2",
    "gnome-initial-setup 3.28.0",
    "accountsservice 0.6.45"
  ]
}
2020-10-16 14:40:33 +02:00
Roberto Hueso Gómez d8b78bb922 #942 Extend GET /images function
This extension removes replaces the field 'filename' for 'name' and adds
new fields (software_id, type and id). These new fields are useful when
restoring an image.

Request:
GET /images

Response:
200 OK
{
  "disk": {
    "free": 37091418112,
    "total": 52573995008
  },
  "images": [
    {
      "datasize": 5939200000,
      "id": 25,
      "modified": "Wed Oct 14 11:49:00 2020",
      "name": "archlinux",
      "permissions": "744",
      "size": 1844222333,
      "software_id": 19,
      "type": 1
    }
  ]
}
2020-10-14 17:31:43 +02:00
Roberto Hueso Gómez d2f20d0be0 #942 Create DB image when calling POST /image/create
In case the DB entry for an image does not exist when POST /image/create
is called, this patch takes care of calling it.

This adds few optional json parameters to the POST /image/create API. If
optional parameters are included then this patch creates the DB entry,
otherwise it just creates the actual image and updates the existing
entry.

Request:
POST /image/create
{
  "clients":["192.168.56.11"],
  "disk":"1",
  "partition":"1",
  "name":"archlinux",
  "repository":"192.168.56.10",
  "id":"24",
  "code":"131",
  "description":"This is a test",
  "group_id":0,
  "center_id":1
}
Response:
200 OK
2020-10-14 12:05:25 +02:00
Roberto Hueso Gómez 24c8b940e6 Add REST POST /client/delete method
This method deletes a client from the DB.

Request:
POST /client/delete
{
  "clients": ["192.168.56.30"]
}

Response:
200 OK

Co-authored-by: Javier Sánchez Parra <jsanchez@soleta.eu>
2020-10-08 12:56:32 +02:00
OpenGnSys Support Team 35f067bf90 #971 remove unused contieneIP function in ogAdmLib 2020-10-07 11:18:37 +02:00
OpenGnSys Support Team fe1ce97c50 #988 remove legacy configuration
Use og_server_cfg everywhere. Convert port to string to make it easy for the
dbi API since it expects a string. Remove legacy example configuration file.
2020-10-07 11:17:00 +02:00
OpenGnSys Support Team 3cea4bb763 #988 rename og_server_cfg to cfg
to avoid clash with existing variable cfg in client.c
2020-10-07 11:11:04 +02:00
Roberto Hueso Gómez f537dafa77 #941 Use fixed length strings in og_computer and og_dbi_get_computer_info
This patch is a refactor for og_computer and og_dbi_get_computer_info.
It now uses fixed lenght strings to make it more reliable and avoid
errors if the DB is not returning a null ended string.
2020-10-06 16:04:17 +02:00
Roberto Hueso Gómez 27fbc65829 #941 Add og_json_parse_string_copy(...) function
This function provides an easy way to copy the content of a json string
into a regular C string.
2020-10-06 16:04:14 +02:00
OpenGnSys Support Team d89d6c6ce7 #1004 set default path to repository
This is /opt/opengnsys/images if not specified.
2020-10-06 13:01:54 +02:00
OpenGnSys Support Team 7500700777 #988 remove legacy configuration file
Add getopt parser and use json configuration file instead.
2020-10-05 14:49:17 +02:00
Javier Sánchez Parra a67f27a092 #1004 Fix integer overflow in datasize
ogClient datasize is now in bytes, update format to fix a possible overflow.
2020-09-29 12:43:07 +02:00
Javier Sánchez Parra 403e7c323b #1004 Add GET /images
This commit adds GET /images to the ogServer REST API.

This call returns information of all the images in ogServer.

Example response:

{
  "images": [
    {
      "filename": "ubuntu.img",
      "datasize": 2150400000,
      "size": 613476223,
      "modified": "Wed Sep 23 10:37:36 2020",
      "permissions": "744"
    },
    {
      "filename": "test.img",
      "datasize": 2150400000,
      "size": 613236475,
      "modified": "Tue Sep 29 08:57:47 2020",
      "permissions": "744"
    }
  ],
  "disk": {
    "total": 52573995008,
    "free": 39624544256
  }
}
2020-09-29 12:43:07 +02:00
Javier Sánchez Parra f068a79c1a #988 Add global config variable
This commit makes configuration variable global.

To use this variable you have to #import "cfg.h".
2020-09-29 12:42:53 +02:00
Roberto Hueso Gómez 65a14e56d3 #942 Add POST /client/add HTTP REST method
This method adds a new client. This new client's IP cannot be duplicated
in the DB.

Request:
POST /client/add
{
  "boot": "19pxeADMIN",
  "center": 0,
  "hardware_id": 0,
  "id": 2,
  "ip": "192.168.56.12",
  "livedir": "ogLive",
  "mac": "0800270E6512",
  "maintenance": true,
  "name": "pc12",
  "netdriver": "generic",
  "netiface": "eth1",
  "netmask": "255.255.255.0",
  "remote": false,
  "repo_id": 1,
  "room": 1,
  "serial_number": ""
}

Response:
200 OK
2020-09-24 17:03:56 +02:00
OpenGnSys Support Team bdd8519d03 #988 use-after-free in json configuration parser
The cfg structure stores pointers to the string in this json tree. Do not
release the json tree, keep it as field in the cfg structure.
2020-09-22 15:24:43 +02:00
Roberto Hueso Gómez af47a082ad #1004 Add GET /client/info HTTP REST method
This method provides information about a specific client. The request
must contain exactly 1 client's IP.

Request:
GET /client/info
{"client": ["192.168.56.12"]}

Response:
200 OK
{
  "boot": "19pxeADMIN",
  "center": 0,
  "hardware_id": 0,
  "id": 2,
  "ip": "192.168.56.12",
  "livedir": "ogLive",
  "mac": "0800280E6871",
  "maintenance": true,
  "name": "pc12",
  "netdriver": "generic",
  "netiface": "eth1",
  "netmask": "255.255.255.0",
  "remote": false,
  "repo_id": 1,
  "room": 1,
  "serial_number": ""
}
2020-09-22 15:24:38 +02:00
Roberto Hueso Gómez cbd9421bae #941 Extend og_dbi_get_computer_info(...)
For the strings in og_computer we do not need to know the max size in
advance but instead we need to free up memmory using
og_dbi_free_computer_info(...) function.
2020-09-22 15:20:57 +02:00
OpenGnSys Support Team d7e2022bdd #941 pass og_dbi to og_dbi_get_computer_info()
Reuse the existing dbi handler, instead of opening a new one.
2020-09-18 15:38:16 +02:00
OpenGnSys Support Team 3cb98c7187 #941 move og_dbi_get_computer_info() to dbi
Move this function to the dbi.{h,c} files.
2020-09-18 15:34:30 +02:00
OpenGnSys Support Team 540cfb597f #988 fix compilation warning in json configuration file to legacy
src/cfg.c: In function ‘from_json_to_legacy’:
src/cfg.c:161:2: warning: format not a string literal and no format arguments [-Wformat-security]
2020-09-15 20:16:12 +02:00
Roberto Hueso Gómez ff71a2ad6e Fix size of og_cmd_get_client_setup() return array
The return array needs to store 1 extra element for the disk setup.
2020-09-15 15:00:17 +02:00
Roberto Hueso Gómez b59ff7c604 #1004 Add GET /client/setup HTTP REST method
This method provides the partitions setup for a specific client. The
request must contain exactly 1 client's IP.

Request:
GET /client/setup
{'client': ['192.168.56.12']}

Response:
200 OK
{
  "partitions": [
    {
      "disk": 1,
      "partition": 0,
      "code": 0,
      "size": 20971520,
      "used_size": 0,
      "filesystem": 0,
      "os": 0,
      "image": 0,
      "software": 0
    }
  ]
}
2020-09-14 12:13:06 +02:00
OpenGnSys Support Team 280e23f8ee #971 replace reservaMemoria() by calloc()
reservaMemoria() is only used once, remove it.
2020-09-10 16:24:18 +02:00
OpenGnSys Support Team 7dbe1a73a0 #971 remove unused functions in ogAdmLib
Remove unused legacy code.
2020-09-10 16:20:02 +02:00
Javier Sánchez Parra 0efc182c9b #1004 Handle new fields in /image/create response
ogClient now includes more information regarding the new image. This patch
modifies ogServer to support new elements sent in ogClient /image/create
response and store them in the database.

Example of new /image/create response:

{
  "disk": "1",
  "partition": "1",
  "code": "131",
  "id": "1",
  "name": "ubuntu",
  "repository": "192.168.56.10",
  "software": "Ubuntu 18.04.5 LTS \naccountsservice 0.6.45\n...",
  "clonator": "PARTCLONE",
  "compressor": "LZOP",
  "filesystem": "EXTFS",
  "datasize": 2100000
}

New fields are "clonator", "compressor", "filesystem" and "datasize".
2020-09-10 14:48:26 +02:00
OpenGnSys Support Team a1aaad46fb #980 do not report busy client if probing is pending
og_client_status() should not report busy when probing is going on.
2020-08-21 18:10:39 +02:00
Roberto Hueso Gómez 91c3a285ba #980 Add 'ip' field in GET /scopes request
The 'ip' field is added to the json for scopes that have an IP (i.e.
computers).
2020-08-14 12:55:18 +02:00
Roberto Hueso Gómez 4ae9903dc3 #980 Select POST /mode clients by ip instead of scope name
This patch selects clients whose modes need to be changed in the current
request. This patch makes POST /mode consistent with the rest of the
REST API where clients are selected and filtered by ip.
2020-08-14 12:50:24 +02:00
OpenGnSys Support Team ca545d39bd #998 disable incremental image API
This API is not supported by ogClient yet and it uses the obsolete socket hydra API.
2020-08-14 12:48:21 +02:00
OpenGnSys Support Team 060e31cb53 #990 add wol_socket_open()
Add wol_socket_open() to initialize the WoL socket
2020-08-06 13:39:46 +02:00
OpenGnSys Support Team 1855b68af3 #980 fix compile warning in og_set_client_mode
CC       src/rest.o
src/rest.c: In function ‘og_cmd_post_modes.isra.27’:
src/rest.c:966:4: warning: ‘%s’ directive output may be truncated writing up to 4096 bytes into a region of size between 3018 and 4041 -Wformat-truncation=]
    "MODE_FILE='%s'\nMAC='%s'\nDATA='%s'\n"
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/rest.c:1085:7:
       template_name, scope_name);
       ~~~~~~~~~~~~~
src/rest.c:967:33: note: format string is defined here
    "MODE='PERM'\nTEMPLATE_NAME='%s'",
                                 ^~
src/rest.c:965:2: note: ‘snprintf’ output 57 or more bytes (assuming 5176) into a destination of size 4096
  snprintf(cmd_params, sizeof(cmd_params),
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    "MODE_FILE='%s'\nMAC='%s'\nDATA='%s'\n"
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    "MODE='PERM'\nTEMPLATE_NAME='%s'",
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    mode, mac, params, template_name);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2020-08-06 10:45:03 +02:00
OpenGnSys Support Team 5286c93d69 #980 error reporting in setclientmode
Add syslog and use exit()
2020-08-06 10:36:44 +02:00
Irina Gomez 139633a334 #986 Fixs error in 'Advanced Netboot' caused by loss information from ogserver process owner (author Roberto Hueso Gómez). 2020-08-05 14:21:16 +02:00
Roberto Hueso Gómez b8a509b1dd #980 Change GET and POST /modes URI to /mode
This patch changes the URI since it is semantically more correct to use
the singular.
2020-08-03 13:14:44 +02:00
Roberto Hueso Gómez 532b0819c4 #980 Fix POST /modes to use 'setclientmode' script
Now POST /modes does not only write to the database, it also uses the
external bash script 'setclientmode' to generate configured PXE
templates for each machine.

NOTE: This fix requires that room and computer names are unique in the
OpenGnsys DB. This behaviour is inherited from the previous
'setclientmode' script but, eventually, it should be replaced for an
actual scope selector.
2020-07-29 20:17:34 +02:00
Roberto Hueso Gómez a8e5b844c5 #988 Check DB port size is in [0, UINT16_MAX]
Max port number is UINT16_MAX, so this checks whether this config
parameter is in the correct range.
2020-07-15 12:47:45 +02:00
Roberto Hueso Gómez 0631b0e8e6 #988 Add DB port option to ogserver.json config file
This patch provides functionality to select a database port. It also adds a
default IP for the database.
2020-07-10 16:21:58 +02:00
Roberto Hueso Gómez a8eccba706 Add GET /hardware REST request
This patch implements HTTP GET /hardware request which returns a list of
the hardware associated with a particular computer.

Request: GET /hardware
{
  "scope": {
    "id": 6,
    "type": "computer"
  }
}

Response: 200 OK
{
  "hardware": [
    {
      "type": "Microprocesadores",
      "description": "CPU arch:x86 target:x86_64 cores:4"
    },
    {
      "type": "Memorias",
      "description": "QEMU 4096MiB"
    },
    {
      "type": "Tarjetas gráficas",
      "description": "Red Hat, Inc Virtio GPU"
    },
    {
      "type": "Tarjetas de Red",
      "description": "Intel Corporation 82540EM Gigabit Ethernet Controller
                      QEMU Virtual Machine"
    },
    {
      "type": "Controladores IDE",
      "description": "Intel Corporation 82371SB PIIX3 IDE [Natoma/Triton II]
                      Qemu virtual machine"
    }
  ]
}
2020-07-08 17:08:46 +02:00
Roberto Hueso Gómez 33b0c6f694 Add POST /modes REST request
This patch implements HTTP POST /modes request which can change the mode of any
particular scope.

Request: POST /modes
{
  "scope": {"id": 1,
            "type": "computer"},
  "mode": "pxe"
}
Response: 200 OK
2020-07-06 17:27:33 +02:00
OpenGnSys Support Team 96b02b5424 #971 split wake on lan code
Add wol.c and wol.h that implements WakeOnLan.
2020-07-06 11:14:43 +02:00
Javier Sánchez Parra 06af0c26f4 #990 Use client broadcast address on WoL
Some universities have computers in a different subnet where the
ogServer is, but ogServer WoL functionality only supported to send
packet to its own subnets. This commit solves this.

Now ogServer sends two WoL packets per client, one with the broadcast
address of the interface indicated in the config file, the other with
the broadcast address calculated with the address and netmask of the
client.

To ensure that the second WoL works correctly you must configure
correctly the IP and netmask of the clients. Also, you have to configure
the network of your organization to route WoL packet to the correct
subnet.
2020-07-03 14:11:35 +02:00
OpenGnSys Support Team d6789f1384 #971 linkage error after split
/usr/bin/ld: src/cfg.o:/home/opengnsys/ogServer/src/ogAdmServer.h:25: multiple definition of `servidoradm'; src/ogAdmServer.o:/home/javi/trabajo/soleta/opengnsys/ogServer/src/ogAdmServer.h:25: first defined here
/usr/bin/ld: src/cfg.o:/home/opengnsys/ogServer/src/ogAdmServer.h:26: multiple definition of `puerto'; src/ogAdmServer.o:/home/javi/trabajo/soleta/opengnsys/ogServer/src/ogAdmServer.h:26: first defined here
/usr/bin/ld: src/cfg.o:/home/opengnsys/ogServer/src/ogAdmServer.h:35: multiple definition of `tbsockets'; src/ogAdmServer.o:/home/javi/trabajo/soleta/opengnsys/ogServer/src/ogAdmServer.h:35: first defined here
/usr/bin/ld: src/cfg.o:/home/opengnsys/ogServer/src/ogAdmLib.h:81: multiple definition of `ndebug'; src/ogAdmServer.o:/home/javi/trabajo/soleta/opengnsys/ogServer/src/ogAdmLib.h:81: first defined here
/usr/bin/ld: src/cfg.o:/home/opengnsys/ogServer/src/ogAdmLib.h:80: multiple definition of `szPathFileLog'; src/ogAdmServer.o:/home/javi/trabajo/soleta/opengnsys/ogServer/src/ogAdmLib.h:80: first defined here
/usr/bin/ld: src/cfg.o:/home/opengnsys/ogServer/src/ogAdmLib.h:80: multiple definition of `szPathFileCfg'; src/ogAdmServer.o:/home/javi/trabajo/soleta/opengnsys/ogServer/src/ogAdmLib.h:80: first defined here
2020-07-02 12:34:38 +02:00
Roberto Hueso Gómez f520a57f58 #980 Refactor GET /scopes backend
This improves style and fixes some memleaks.

Co-authored-by: OpenGnSys Support Team <soporte-og@soleta.eu>
2020-07-02 12:14:19 +02:00
OpenGnSys Support Team e54c5ca411 #980 Fix memleak in og_cmd_get_modes()
Missing closedir() call.
2020-06-30 19:40:12 +02:00
Roberto Hueso Gómez 76c0a05f28 #980 Fix memleak in og_cmd_scope_get
If either root or children_root fail to be created but the other one does not,
then reserved memory for the successful one would not be freed.
2020-06-30 16:50:11 +02:00
Roberto Hueso Gómez 608709f620 #980 Add GET /modes REST request
This patch implements HTTP GET /modes request which returns all modes available
for clients:

Request: GET /modes HTTP/1.0
Response: 200 OK
{
  "modes": [
    "pxe",
    "10",
    "13",
    "00unknown",
    "11",
    "19pxeADMIN",
    "12"
  ]
}
2020-06-30 16:49:11 +02:00
OpenGnSys Support Team 37e91b2ebb #971 rename sources folder to src
Use the same folder as in ogClient.
2020-06-26 20:13:42 +02:00