48k.eu-mirror
/
ogserver
mirror of https://git.48k.eu/ogserver
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#1019 UAF in schedule run 

Otherwise accessing IP address results in use-after-free.
master
OpenGnSys Support Team 2021-02-23 10:47:21 +01:00
parent 031e5708d3
commit 3b3405bc2f
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/rest.c
View File

@ -2924,7 +2924,7 @@ void og_schedule_run(unsigned int task_id, unsigned int schedule_id,
}
if (!duplicated)
params.ips_array[params.ips_array_len++] = cmd->ip;
params.ips_array[params.ips_array_len++] = strdup(cmd->ip);
else
duplicated = false;
}
@ -2945,6 +2945,9 @@ void og_schedule_run(unsigned int task_id, unsigned int schedule_id,
}
og_send_request(OG_METHOD_GET, OG_CMD_RUN_SCHEDULE, &params, NULL);
for (i = 0; i < params.ips_array_len; i++)
free((void *)params.ips_array[i]);
}
static int og_cmd_task_post(json_t *element, struct og_msg_params *params)