48k.eu-mirror
/
ogserver
mirror of https://git.48k.eu/ogserver
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rest: validate mac in client/update 

Check if the requested new MAC exists in another client and refuse
update request if that's the case.
master
Alejandro Sirgo Rica 2024-06-10 10:24:43 +02:00
parent c4d71193a5
commit cdc339659f
1 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/rest.c
View File

@ -1905,8 +1905,8 @@ static int og_cmd_post_client_update(json_t *element,
struct og_msg_params *params, struct og_msg_params *params,
char *buffer_reply) char *buffer_reply)
{ {
const char *key, *msglog, *client_ip;
struct og_computer computer = {}; struct og_computer computer = {};
const char *key, *msglog;
struct og_dbi *dbi; struct og_dbi *dbi;
dbi_result result; dbi_result result;
json_t *value; json_t *value;
@ -1989,6 +1989,27 @@ static int og_cmd_post_client_update(json_t *element,
dbi_result_free(result); dbi_result_free(result);
result = dbi_conn_queryf(dbi->conn,
"SELECT ip FROM ordenadores WHERE ip<>'%s' AND mac='%s'",
computer.ip, computer.mac);
if (!result) {
dbi_conn_error(dbi->conn, &msglog);
syslog(LOG_ERR, "failed to query database (%s:%d) %s\n",
__func__, __LINE__, msglog);
og_dbi_close(dbi);
return -1;
}
if (dbi_result_next_row(result)) {
client_ip = dbi_result_get_string(result, "ip");
syslog(LOG_ERR, "client with MAC %s already exist in %s\n",
computer.mac, client_ip);
dbi_result_free(result);
og_dbi_close(dbi);
return -1;
}
dbi_result_free(result);
result = dbi_conn_queryf(dbi->conn, result = dbi_conn_queryf(dbi->conn,
"UPDATE ordenadores" "UPDATE ordenadores"
" SET numserie='%s'," " SET numserie='%s',"