48k.eu-mirror
/
ogserver
mirror of https://git.48k.eu/ogserver
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rest: Check no client owns provided mac address 

Reply with an error if user tries to create a client with a mac that is
already owned by another client

Write to syslog info about the client that owns the mac: client's name,
ip, mac address and room
master v1.2.5-9
Javier Hernandez 2024-01-16 11:37:10 +01:00 committed by OpenGnSys Support Team
parent 149d1af21a
commit 128bba364a
1 changed files with 29 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/rest.c
View File

@ -2116,6 +2116,7 @@ static int og_cmd_post_client_add(json_t *element,
struct og_msg_params *params, struct og_msg_params *params,
char *buffer_reply) char *buffer_reply)
{ {
const char *room_name, *computer_name, *computer_ip, *hwaddr;
struct og_computer computer = {}; struct og_computer computer = {};
const char *key, *msglog; const char *key, *msglog;
struct og_dbi *dbi; struct og_dbi *dbi;
@ -2209,6 +2210,34 @@ static int og_cmd_post_client_add(json_t *element,
} }
dbi_result_free(result); dbi_result_free(result);
result = dbi_conn_queryf(dbi->conn,
"SELECT nombreordenador, ip, nombreaula"
" FROM ordenadores"
" INNER JOIN aulas on ordenadores.idaula = aulas.idaula"
" WHERE mac='%s'",
computer.mac);
if (!result) {
dbi_conn_error(dbi->conn, &msglog);
syslog(LOG_ERR, "failed to query database (%s:%d) %s\n",
__func__, __LINE__, msglog);
og_dbi_close(dbi);
return -1;
}
if (dbi_result_next_row(result)) {
room_name = dbi_result_get_string(result, "nombreaula");
computer_name = dbi_result_get_string(result, "nombreordenador");
computer_ip = dbi_result_get_string(result, "ip");
hwaddr = dbi_result_get_string(result, "mac");
syslog(LOG_ERR, "Failed to add client %s because %s (%s) in room %s already owns MAC address %s\n",
computer.ip, computer_ip, computer_name, room_name, hwaddr);
dbi_result_free(result);
og_dbi_close(dbi);
return -1;
}
dbi_result_free(result);
result = dbi_conn_queryf(dbi->conn, result = dbi_conn_queryf(dbi->conn,
"INSERT INTO ordenadores(" "INSERT INTO ordenadores("
" nombreordenador," " nombreordenador,"