Commit Graph

458 Commits (5cbb4a7562d126dd8eaa0a304f95274edf074582)
 

Author SHA1 Message Date
Alejandro Sirgo Rica 5cbb4a7562 views: skip cache space checks if already contains the image
Skip checks of image_fits_in_cache() if the image data contains
not 'size' or 'checksum' information.

Skip checks for the clients with the image already in cache.
2024-07-09 09:52:21 +02:00
Alejandro Sirgo Rica a88e5fed7d ogcp: select images of selected partition in image/update
Select the image field value containing the restored image of the
partition selected by the user.

Create a dictionary where the key is the value= of the partition
field and the value is the id of the image restored in the
partition. Add each dictionary entry only only if the corresponding
image exists in the repository.
Pass the dictionary to the HTML template and convert it to JS.
2024-07-09 09:52:21 +02:00
Alejandro Sirgo Rica f85f0771cd ogcp: show an indicator in each sidebar branch with live children
Add visual indicator to the disclosure widget when its branch has
any clients in live mode.
Ease the search of systems in ogLive in need of being booted or
turned off.

Add id= to the HTML component containing the disclosure widget.
Set the id to the value scope_type-scope_name for type='server' and
scope_type-scope_id for the rest.

Add the CSS class 'live-report' to the HTML components with live
children. Assign the class field in the js function updateScopes.
2024-07-09 09:52:21 +02:00
Alejandro Sirgo Rica d582beef47 ogcp: fix client pill status report
Prevent cases where the client pills would stay locked reporting a
specific system.

Remove pill-* classes instead of text-* classes in function
updatePillStatus().

This fixes out-of-sync state representation between sidebar and main
section.
2024-07-09 09:52:21 +02:00
Alejandro Sirgo Rica bb59eb8a54 views: add auxiliar function is_valid_ip()
Move ip validation logic to a separate function to make the code
more expressive and reusable.
2024-07-09 09:52:21 +02:00
Alejandro Sirgo Rica e532e9a0c8 ogcp: make client name field mandatory in client form
Add InputRequired validator to the name field of the
ClientDetailsForm.
Validate name value in the POST function.
2024-07-09 09:52:21 +02:00
Alejandro Sirgo Rica 5111733b93 ogcp: use csv as new format for import clients
Replace dhcpd format with the simpler csv format to configure
the list of clients to import in /action/clients/import.
Replace regex parsing with a simpler manual parsing.
Improve error report.

Example configuration:
client_name1,94:c6:91:a6:25:1a,10.141.10.100
client_name2,94:c6:91:a6:25:1b,10.141.10.101
2024-07-09 09:52:07 +02:00
Alejandro Sirgo Rica c333b3ee56 views: check invalid values in prettify_mac()
Return without modification if the MAC is not valid.
2024-07-04 13:06:01 +02:00
Alejandro Sirgo Rica 320df7ec0c views: validate MAC address after POST
Check if the provided MAC address is valid in every form where
the use has to provide one. Show an error message when the format
is incorrect.
2024-07-03 15:51:31 +02:00
Alejandro Sirgo Rica b510d625b2 views: show MAC as lowercase with colon separators
Define a function to format the MAC string for every view in the
web. Example of formatted MAC address: aa:bb:cc:dd:ee:aa

Show MAC address in client pills in that same format.
2024-07-03 15:48:24 +02:00
Alejandro Sirgo Rica 9ea8a74c63 views: normalize every MAC address during POST processing
Use aabbccddeeaa as MAC format in every payload.

List of accepted MAC formats:
aabbccddeeaa
aa:bb:cc:dd:ee:aa
aa-bb-cc-dd-ee-aa
aa.bb.cc.dd.ee.aa
2024-07-03 14:25:34 +02:00
Alejandro Sirgo Rica 84365a0db2 templates: fix commands button layout
Fix <div> structure to enable proper flow layout when the web
size changes and the command buttons need to reposition.
2024-07-03 12:52:09 +02:00
Alejandro Sirgo Rica 14d6784958 templates: preserve formatting in script output
Use <pre> instead of <samp> to display command output, as <pre>
preserves the new lines and the format of its inner text.
2024-07-01 09:29:41 +02:00
Alejandro Sirgo Rica dbc610c40a views: remove debug messages with payload info
Remove print statements in views.py to reduce logging noise.
2024-07-01 09:28:04 +02:00
Alejandro Sirgo Rica 31d6065a85 ogcp: set default SameSite attribute in session cookie
Set the SameSite attribute to 'Lax' if not defined.

The SameSite attribute is a cross-site tracking prevention measure
and defines when cookies are sent within the HTTP headers and
the cases when they are not sent.

The 'Lax' configuration has the following features:
- Cookies are sent with same domain requests.
- Cookies are sent when the user navigates to your site by clicking
  a link or submitting a form from another site.
- Not sent with requests made from other sites such as embeded content.

Prevent warning from browsers such as Firefox from complaining
about undefined SameSite value.
2024-06-28 08:43:34 +02:00
Alejandro Sirgo Rica 57b78a03bd templates: improve client list in cache and boot os views
Show client IPs inside div components with a custom "card" styling.
2024-06-28 08:43:34 +02:00
Alejandro Sirgo Rica f473059902 forms: replace Ok with Submit in form submit button
Make the submit label more uniform across the forms.
2024-06-28 08:43:34 +02:00
Alejandro Sirgo Rica 5fba469f7a templates: replace start session with boot OS
Update the header in the BootOS view to better fit the purpose
of the operation.
2024-06-28 08:43:34 +02:00
Alejandro Sirgo Rica 0c0df4288e templates: add vertical padding to the no cache message
Add vertical padding to the div holding the report of no selected
client with cached images.
2024-06-28 08:43:34 +02:00
Alejandro Sirgo Rica 3c8d13b696 templates: improve spacing in main dashboard
Use a plain line break instead of a horizontal rule to split the
server information.
2024-06-28 08:43:34 +02:00
Alejandro Sirgo Rica 9107316e0e templates: hide detailed cache view with zero images
Hide the cache inspector when no cache elements are found in
neither of the selected clients.
Fix js exception caused by an array access in an empty image list.
2024-06-28 08:43:22 +02:00
Alejandro Sirgo Rica a8af19fa23 templates: fix no image message in manage cache view
The template conditional must show the table when form.images has
more than zero elements.
2024-06-28 08:43:20 +02:00
Alejandro Sirgo Rica e91fc78a6d templates: improve user sidebar style
Use Bootstrap list-group class and adjust content alignment with
a flex container.
2024-06-28 08:43:20 +02:00
Alejandro Sirgo Rica 35a55f16de views: add check for failed /center/info get request
Check if the request response is null and report it to the user.
2024-06-28 08:43:20 +02:00
Alejandro Sirgo Rica 50dbc81706 views: notify user edit and user creation
Show a flash message when an user is created or edited successfully.
2024-06-28 08:43:20 +02:00
Alejandro Sirgo Rica 7d3567919a views: fix English grammatical error in error message
Replace "do not exists" with "does not exist" in error messages.
2024-06-28 08:42:53 +02:00
Alejandro Sirgo Rica 20bdd4175e templates: fix user form alignment
Add class="mx-5" to allign the form with the header of the page.
2024-06-27 10:25:11 +02:00
Alejandro Sirgo Rica 5ad2d2e72c ogcp: improve page heading style
Make headings take less space and have a dashed line under them.
2024-06-27 10:14:23 +02:00
Alejandro Sirgo Rica 977b457d5c ogcp: add user permission mechanism
Add a new user permission system to control the allowed operations
accessible from each account.

Add a permission matrix editable through the user/add and user/edit
views. The permission matrix has client, center, room, folder, image
and repository as permission targets and add, update and delete as
permission types.

Restrict each view based on the user permissions, hide all actions
from not autheticated users.

permissions defined in the class UserForm.

Serialize each user permissions into ogcp.json as:
{
  ...
  "USERS" [
    {
      "USER": "admin"
      ...
      "PERMISSIONS": {
        "CLIENT": {
          "ADD": true,
          "UPDATE": true,
          "DELETE": true,
        },
        ... <- same structure for "CENTER", "ROOM", "FOLDER", "IMAGE"
               and "REPOSITORY"
      }
    },
    ...
  ],
  ...
}

Grant all the permissions to old user configuration to not disrupt their
workflow. The administrator will need to assign the permissions for each
user.

Ignore scope and permission restrictions for admin users.

Save permissions and scopes even if the user is admin to account for the
case of a temporal admin promotion without losing the previous
configuration.

Use template inheritance for add_user.html and edit_user.html to prevent
big code duplication with the new HTML code to render the permission
matrix.

Make user administration an admin only feature.

Define methods get_permission and target_is_disabled to improve readability
in template conditionals that disable features based on user permissions.
2024-06-27 10:03:14 +02:00
Alejandro Sirgo Rica 25bb1ff73b templates: rename Edit client to Update client
Rename Client/Edit client menu in scopes management view to keep
the same naming pattern as the other menu elements.
2024-06-25 13:53:04 +02:00
Alejandro Sirgo Rica 0ed9ecdae9 ogcp: add support to view script output
Add view at /action/script/output to visualize the result of
/shell/run for multiple clients.

Use shell/output to request the execution data of the selected clients.

Each client element has execution timestamip (UTC), client ip, cmd,
return code and stdout of the executed command.
2024-06-25 13:53:04 +02:00
Alejandro Sirgo Rica af8236b189 ogcp: add support to run scripts in clients
Add view at /action/script/run to visualize the available scripts
and run a single script file in the selected clients.

Use shell/list to request the script list and shell/run API call
to request the execution.
2024-06-25 13:53:04 +02:00
Alejandro Sirgo Rica 8bcd8fd7a4 templates: make opengnsys buttom redirect to dashboard
Add functionality to the "Opengnsys" text in the top navbar.
Comform to the general design priciple of executing a redirecting
after clicking the main logo.
2024-06-25 13:53:04 +02:00
Alejandro Sirgo Rica 6a793ef0d1 views: remove unsupported partition types from image operations
Prevent unexpected behaviour in image operations caused by user
error.

Remove partitions of type 'EMPTY', 'LINUX-SWAP', 'CACHE' and  'EFI'
from the image/create, image/restore and image/update forms.

Remove check for the existence of these partitions in
action_image_restore as they are no longer available in the form.
2024-06-25 13:52:10 +02:00
Alejandro Sirgo Rica d46badaf82 templates: rename Start session to Boot OS
Use a better name for the form action used to boot an operating
system in the clients.
2024-06-20 14:59:24 +02:00
Alejandro Sirgo Rica 992d3b847a templates: show client details at the end of the client options
Move "Client details" to the last option of the "Client" dropdown
in the Commands page.
2024-06-20 14:57:32 +02:00
Alejandro Sirgo Rica 29cc4d9280 views: prevent user removal after password mismatch in user/edit
If password and confirm password fields mismatch in user/edit,
then the user is deleted.

The deletion of the user happens before the password validation
and the new user configuration is only saved if the validation
passes.

Add code to properly handle the user deletion after the validation.
2024-06-19 13:19:55 +02:00
Alejandro Sirgo Rica ee42cbd323 views: make password optional in user/edit
Add the option to leave the password fields empty in the form.
When the passwords are not set the user keeps the old password
configuration.
Define a EditUserForm based on UserForm in forms/auth.py to remove
the InputRequired validator in the password fields.
Update the html template to make the password fields optional.
2024-06-19 11:53:56 +02:00
Alejandro Sirgo Rica 2ae6f37e60 views: improve cache check messages in image/restore
Improve the wording of the error message reporting the clients
without enough cache to hold the image to be restored.
2024-06-19 10:55:23 +02:00
Alejandro Sirgo Rica 521b7c81ac views: check if the image fits in cache before image/restore
Check if the image to be restored fits in the client's cache to
provide a better feedback for a failed restore operation.
Report the needed free space in clients where it does not fit.
Only check if the reported image size is not 0, older images
may not define the "size" attribute.
Ignore the check if the restore type is UNICAST-DIRECT.
2024-06-18 16:08:24 +02:00
Alejandro Sirgo Rica 3c4b917280 views: ignore image datasize check if datasize is zero
Check the restored image fits in the target partition only if
the datasize value is not zero. Proceed with the check before
the image/restore request otherwise.
2024-06-18 12:43:46 +02:00
Alejandro Sirgo Rica e9a9ec467e templates: remove servers view in main navbar
Remove the Servers button from the main navbar but keep the
multiserver related code.
2024-06-18 10:56:45 +02:00
Alejandro Sirgo Rica f8969b3d5e css: offset the sidebar to acommodate all disclosure widgets
Add a left padding to show the disclosure widget associated to
a server item. Prevent the positioning of out of screen components.
2024-06-18 10:38:20 +02:00
Alejandro Sirgo Rica 48bc51ca0a js: show correct initial disclosure widget state
Add the class "collapsed" to the html elements defined as
not shown in the local storage for the images list sidebar.
2024-06-17 17:44:24 +02:00
Alejandro Sirgo Rica a7423d2943 ogcp: add room details view to scopes management
Add a readonly view for the room data.
Mark all the form fields as readonly and set the hidden attribute
to the submit field.
2024-06-17 17:10:05 +02:00
Alejandro Sirgo Rica d135a4806d ogcp: add center details view to scopes management
Add a readonly view for the center data.
Mark all the form fields as readonly and set the hidden attribute
to the submit field.
2024-06-17 17:06:01 +02:00
Alejandro Sirgo Rica 74c55987ef views: fix image restore cache checks
Fix the scope of the has_cache variable to reset the value for
each client.
Check the partition type based on the PART_TYPE_CODES string version
instead of the numerical value of the partition type.
2024-06-17 14:09:49 +02:00
Alejandro Sirgo Rica 4a74de1064 ogcp: add move client to scopes management
Add front end for the client/move REST API.
Enable the move of multiple clients selected from the sidebar of
Scopes Management.
Show the target of the move operation as a list of paths in a
dropdown widget in the form. Each path will be structured as:
Server/Center/Room
The path will also contain folders if they are present.
2024-06-17 14:03:00 +02:00
Alejandro Sirgo Rica 664ad2bf7b templates: remove console.log statement in mode.html
Remove print statement generating noise in the browser logs
2024-06-17 10:03:44 +02:00
Alejandro Sirgo Rica a637a958b0 templates: show oglive in client pills
Add oglive to each client pill in action/oglive using js.
This makes easier to have a global perspective of the client's
configuration.
2024-06-17 09:35:05 +02:00