valgrind reports incorrect access to memory:
==16622== 4000 errors in context 1 of 2:
==16622== Conditional jump or move depends on uninitialised value(s)
==16622== at 0x10C380: contieneIP (ogAdmLib.c:514)
==16622== by 0x10D842: clienteExistente (ogAdmServer.c:206)
==16622== by 0x10D743: clienteDisponible (ogAdmServer.c:173)
==16622== by 0x10FE62: og_send_cmd (ogAdmServer.c:1106)
==16622== by 0x114651: og_cmd_legacy_send (ogAdmServer.c:3159)
==16622== by 0x114795: og_cmd_post_clients (ogAdmServer.c:3188)
==16622== by 0x1193F5: og_client_state_process_payload_rest (ogAdmServer.c:4444)
==16622== by 0x11A354: og_client_read_cb (ogAdmServer.c:4728)
==16622== by 0x693ED72: ev_invoke_pending (in /usr/lib/x86_64-linux-gnu/libev.so.4.0.0)
==16622== by 0x69423DD: ev_run (in /usr/lib/x86_64-linux-gnu/libev.so.4.0.0)
==16622== by 0x10D19C: ev_loop (ev.h:835)
==16622== by 0x11AAED: main (ogAdmServer.c:4896)
==16622== Uninitialised value was created by a heap allocation
==16622== at 0x4C2FB0F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==16622== by 0x6B4D80A: ??? (in /usr/lib/x86_64-linux-gnu/libjansson.so.4.11.0)
==16622== by 0x6B4DDCB: ??? (in /usr/lib/x86_64-linux-gnu/libjansson.so.4.11.0)
==16622== by 0x6B4DCA6: ??? (in /usr/lib/x86_64-linux-gnu/libjansson.so.4.11.0)
==16622== by 0x6B4DF55: ??? (in /usr/lib/x86_64-linux-gnu/libjansson.so.4.11.0)
==16622== by 0x6B4E0CB: json_loads (in /usr/lib/x86_64-linux-gnu/libjansson.so.4.11.0)
==16622== by 0x1192F2: og_client_state_process_payload_rest (ogAdmServer.c:4425)
==16622== by 0x11A354: og_client_read_cb (ogAdmServer.c:4728)
==16622== by 0x693ED72: ev_invoke_pending (in /usr/lib/x86_64-linux-gnu/libev.so.4.0.0)
==16622== by 0x69423DD: ev_run (in /usr/lib/x86_64-linux-gnu/libev.so.4.0.0)
==16622== by 0x10D19C: ev_loop (ev.h:835)
==16622== by 0x11AAED: main (ogAdmServer.c:4896)
This commit removes the opengnsys cron script that checks if the
ogAdmServer is running or using too much CPU and restarts the process.
Now that the ogAdmServer is more stable this script is not needed. Also,
without this script we are going to know better when the ogAdmServer is
having a problem and get better reports.
In case you observe a crash in ogAdmServer, please, run it under valgrind:
valgrind --leak-check=full --show-leak-kinds=all --track-origins=yes --verbose --log-file=/tmp/ogadmserver-valgrind-out.log /opt/opengnsys/sbin/ogAdmServer -f /opt/opengnsys/etc/ogAdmServer.cfg
And post your 'ogadmserver-valgrind-out.log' file to the mailing list.
This patch changes the installer and the update scripts too. They do
not configure opengnsys.cron anymore. The update script search and
remove the deprecated files as well.
If the payload is too long, then the API returns a 413 status code
(following RFC 7231) instead of the resetting the communication without
replying. This way it should be more clear when this problem is
happening.
The other commit I did related to the issue of the payload size
(1d9d93c) said that ogAdmServer do not log anything when it receives a
payload of a bigger size than supported, this is false. ogAdmServer
prints the next message to the syslog when this happens:
ogAdmServer[6824]: client request from 127.0.0.1:43552 is too long
This fixes commit 930563c: the installation script tries to change
MySQL root password without previously starting MySQL.
This commit restores the code that enables and restart MySQL to its
previous position, before changing the password, and adds a new restart
MySQL command.
This commit sets the MySQL enconding to UTF8. This way we can avoid
problems with special characters in strings, like: ó.
It also changes the installation script to always copy the MySQL
configuration template and restart MySQL. So, even if the server had
MySQL installed before the OpenGnsys installation, the script
configures MySQL.
Example error that this commit should fix:
ogAdmServer[12524]: failed to query database
(actualizaSoftware:2380) 1366: Incorrect string value:
'\xF3n de ...' for column 'descripcion' at row 1
The encoding configuration before this commit should be like this:
mysql> SHOW VARIABLES LIKE 'char%';
+--------------------------+----------------------------+
| Variable_name | Value |
+--------------------------+----------------------------+
| character_set_client | utf8 |
| character_set_connection | utf8 |
| character_set_database | latin1 |
| character_set_filesystem | binary |
| character_set_results | utf8 |
| character_set_server | latin1 |
| character_set_system | utf8 |
| character_sets_dir | /usr/share/mysql/charsets/ |
+--------------------------+----------------------------+
8 rows in set (0.10 sec)
The encoding configuration after this commit should be like this:
mysql> SHOW VARIABLES LIKE 'char%';
+--------------------------+----------------------------+
| Variable_name | Value |
+--------------------------+----------------------------+
| character_set_client | utf8 |
| character_set_connection | utf8 |
| character_set_database | utf8 |
| character_set_filesystem | binary |
| character_set_results | utf8 |
| character_set_server | utf8 |
| character_set_system | utf8 |
| character_sets_dir | /usr/share/mysql/charsets/ |
+--------------------------+----------------------------+
8 rows in set (0.01 sec)
This commits adds the binary of libdbi and the drivers to work with
MySQL. A previous commit (1479f77) added the headers for the
compilation, libdbi-dev.
And update all callers.
Some of the db.Open() calls cannot be removed yet, since there are still
more function dependencies that need to be converted too.
Ramón M. Gómez
Irina Gomez
OpenGnSys Support Team
Javier Sánchez Parra
irinagomez
Roberto Hueso Gómez