Better error handling for bad tag names
parent
ee300b846b
commit
6887e68b22
|
@ -2798,7 +2798,17 @@ def git_create_tag(repo):
|
|||
journal.send(f"Can't create tag. Already found in repository {repo}", PRIORITY=journal.LOG_ERR, SYSLOG_IDENTIFIER="ogrepo-api_DEBUG")
|
||||
return jsonify({"error": "Tag already exists"}), 409
|
||||
|
||||
git_repo.create_tag(tag, ref = data["commit"], message = commit_message)
|
||||
try:
|
||||
git_repo.create_tag(tag, ref = data["commit"], message = commit_message)
|
||||
except git.exc.GitCommandError as ge:
|
||||
if "not a valid tag name" in ge.stderr:
|
||||
journal.send(f"Tag name {tag} is invalid", PRIORITY=journal.LOG_ERR, SYSLOG_IDENTIFIER="ogrepo-api_DEBUG")
|
||||
return jsonify({"error" : "Invalid tag name"}), 400
|
||||
else:
|
||||
journal.send(f"Git error {ge}", PRIORITY=journal.LOG_ERR, SYSLOG_IDENTIFIER="ogrepo-api_DEBUG")
|
||||
return jsonify({"error" : "Error when performing git command"}), 500
|
||||
|
||||
|
||||
|
||||
journal.send(f"Tag {tag} created in repo {repo}", PRIORITY=journal.LOG_ERR, SYSLOG_IDENTIFIER="ogrepo-api_DEBUG")
|
||||
return jsonify({"status": "created"}), 200
|
||||
|
|
Loading…
Reference in New Issue