From ddecae613f2e69ecd810c5b88a52ab83de540b41 Mon Sep 17 00:00:00 2001 From: jmbardallo Date: Thu, 17 Sep 2026 15:00:01 +0200 Subject: [PATCH] fix(menu): replace base tag logic with direct regex rewriting of assets URLs to bypass leading slash limitations --- src/Controller/MenuBrowserController.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Controller/MenuBrowserController.php b/src/Controller/MenuBrowserController.php index e8d7f7a..57c99a8 100644 --- a/src/Controller/MenuBrowserController.php +++ b/src/Controller/MenuBrowserController.php @@ -92,8 +92,9 @@ class MenuBrowserController extends AbstractController ]); if ($request->query->get('gui')) { - // Using ../ as base href makes relative assets resolve to the parent directory (e.g., /api/) - $html = preg_replace('//i', "", $html); + $base = rtrim($request->getSchemeAndHttpHost() . $request->getBasePath(), '/'); + // Rewrite both assets/ and /assets/ to the absolute API URL + $html = preg_replace('#([\'"(])/?assets/#i', '$1' . $base . '/assets/', $html); } return new Response($html); @@ -135,10 +136,9 @@ class MenuBrowserController extends AbstractController 'mac' => '00:00:00:00:00:00', 'disks' => [], ]); - // Inject an absolute base href so the data: URL resolves assets correctly against the API path. - $base = $data['baseUrl'] ?? ($request->getSchemeAndHttpHost() . $request->getBasePath()); - $base = rtrim($base, '/') . '/'; - $rendered = preg_replace('//i', "", $rendered); + // Rewrite both assets/ and /assets/ to the absolute API URL + $base = rtrim($data['baseUrl'] ?? ($request->getSchemeAndHttpHost() . $request->getBasePath()), '/'); + $rendered = preg_replace('#([\'"(])/?assets/#i', '$1' . $base . '/assets/', $rendered); return new Response($rendered, Response::HTTP_OK, ['Content-Type' => 'text/html; charset=utf-8']); } catch (\Exception $e) {