feat(deploy): remove constraint restricting deployment to clients with different partition sizes

pull/125/head
Juan Manuel Bardallo 2026-07-09 11:04:17 +02:00
parent 6b8cd0834b
commit af2fa11d9b
4 changed files with 0 additions and 103 deletions

View File

@ -6,10 +6,8 @@ namespace App\Dto\Input;
use ApiPlatform\Metadata\ApiProperty;
use App\Dto\Output\ClientOutput;
use App\Validator\Constraints\ClientsHaveSamePartitionSize;
use Symfony\Component\Serializer\Annotation\Groups;
#[ClientsHaveSamePartitionSize]
class DeployGitImageInput
{
#[Groups(['git-repository:write'])]

View File

@ -4,13 +4,11 @@ namespace App\Dto\Input;
use ApiPlatform\Metadata\ApiProperty;
use App\Dto\Output\ClientOutput;
use App\Validator\Constraints\ClientsHaveSamePartitionSize;
use App\Validator\Constraints\OrganizationalUnitMulticastMode;
use App\Validator\Constraints\OrganizationalUnitMulticastPort;
use App\Validator\Constraints\OrganizationalUnitP2PMode;
use Symfony\Component\Serializer\Annotation\Groups;
#[ClientsHaveSamePartitionSize]
class DeployImageInput
{
#[Groups(['image-image-repository:write'])]

View File

@ -1,23 +0,0 @@
<?php
namespace App\Validator\Constraints;
use Symfony\Component\Validator\Constraint;
#[\Attribute]
class ClientsHaveSamePartitionSize extends Constraint
{
public string $message;
public function __construct(mixed $options = null, ?array $groups = null, mixed $payload = null)
{
parent::__construct($options, $groups, $payload);
$this->message = 'Todos los clientes deben tener el mismo tamaño de partición para la partición seleccionada.';
}
public function getTargets(): string
{
return self::CLASS_CONSTRAINT;
}
}

View File

@ -1,76 +0,0 @@
<?php
namespace App\Validator\Constraints;
use App\Dto\Input\DeployImageInput;
use App\Dto\Input\DeployGitImageInput;
use App\Dto\Output\ClientOutput;
use App\Entity\Client;
use Symfony\Component\Validator\ConstraintValidator;
use Symfony\Component\Validator\Constraint;
class ClientsHaveSamePartitionSizeValidator extends ConstraintValidator
{
public function validate($value, Constraint $constraint): void
{
if (!$value instanceof DeployImageInput && !$value instanceof DeployGitImageInput) {
return;
}
if (!isset($value->clients) || !is_array($value->clients) || empty($value->clients)) {
return;
}
if ($value->diskNumber === null || $value->partitionNumber === null) {
return;
}
$partitionSizes = [];
foreach ($value->clients as $client) {
$clientEntity = $client->getEntity();
if (!$clientEntity instanceof Client) {
continue;
}
$clientIp = (string) $clientEntity->getIp();
$targetPartition = null;
foreach ($clientEntity->getPartitions() as $partition) {
if ($partition->getDiskNumber() === $value->diskNumber &&
$partition->getPartitionNumber() === $value->partitionNumber) {
$targetPartition = $partition;
break;
}
}
if ($targetPartition === null) {
$partitionSizes[$clientIp] = null;
} else {
$partitionSizes[$clientIp] = $targetPartition->getSize();
}
}
$validSizes = array_filter($partitionSizes, fn($size) => $size !== null);
if (count($validSizes) !== count($partitionSizes)) {
$clientsWithoutPartition = array_keys(array_filter($partitionSizes, fn($size) => $size === null));
$this->context->buildViolation('Algunos clientes no tienen la partición seleccionada (Disco: ' . $value->diskNumber . ', Partición: ' . $value->partitionNumber . '). Clientes sin partición: ' . implode(', ', $clientsWithoutPartition))
->addViolation();
return;
}
if (count(array_unique($validSizes)) > 1) {
$errorDetails = [];
foreach ($partitionSizes as $clientIp => $partitionSize) {
$errorDetails[] = "Cliente $clientIp tiene tamaño $partitionSize KB.";
}
$detailedMessage = implode(" ", $errorDetails);
$this->context->buildViolation($constraint->message . ' Detalles: ' . $detailedMessage)
->addViolation();
}
}
}