From 7844d452a4b2c9ae517d8d52392b9d14e916eb2a Mon Sep 17 00:00:00 2001 From: jmbardallo Date: Thu, 17 Sep 2026 14:25:52 +0200 Subject: [PATCH] fix(assets): add error handling and check for php-zip extension during zip upload --- src/Controller/AssetManagerController.php | 24 +++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/src/Controller/AssetManagerController.php b/src/Controller/AssetManagerController.php index 1b6d194..4ea3698 100644 --- a/src/Controller/AssetManagerController.php +++ b/src/Controller/AssetManagerController.php @@ -108,13 +108,25 @@ class AssetManagerController extends AbstractController { $filesystem->mkdir($extractDir, 0755); } - $zip = new ZipArchive(); - if ($zip->open($file->getPathname()) === true) { - $zip->extractTo($extractDir); - $zip->close(); - $response = new JsonResponse(['message' => 'ZIP extraído correctamente.']); + if (!class_exists('ZipArchive')) { + $response = new JsonResponse(['message' => 'Falta la extensión php-zip en el servidor.'], Response::HTTP_INTERNAL_SERVER_ERROR); } else { - $response = new JsonResponse(['message' => 'Error al extraer ZIP.'], Response::HTTP_INTERNAL_SERVER_ERROR); + try { + $zip = new ZipArchive(); + if ($zip->open($file->getPathname()) === true) { + $success = $zip->extractTo($extractDir); + $zip->close(); + if ($success) { + $response = new JsonResponse(['message' => 'ZIP extraído correctamente.']); + } else { + $response = new JsonResponse(['message' => 'Falló la extracción (posible falta de permisos).'], Response::HTTP_INTERNAL_SERVER_ERROR); + } + } else { + $response = new JsonResponse(['message' => 'Error al abrir el ZIP.'], Response::HTTP_INTERNAL_SERVER_ERROR); + } + } catch (\Throwable $e) { + $response = new JsonResponse(['message' => 'Excepción al extraer: ' . $e->getMessage()], Response::HTTP_INTERNAL_SERVER_ERROR); + } } } else { try {