From cd7a2484c5a810488b9f779e18d388edc6389a9f Mon Sep 17 00:00:00 2001 From: jmbardallo Date: Wed, 6 May 2026 12:28:28 +0200 Subject: [PATCH 1/2] =?UTF-8?q?Modificada=20funcion=20para=20borrar=20imag?= =?UTF-8?q?en=20de=20cache,=20no=20se=20usa=20la=20partici=C3=B3n=20que=20?= =?UTF-8?q?contenga=20una=20imagen=20desplegada,=20se=20usa=20directamente?= =?UTF-8?q?=20el=20nombre=20del=20fichero=20contenido=20en=20cache?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- CHANGELOG.md | 4 +++ config/api_platform/Client.yaml | 2 +- .../OgAgent/RemoveCacheImageAction.php | 16 +++++------ src/Dto/Input/RemoveCacheImageInput.php | 27 +++++++++++++++++++ 4 files changed, 38 insertions(+), 11 deletions(-) create mode 100644 src/Dto/Input/RemoveCacheImageInput.php diff --git a/CHANGELOG.md b/CHANGELOG.md index 8e492cc..769580f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Changelog +## [1.7.3] - 2026-05-05 +### Fixed +- Modificada funcion para borrar imagen de cache, no se hace usando la partición que contenga un deploy de imagen, se borra el fichero real de la cache + ## [1.7.2] - 2026-05-04 ### Fixed - Corregida llamada a instalar/desinstalar oglives en servidores ogboot diff --git a/config/api_platform/Client.yaml b/config/api_platform/Client.yaml index 84bb7d5..c8a2963 100644 --- a/config/api_platform/Client.yaml +++ b/config/api_platform/Client.yaml @@ -68,7 +68,7 @@ resources: remove_cache_image: class: ApiPlatform\Metadata\Post method: POST - input: App\Dto\Input\BootClientsInput + input: App\Dto\Input\RemoveCacheImageInput uriTemplate: /clients/server/remove-cache-image controller: App\Controller\OgAgent\RemoveCacheImageAction diff --git a/src/Controller/OgAgent/RemoveCacheImageAction.php b/src/Controller/OgAgent/RemoveCacheImageAction.php index e5ee009..f8a1cc7 100644 --- a/src/Controller/OgAgent/RemoveCacheImageAction.php +++ b/src/Controller/OgAgent/RemoveCacheImageAction.php @@ -2,9 +2,8 @@ namespace App\Controller\OgAgent; -use App\Dto\Input\BootClientsInput; +use App\Dto\Input\RemoveCacheImageInput; use App\Entity\Client; -use App\Entity\Partition; use App\Model\ClientStatus; use App\Model\CommandTypes; use App\Model\TraceStatus; @@ -24,19 +23,16 @@ class RemoveCacheImageAction extends AbstractOgAgentController * @throws RedirectionExceptionInterface * @throws ClientExceptionInterface */ - public function __invoke(BootClientsInput $input): JsonResponse + public function __invoke(RemoveCacheImageInput $input): JsonResponse { - /** @var Partition $partition */ - $partition = $input->partition->getEntity(); + if (!$input->imageName) { + throw new BadRequestHttpException('Image name is required'); + } foreach ($input->clients as $clientEntity) { /** @var Client $client */ $client = $clientEntity->getEntity(); - if (!$partition->getImage()) { - throw new BadRequestHttpException('Image is required'); - } - if (!$client->getIp()) { throw new BadRequestHttpException('IP is required'); } @@ -46,7 +42,7 @@ class RemoveCacheImageAction extends AbstractOgAgentController continue; } - $script = 'rm -r /opt/opengnsys/cache/opt/opengnsys/images/' . $partition->getImage()->getName() . '.*'; + $script = 'rm -r /opt/opengnsys/cache/opt/opengnsys/images/' . escapeshellarg($input->imageName) . '*'; $data = [ 'nfn' => 'EjecutarScript', diff --git a/src/Dto/Input/RemoveCacheImageInput.php b/src/Dto/Input/RemoveCacheImageInput.php new file mode 100644 index 0000000..a48be05 --- /dev/null +++ b/src/Dto/Input/RemoveCacheImageInput.php @@ -0,0 +1,27 @@ + Date: Wed, 6 May 2026 15:30:37 +0200 Subject: [PATCH 2/2] fix(ogcore): fix scheduled task execution and UTC timezone handling - Fix executeReboot response check: use getStatusCode() instead of json_decode(body)['status'], which never matched the Client entity body - Fix executeRunScript: same check fix; remove duplicate trace status update since RunScriptAction already handles it via updateExistingTrace - Normalize executionDate/executionTime to UTC at API boundary in CommandTaskScheduleInput to prevent client/server timezone drift - Use UTC consistently in calculateNextExecutionDate and RunScheduledCommandTasksCommand for all datetime comparisons - Replace 30-second execution window (abs(difference) < 30) with isDue && notYetExecuted logic so tasks missed by the cron are recovered in the next cycle instead of being skipped forever - Skip one-time (none) tasks with a past executionDate in calculateNextExecutionDate so nextExecution is set to null after execution and the task no longer appears in cron logs --- src/Command/ExecutePendingTracesCommand.php | 18 +++++------------- .../RunScheduledCommandTasksCommand.php | 11 ++++++++--- src/Dto/Input/CommandTaskScheduleInput.php | 14 ++++++++++++-- src/Entity/CommandTask.php | 19 +++++++++++-------- 4 files changed, 36 insertions(+), 26 deletions(-) diff --git a/src/Command/ExecutePendingTracesCommand.php b/src/Command/ExecutePendingTracesCommand.php index 378f5b5..7f37f43 100644 --- a/src/Command/ExecutePendingTracesCommand.php +++ b/src/Command/ExecutePendingTracesCommand.php @@ -425,16 +425,8 @@ class ExecutePendingTracesCommand extends Command try { $response = $this->runScriptAction->__invoke($commandExecuteInput, $trace); - - if (json_decode($response->getContent(), true)['status'] === 200) { - $trace->setStatus(TraceStatus::SUCCESS); - $trace->setFinishedAt(new \DateTime()); - $this->entityManager->persist($trace); - $this->entityManager->flush(); - return true; - } - - return false; + + return $response->getStatusCode() === 200; } catch (\Exception $e) { $this->logger->error('Error executing run script', [ 'input' => $commandExecuteInput, @@ -464,15 +456,15 @@ class ExecutePendingTracesCommand extends Command try { $response = $this->rebootAction->__invoke($multipleClientsInput); - - if (json_decode($response->getContent(), true)['status'] === 200) { + + if ($response->getStatusCode() === 200) { $trace->setStatus(TraceStatus::SUCCESS); $trace->setFinishedAt(new \DateTime()); $this->entityManager->persist($trace); $this->entityManager->flush(); return true; } - + return false; } catch (\Exception $e) { return false; diff --git a/src/Command/RunScheduledCommandTasksCommand.php b/src/Command/RunScheduledCommandTasksCommand.php index 4385c3d..f57456f 100644 --- a/src/Command/RunScheduledCommandTasksCommand.php +++ b/src/Command/RunScheduledCommandTasksCommand.php @@ -50,7 +50,7 @@ class RunScheduledCommandTasksCommand extends Command */ protected function execute(InputInterface $input, OutputInterface $output): int { - $now = new \DateTimeImmutable('now'); + $now = new \DateTimeImmutable('now', new \DateTimeZone('UTC')); $tasks = $this->commandTaskRepository->findAll(); @@ -68,7 +68,12 @@ class RunScheduledCommandTasksCommand extends Command $output->writeln("NextExecution: " . $nextExecution->format('Y-m-d H:i:s T')); $output->writeln("Diferencia: $difference segundos para la tarea {$task->getName()}"); - if (abs($difference) < 30) { + $lastExecution = $task->getLastExecution(); + $isDue = $difference >= 0; + $notYetExecuted = $lastExecution === null + || $lastExecution->getTimestamp() < $nextExecution->getTimestamp(); + + if ($isDue && $notYetExecuted) { $output->writeln("Ejecutando tarea: " . $task->getName()); $scripts = $task->getCommandTaskScripts()->toArray(); @@ -80,7 +85,7 @@ class RunScheduledCommandTasksCommand extends Command $this->createTraceForScript($script, $task, $output); } - $task->setLastExecution(new \DateTimeImmutable('now')); + $task->setLastExecution(new \DateTimeImmutable('now', new \DateTimeZone('UTC'))); $task->setNextExecution($task->calculateNextExecutionDate()); $this->entityManager->persist($task); diff --git a/src/Dto/Input/CommandTaskScheduleInput.php b/src/Dto/Input/CommandTaskScheduleInput.php index 5802b88..6f6d272 100644 --- a/src/Dto/Input/CommandTaskScheduleInput.php +++ b/src/Dto/Input/CommandTaskScheduleInput.php @@ -74,12 +74,22 @@ final class CommandTaskScheduleInput $commandTaskSchedule = new CommandTaskSchedule(); } + $utc = new \DateTimeZone('UTC'); + if ($this->commandTask) { $commandTaskSchedule->setCommandTask($this->commandTask->getEntity()); } $commandTaskSchedule->setRecurrenceType($this->recurrenceType); - $commandTaskSchedule->setExecutionTime($this->executionTime); - $commandTaskSchedule->setExecutionDate($this->executionDate); + $commandTaskSchedule->setExecutionTime( + $this->executionTime + ? \DateTime::createFromInterface($this->executionTime)->setTimezone($utc) + : null + ); + $commandTaskSchedule->setExecutionDate( + $this->executionDate + ? \DateTime::createFromInterface($this->executionDate)->setTimezone($utc) + : null + ); $commandTaskSchedule->setRecurrenceDetails($this->recurrenceDetails); $commandTaskSchedule->setEnabled($this->enabled); diff --git a/src/Entity/CommandTask.php b/src/Entity/CommandTask.php index 4caf661..1693df1 100644 --- a/src/Entity/CommandTask.php +++ b/src/Entity/CommandTask.php @@ -219,7 +219,8 @@ class CommandTask extends AbstractEntity */ public function calculateNextExecutionDate(): ?\DateTimeInterface { - $now = new \DateTime(); + $utc = new \DateTimeZone('UTC'); + $now = new \DateTime('now', $utc); $closestDateTime = null; foreach ($this->getCommandTaskSchedules() as $schedule) { @@ -231,13 +232,14 @@ class CommandTask extends AbstractEntity if ($executionTime !== null) { $execDateTime = \DateTime::createFromFormat( 'Y-m-d H:i:s', - $execDate->format('Y-m-d') . ' ' . $executionTime->format('H:i:s') + $execDate->format('Y-m-d') . ' ' . $executionTime->format('H:i:s'), + $utc ); } else { - $execDateTime = $execDate; + $execDateTime = \DateTime::createFromInterface($execDate)->setTimezone($utc); } - if ($closestDateTime === null || $execDateTime < $closestDateTime) { + if ($execDateTime > $now && ($closestDateTime === null || $execDateTime < $closestDateTime)) { $closestDateTime = $execDateTime; } } else { @@ -246,13 +248,13 @@ class CommandTask extends AbstractEntity continue; } - $init = (new \DateTime($details['initDate'] ?? 'now'))->setTime(0, 0); - $end = (new \DateTime($details['endDate'] ?? '+1 year'))->setTime(0, 0); + $init = (new \DateTime($details['initDate'] ?? 'now', $utc))->setTime(0, 0); + $end = (new \DateTime($details['endDate'] ?? '+1 year', $utc))->setTime(0, 0); $validDays = array_map('mb_strtolower', $details['daysOfWeek'] ?? []); $validMonths = array_map('mb_strtolower', $details['months'] ?? []); - $current = (new \DateTime())->setTime(0, 0); + $current = (new \DateTime('now', $utc))->setTime(0, 0); while ($current <= $end) { if ($current < $init) { @@ -267,7 +269,8 @@ class CommandTask extends AbstractEntity if ($executionTime !== null) { $execDateTime = \DateTime::createFromFormat( 'Y-m-d H:i:s', - $current->format('Y-m-d') . ' ' . $executionTime->format('H:i:s') + $current->format('Y-m-d') . ' ' . $executionTime->format('H:i:s'), + $utc ); } else { $execDateTime = clone $current;