From 33609081bfba0e9e74375c85fa289f856a51de9e Mon Sep 17 00:00:00 2001 From: jmbardallo Date: Fri, 31 Jul 2026 13:40:29 +0200 Subject: [PATCH] refactor(inventory): optimize extraction of fwt and spd in CreatePartitionService --- src/Service/CreatePartitionService.php | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/src/Service/CreatePartitionService.php b/src/Service/CreatePartitionService.php index 81bed55..9033c67 100644 --- a/src/Service/CreatePartitionService.php +++ b/src/Service/CreatePartitionService.php @@ -30,20 +30,27 @@ class CreatePartitionService return isset($cfg['disk'], $cfg['par'], $cfg['tam'], $cfg['uso'], $cfg['fsi']); }); + $fwtFound = false; + $spdFound = false; + foreach ($data['cfg'] as $cfg) { - if (!empty($cfg['fwt'])) { + if (!$fwtFound && !empty($cfg['fwt'])) { $clientEntity->setFirmwareType($cfg['fwt']); - $this->entityManager->persist($clientEntity); + $fwtFound = true; + } + + if (!$spdFound && !empty($cfg['spd'])) { + $clientEntity->setNetSpeed((int) $cfg['spd']); + $spdFound = true; + } + + if ($fwtFound && $spdFound) { break; } } - - foreach ($data['cfg'] as $cfg) { - if (!empty($cfg['spd'])) { - $clientEntity->setNetSpeed((int) $cfg['spd']); - $this->entityManager->persist($clientEntity); - break; - } + + if ($fwtFound || $spdFound) { + $this->entityManager->persist($clientEntity); } foreach ($filteredCfg as $cfg) {