From 294a9c5d40297d4d3add4c5efd93b5dc5dd761a9 Mon Sep 17 00:00:00 2001
From: Manuel Aranda <maranda@qindel.com>
Date: Mon, 19 May 2025 16:42:22 +0200
Subject: [PATCH] Improvements

---
 src/Controller/OgAgent/AbstractOgAgentController.php | 8 ++++++++
 src/Controller/OgAgent/StatusAction.php              | 8 ++++++++
 2 files changed, 16 insertions(+)

diff --git a/src/Controller/OgAgent/AbstractOgAgentController.php b/src/Controller/OgAgent/AbstractOgAgentController.php
index a6ada4b..97ed83d 100644
--- a/src/Controller/OgAgent/AbstractOgAgentController.php
+++ b/src/Controller/OgAgent/AbstractOgAgentController.php
@@ -69,6 +69,14 @@ abstract class AbstractOgAgentController extends AbstractController
         } catch (ClientExceptionInterface | ServerExceptionInterface $e) {
             $this->logger->error(sprintf('Client/Server error in request to %s: %s', $url, $e->getMessage()));
 
+            return [
+                'code' => Response::HTTP_INTERNAL_SERVER_ERROR,
+                'error' => 'Client/Server error',
+                'details' => $e->getMessage(),
+            ];
+        }  catch (TransportExceptionInterface $e) {
+            $this->logger->error(sprintf('Transport error in request to %s: %s', $url, $e->getMessage()));
+
             return [
                 'code' => Response::HTTP_INTERNAL_SERVER_ERROR,
                 'error' => 'Client/Server error',
diff --git a/src/Controller/OgAgent/StatusAction.php b/src/Controller/OgAgent/StatusAction.php
index 4a450af..d188bd7 100644
--- a/src/Controller/OgAgent/StatusAction.php
+++ b/src/Controller/OgAgent/StatusAction.php
@@ -82,6 +82,14 @@ class StatusAction extends AbstractOgAgentController
             token: $client->getToken(),
         );
 
+        if (isset($data['error']) && $data['code'] === Response::HTTP_INTERNAL_SERVER_ERROR) {
+            $this->logger->error('Error checking client status', ['client' => $client->getId()]);
+            $client->setStatus(ClientStatus::OFF);
+            $this->entityManager->persist($client);
+            $this->entityManager->flush();
+            throw new ValidatorException('Error deploying image');
+        }
+
         if (isset($data['cfg'])) {
             $this->logger->info('Creating partitions', ['data' => $data['cfg']]);
             $this->createPartitionService->__invoke($data, $client);