diff --git a/CHANGELOG.md b/CHANGELOG.md index a3f6ba6..dbe9efe 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,12 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [5.4.0] - 2025-05-19 + +### Changed + +- Disabled TLS on request + ## [5.3.0] - 2025-05-16 ### Changed diff --git a/src/opengnsys/RESTApi.py b/src/opengnsys/RESTApi.py index de0c5cf..08d4cdd 100644 --- a/src/opengnsys/RESTApi.py +++ b/src/opengnsys/RESTApi.py @@ -109,21 +109,21 @@ class REST(object): logger.debug ('TLS not available: python requests library is old') self.use_tls = url.startswith ('https') - if self.use_tls: - if not ca_file or not crt_file or not key_file: - raise Exception ('missing TLS parameters in REST constructor') - - errs = 0 - for f in [ca_file, crt_file, key_file]: - if not os.path.exists (f): - logger.error (f'{f}: No such file or directory') - errs += 1 - if errs: - raise Exception ('TLS files not found') - - self.ca_file = ca_file - self.crt_file = crt_file - self.key_file = key_file + #if self.use_tls: + # if not ca_file or not crt_file or not key_file: + # raise Exception ('missing TLS parameters in REST constructor') + # + # errs = 0 + # for f in [ca_file, crt_file, key_file]: + # if not os.path.exists (f): + # logger.error (f'{f}: No such file or directory') + # errs += 1 + # if errs: + # raise Exception ('TLS files not found') + # + #self.ca_file = ca_file + #self.crt_file = crt_file + #self.key_file = key_file # Disable logging requests messages except for errors, ... logging.getLogger("requests").setLevel(logging.CRITICAL) @@ -156,7 +156,7 @@ class REST(object): # Old requests version does not support verify, but it do not checks ssl certificate by default if self.newerRequestLib: if self.use_tls: - r = requests.get(url, cert=(self.crt_file, self.key_file), verify=self.ca_file, timeout=TIMEOUT) + r = requests.get(url, verify=False, timeout=TIMEOUT) else: r = requests.get(url, timeout=TIMEOUT) else: @@ -165,7 +165,7 @@ class REST(object): logger.debug('Requesting using POST {}, data: {}'.format(url, data)) if self.newerRequestLib: if self.use_tls: - r = requests.post(url, data=data, headers={'content-type': 'application/json'}, cert=(self.crt_file, self.key_file), verify=self.ca_file, timeout=TIMEOUT) + r = requests.post(url, data=data, headers={'content-type': 'application/json'}, verify=False, timeout=TIMEOUT) else: r = requests.post(url, data=data, headers={'content-type': 'application/json'}, timeout=TIMEOUT) else: