From 9adc98352da188a19a7a15f88845cf60b9b3ae60 Mon Sep 17 00:00:00 2001 From: safocl Date: Thu, 30 Jan 2025 04:33:00 +0400 Subject: [PATCH] fix: use of uninitialized memory int selected[NPAT]; [...] fill_buffer([...], selected); ->[...] if (pat_no % npasses == 0) { for (i = 0; i < NPAT; i++) { selected[i] = 0; } } -> false [...] if (selected[i] == 0) // access to uninitialized memory!!! --- ntfsprogs/ntfswipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ntfsprogs/ntfswipe.c b/ntfsprogs/ntfswipe.c index ef67101e..f852ea1e 100644 --- a/ntfsprogs/ntfswipe.c +++ b/ntfsprogs/ntfswipe.c @@ -1722,7 +1722,7 @@ static int destroy_record(ntfs_volume *nv, const s64 record, unsigned long int pass, i; s64 j; unsigned char * a_offset; - int selected[NPAT]; + int selected[NPAT] = {0}; file = (struct ufile *) malloc(sizeof(struct ufile)); if (file == NULL) {