opengnsys
/
ntfs-3g
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ntfs_index_lookup(): fix potential double free()'s on error paths

master
szaka 2008-02-02 16:55:04 +00:00
parent dc1677b58e
commit 4d9c861176
1 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
libntfs-3g/index.c
View File

@ -147,18 +147,14 @@ static void ntfs_index_ctx_free(ntfs_index_context *icx)
if (icx->actx)
ntfs_attr_put_search_ctx(icx->actx);
if (icx->is_in_root) {
if (icx->ia_na)
ntfs_attr_close(icx->ia_na);
return;
}
if (icx->ib_dirty) {
/* FIXME: Error handling!!! */
ntfs_ib_write(icx, icx->ib);
if (!icx->is_in_root) {
if (icx->ib_dirty) {
/* FIXME: Error handling!!! */
ntfs_ib_write(icx, icx->ib);
}
free(icx->ib);
}
free(icx->ib);
ntfs_attr_close(icx->ia_na);
}
@ -775,8 +771,6 @@ descend_into_child_node:
goto descend_into_child_node;
err_out:
if (icx->ia_na)
ntfs_attr_close(icx->ia_na);
free(ib);
if (!err)
err = EIO;