From 36b876375e3ae7cfb09ab59ba08f5bcb81004107 Mon Sep 17 00:00:00 2001 From: Erik Larsson Date: Fri, 15 Jan 2010 09:33:54 +0100 Subject: [PATCH] Commented out all instances of MS_NOATIME being passed to ntfs_mount, as libntfs-3g does not support that flag. In fact, this is how libntfs-3g operates normally, so the MS_NOATIME flag is not needed. However, other utilities might incorrectly assume that the library updates access times for them. Investigating whether access time needs to be manually updated in other utilities is TODO. --- ntfsprogs/ntfsclone.c | 2 +- ntfsprogs/ntfsresize.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ntfsprogs/ntfsclone.c b/ntfsprogs/ntfsclone.c index 2d757151..8c6797fc 100644 --- a/ntfsprogs/ntfsclone.c +++ b/ntfsprogs/ntfsclone.c @@ -1717,7 +1717,7 @@ int main(int argc, char **argv) /* 'force' again mount for dirty volumes (e.g. after resize). FIXME: use mount flags to avoid potential side-effects in future */ opt.force++; - mount_volume(MS_NOATIME); + mount_volume(0 /*MS_NOATIME*/); free(lcn_bitmap.bm); setup_lcn_bitmap(); diff --git a/ntfsprogs/ntfsresize.c b/ntfsprogs/ntfsresize.c index 6bf8a835..e1f44238 100644 --- a/ntfsprogs/ntfsresize.c +++ b/ntfsprogs/ntfsresize.c @@ -2239,7 +2239,7 @@ static ntfs_volume *mount_volume(void) "You must 'umount' it first.\n", opt.volume); } - if (!(vol = ntfs_mount(opt.volume, opt.ro_flag | MS_NOATIME))) { + if (!(vol = ntfs_mount(opt.volume, opt.ro_flag /*| MS_NOATIME*/))) { int err = errno;