[usb] Reset control endpoints immediately after failure

The current error handling mechanism defers the endpoint reset until
the next use of the endpoint, on the basis that errors are detected
during completions and completion handling should not recursively call
usb_poll().

In the case of usb_control(), we are already at the level that calls
usb_poll() and can therefore safely perform the endpoint reset
immediately.  This has no impact on functionality, but does make
debugging traces easier to read since the reset will appear
immediately after the causative error.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
pull/154/head
Michael Brown 2020-09-29 10:16:14 +01:00
parent 27e886c67b
commit f42ba772c8
1 changed files with 1 additions and 0 deletions

View File

@ -818,6 +818,7 @@ int usb_control ( struct usb_device *usb, unsigned int request,
"failed: %s\n", usb->name, request,
value, index, strerror ( rc ) );
free_iob ( cmplt );
usb_endpoint_reset ( ep );
return rc;
}