narenas
/
opengnsys_ipxe
mirror of https://github.com/ipxe/ipxe.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[efi] Avoid modifying PE/COFF debug filename 

The function efi_pecoff_debug_name() (called by efi_handle_name()) is
used to extract a filename from the debug data directory entry located
within a PE/COFF image.  The name is copied into a temporary static
buffer to allow for modifications, but the code currently erroneously
modifies the original name within the loaded PE/COFF image.

Fix by performing the modification on the copy in the temporary
buffer, as originally intended.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
pull/1082/head
Michael Brown 2023-11-29 12:49:06 +00:00
parent a147245f1a
commit 98dd25a3bb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/interface/efi/efi_debug.c
View File

@ -665,10 +665,10 @@ efi_pecoff_debug_name ( EFI_LOADED_IMAGE_PROTOCOL *loaded ) {
snprintf ( buf, sizeof ( buf ), "%s", name );
/* Strip file suffix, if present */
if ( ( tmp = strrchr ( name, '.' ) ) != NULL )
if ( ( tmp = strrchr ( buf, '.' ) ) != NULL )
*tmp = '\0';
return name;
return buf;
}
/**