From 1a9ed68cbbbe7280fe85fe7a8c06748134130db3 Mon Sep 17 00:00:00 2001 From: Michael Brown Date: Wed, 9 Mar 2016 00:45:09 +0000 Subject: [PATCH] [eoib] Allow the multicast group to be forcefully created Some EoIB implementations require each individual EoIB node to create the multicast group for the EoIB broadcast domain. It is left as an exercise for the interested reader to determine how such an implementation might ever allow the parameters of such a multicast group to be changed without requiring a simultaneous upgrade of every driver on every operating system on every machine currently attached to the fabric. Signed-off-by: Michael Brown --- src/drivers/net/eoib.c | 4 ++-- src/include/ipxe/eoib.h | 21 +++++++++++++++++++++ 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/src/drivers/net/eoib.c b/src/drivers/net/eoib.c index 44eed4cc5..a5f9e29ee 100644 --- a/src/drivers/net/eoib.c +++ b/src/drivers/net/eoib.c @@ -454,8 +454,8 @@ static int eoib_join_broadcast_group ( struct eoib_device *eoib ) { /* Join multicast group */ if ( ( rc = ib_mcast_join ( eoib->ibdev, eoib->qp, - &eoib->membership, &eoib->broadcast, 0, - eoib_join_complete ) ) != 0 ) { + &eoib->membership, &eoib->broadcast, + eoib->mask, eoib_join_complete ) ) != 0 ) { DBGC ( eoib, "EoIB %s could not join broadcast group: %s\n", eoib->name, strerror ( rc ) ); return rc; diff --git a/src/include/ipxe/eoib.h b/src/include/ipxe/eoib.h index c53880b5c..acae542b6 100644 --- a/src/include/ipxe/eoib.h +++ b/src/include/ipxe/eoib.h @@ -48,8 +48,29 @@ struct eoib_device { /** Peer cache */ struct list_head peers; + + /** Multicast group additional component mask */ + unsigned int mask; }; +/** + * Force creation of multicast group + * + * @v eoib EoIB device + */ +static inline void eoib_force_group_creation ( struct eoib_device *eoib ) { + + /* Some dubious EoIB implementations require each endpoint to + * force the creation of the multicast group. Yes, this makes + * it impossible for the group parameters (e.g. SL) to ever be + * modified without breaking backwards compatiblity with every + * existing driver. + */ + eoib->mask = ( IB_SA_MCMEMBER_REC_PKEY | IB_SA_MCMEMBER_REC_QKEY | + IB_SA_MCMEMBER_REC_SL | IB_SA_MCMEMBER_REC_FLOW_LABEL | + IB_SA_MCMEMBER_REC_TRAFFIC_CLASS ); +} + extern int eoib_create ( struct ib_device *ibdev, const uint8_t *hw_addr, struct ib_address_vector *broadcast, const char *name );