narenas
/
opengnsys_ipxe
mirror of https://github.com/ipxe/ipxe.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[romprefix] Do not clobber stack segment when returning to BIOS 

Commit c429bf0 ("[romprefix] Store boot bus:dev.fn address as autoboot
device location") introduced a regression by using register %cx to
temporarily hold the PCI bus:dev.fn address, despite the fact that %cx
was already being used to hold the stored BIOS stack segment.
Consequently, when returning to the BIOS after a failed or cancelled
boot attempt, iPXE would end up calling INT 18 with the stack segment
set equal to the PCI bus:dev.fn address.  Writing to essentially
random areas of memory tends to upset even the more robust BIOSes.

Fix by using register %ax to temporarily hold the PCI bus:dev.fn
address.

Reported-by: Anton D. Kachalov <mouse@yandex-team.ru>
Tested-by: Anton D. Kachalov <mouse@yandex-team.ru>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
pull/17/head
Michael Brown 2014-03-05 12:25:21 +00:00
parent ac5c2e851b
commit 1137fa3268
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/arch/i386/prefix/romprefix.S
View File

@ -740,13 +740,13 @@ exec: /* Set %ds = %cs */
.section ".text16", "awx", @progbits
1:
/* Retrieve PCI bus:dev.fn */
movw init_pci_busdevfn, %cx
movw init_pci_busdevfn, %ax
/* Set up %ds for access to .data16 */
movw %bx, %ds
/* Store PCI bus:dev.fn */
movw %cx, autoboot_busdevfn
movw %ax, autoboot_busdevfn
/* Call main() */
pushl $main