48k.eu-mirror
/
ogserver
mirror of https://git.48k.eu/ogserver
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#915: Fix file descriptor leak in og_socket_server_init() from exit path 

Call close() to release the socket in the event of an error.

infer says:

sources/ogAdmServer.cpp:1244: error: RESOURCE_LEAK
  resource acquired by call to `socket()` at line 1236, column 6 is not released after line 1244, column 3.
  1242.   			 sizeof(on));
  1243.   	if (res < 0) {
  1244. > 		syslog(LOG_ERR, "cannot set broadcast socket\n");
  1245.   		return false;
  1246.   	}

Not a real problem since OS releases process resources if the server
cannot bind to the port, but just to be correct here.
master
Roberto Hueso Gómez 2019-09-19 12:45:07 +02:00 committed by OpenGnSys Support Team
parent c1c89e196c
commit 8b1beddbe4
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sources/ogAdmServer.cpp
View File

@ -4356,6 +4356,7 @@ static int og_socket_server_init(const char *port)
local.sin_port = htons(atoi(port)); local.sin_port = htons(atoi(port));
if (bind(sd, (struct sockaddr *) &local, sizeof(local)) < 0) { if (bind(sd, (struct sockaddr *) &local, sizeof(local)) < 0) {
close(sd);
syslog(LOG_ERR, "cannot bind socket\n"); syslog(LOG_ERR, "cannot bind socket\n");
return -1; return -1;
} }