From 286dcd72eb88b8d5e25a386b71d120d5ce534fbb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javier=20S=C3=A1nchez=20Parra?= Date: Fri, 3 Apr 2020 13:59:25 +0200 Subject: [PATCH] #915 Increase request max length Trying to send a WakeOnLan command to 150 clients I noticed that the ogAdmClient closed (RST) the communication with the WebConsole without answering or logging anything. The Webconsole logged: php: error occured during curl exec. Additioanl info: Array php: ( php: [url] => http://127.0.0.1:8888/wol php: [content_type] => php: [http_code] => 0 php: [header_size] => 0 php: [request_size] => 199 php: [filetime] => -1 php: [ssl_verify_result] => 0 php: [redirect_count] => 0 php: [total_time] => 1.003122 php: [namelookup_time] => 4.9E-5 php: [connect_time] => 0.000273 php: [pretransfer_time] => 0.00035 php: [size_upload] => 7007 php: [size_download] => 0 php: [speed_download] => 0 php: [speed_upload] => 6986 php: [download_content_length] => -1 php: [upload_content_length] => 7007 php: [starttransfer_time] => 1.001793 php: [redirect_time] => 0 php: [redirect_url] => php: [primary_ip] => 127.0.0.1 php: [certinfo] => Array php: ( php: ) php: php: [primary_port] => 8888 php: [local_ip] => 127.0.0.1 php: [local_port] => 43016 php: [http_version] => 0 php: [protocol] => 1 php: [ssl_verifyresult] => 0 php: [scheme] => HTTP php: ) This happened because request max length is set to 4096 bytes and my request had a size of 7075 bytes. So, the max length was exceeded. This commit increase the max length from 4096 to 16384. This way the ogAdmServer supports larger request messages. --- sources/ogAdmServer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sources/ogAdmServer.c b/sources/ogAdmServer.c index 9b1155c..0984cdb 100644 --- a/sources/ogAdmServer.c +++ b/sources/ogAdmServer.c @@ -130,7 +130,7 @@ enum og_client_state { OG_CLIENT_PROCESSING_REQUEST, }; -#define OG_MSG_REQUEST_MAXLEN 4096 +#define OG_MSG_REQUEST_MAXLEN 16384 /* Shut down connection if there is no complete message after 10 seconds. */ #define OG_CLIENT_TIMEOUT 10