Commit Graph

435 Commits (64f1f5403e014a944e70187e6eda9a02c08eac3e)

Author SHA1 Message Date
OpenGnSys Support Team fa5b37b2a6 live: rename variable that stores json body in refresh()
Just a simple cleanup.
2024-05-21 11:51:29 +02:00
OpenGnSys Support Team b9ca7278a9 live: parttypes: add EFI partition type in MBR partition scheme
Add 0xef partition type for EFI in MBR.
2024-05-14 11:49:54 +02:00
OpenGnSys Support Team 3eb4332b38 live: partcodes: remove reference to website
Remove reference to external website in code.
2024-05-14 11:35:16 +02:00
OpenGnSys Support Team d109e99dbe utils: rename cache_probe() to get_cache_dev_path()
This method reports the /dev path to cache partition, rename it.

Add explicit check if blkid is successful.

And add logging to report that device path to cache is not found.
2024-05-09 11:47:06 +02:00
Alejandro Sirgo Rica 6bfbf6cc7b utils: add error checks to checksum file creation in tip_write_csum
Add a check for potential permission or IO errors during the
creation of the image checksum.
2024-05-07 20:47:05 +02:00
Alejandro Sirgo Rica abea6583d3 utils: add mkdir error report in mount_mkdir
Add exception checks to the os.mkdir operation and log the error
found. The previous implementation was too optimistic and only
handled mount related errors.
2024-05-07 17:24:41 +02:00
Alejandro Sirgo Rica 493d998a4e utils: remove unused json import
The json library was a dependency during the development of the
boot OS functions and it is no longer needed in that file.
2024-05-07 16:08:38 +02:00
Alejandro Sirgo Rica b0d03ce588 utils:fs: fix logging statement in get_filesystem_type
Call the error() logging function from the logging object instead
of the non existent log variable previously referenced.
2024-05-07 12:20:26 +02:00
Alejandro Sirgo Rica de17bb6812 utils:fs: add mkfs logs when return code is not 0
Report mkfs failure for every partition. This does not raise an
exception as that would skip partprobe operations and the mkfs
operations in the next potentially well formated partitions.
2024-05-07 12:20:26 +02:00
OpenGnSys Support Team 9ffe1c81bf live: report LINUX-SWAP instead of SWAP
ogCP expects LINUX-SWAP to specify a swap filesystem.

Add a similar workaround to the one that is done for VFAT for symmetry between
inputs and outputs that circulate over the API.
2024-05-07 11:54:39 +02:00
OpenGnSys Support Team 1ca3639389 live: rewrite log in case tiptorrent client fails
Specify that image file cannot be found in cache because tiptorrent has failed,
otherwise it is confusing.
2024-05-06 19:10:48 +02:00
OpenGnSys Support Team 8ecd57552a live: restore partprobe before building filesystem
Otherwise mkfs silently fails because OS reports out-of-sync partition table.
2024-05-06 19:08:12 +02:00
OpenGnSys Support Team 2dd5105995 live: force flush to disk after partition table is written 2024-05-06 18:51:57 +02:00
OpenGnSys Support Team f42e2ba201 live: partprobe breaks with mounted partitions
partprobe requires that all disk partitions are unmounted.

partprobe needs to be called to report the OS that the partition table
has changed, otherwise ogclient reports incorrect partition information.

iterate over the partition list and mount cache after partprobe is
called.
2024-05-06 18:33:41 +02:00
OpenGnSys Support Team 170d7e1be9 live: umount all partitions before partition setup
If new partition layout is specified, unmount cache and any other partition
under /mnt.
2024-05-06 18:32:54 +02:00
Alejandro Sirgo Rica 8171ddd15f live: fix omited error report in tip_client_get
tip_client_get raises the proper error exceptions but the except
block in _restore_image_tiptorrent overwrites the reported error.
Move the raise statements in _restore_image_tiptorrent outside
of the except block.
2024-05-06 14:23:29 +02:00
OpenGnSys Support Team 5ea6f73343 live: add fat32 to get_parttype()
Use "Microsoft basic data partition" to store FAT32 in case of GPT partition
scheme and 0xB according in case of MBR partition scheme according to
documentation.
2024-04-23 10:56:44 +02:00
OpenGnSys Support Team 84c2944bf3 live: revisit logging for partition setup, image create and restore 2024-04-23 10:55:37 +02:00
OpenGnSys Support Team 7d26f0f69b utils: add logging for checksum validation
Display if checksum validation is correct or not.
2024-04-22 14:56:09 +02:00
OpenGnSys Support Team 8661a99a36 utils: fs: incorrect indentation 2024-04-22 13:56:39 +02:00
OpenGnSys Support Team bddbea942e utils: fs: skip shrink/extend operation for fat
fat does not support this operation, skip it
2024-04-19 12:19:54 +02:00
OpenGnSys Support Team 481ce5794f utils: fs: remove unused variable in _reduce_resize2fs
ret is set but never used in this method
2024-04-19 11:32:53 +02:00
OpenGnSys Support Team 85bbdcfcb8 utils: fs: report error when failing to grow
not really a warning, report an error instead
2024-04-19 11:32:17 +02:00
OpenGnSys Support Team db23ea76f9 utils: fs: set return value in ogReduceFs
otherwise error path uses uninitialized variable

 File "/opt/opengnsys/ogClient/src/utils/fs.py", line 112, in ogReduceFs
 return ret
 UnboundLocalError: local variable 'ret' referenced before assignment
2024-04-19 11:29:24 +02:00
Alejandro Sirgo Rica e19437290d live: improve exception handling in image_create
Reduce the scope of the try except block that controls the case
of deleting the image backup in case of error. Now it only covers
the section of code after backup creation and up to image
verification. Check when the Exception is an OgError to raise
with added context.

Prevent the deletion of the target image in case of error before
the backup creation.

Bundle the backup creation on its own try except block to give
more feedback on a failed backup creation.

Enables a better error management allowing unhandled
exceptions to be reported properly.
2024-04-03 13:31:10 +02:00
Alejandro Sirgo Rica cbe7f8d49c src: use explicit exception types in except Exception blocks
Capture only the relevant exception types in each except block.
The capture of the Exception type means hiding information for
unhandled error cases, even for syntax errors in the codebase.
Using a more fine grained exception filtering improves error
traceability.
2024-04-03 13:31:10 +02:00
Alejandro Sirgo Rica dfde363aa6 src: log backtrace in unhandled error cases
Log an error message in known error cases and log a backtrace
otherwise.

Define a new error type OgError to be used in all the 'raise'
blocks to define the error message to log. The exception
propagates until it reaches send_internal_server_error() where
the exception type is checked. If the type is OgError we log
the exception message. Logs the backtrace for other types.

The initial error implementation printed a backtrace everytime
an error ocurred. The next iteration changed it to only print
a backtrace in a very particular case but ended up omiting too
much information such as syntax errors or unknown error context.
The actual implementation only logs the cases we already cover in
the codebase and logs a bracktrace in the others, enabling a
better debugging experience.
2024-04-03 13:31:10 +02:00
OpenGnSys Support Team c5ccc3c7e2 qmp: incorrect copyright header
Replace incorrect copyright header in qmp.py file.
2024-04-02 13:20:27 +02:00
OpenGnSys Support Team 4712941828 utils: refine log when booting windows UEFI from DOS partition
Refine 97647c32aa utils: add enforce_gpt argument to get_efi_partition()
to provide more explicit error when trying to boot Windows UEFI from DOS
partition.
2024-04-01 14:28:14 +02:00
OpenGnSys Support Team 1aba9d0923 Revert "live: improve lzop and partclone error handling"
This reverts commit 57787dab54.

Read from stderr is blocking if no data is available, revert this patch since
ogClient hangs indefinitely in lzop invocations due to races in process
execution through Popen.
2024-04-01 13:44:17 +02:00
Alejandro Sirgo Rica 474183ab71 utils: fix mount error messages for os probe operations
Replace unexistent mountpoint variable to report a failed
mount operation before an OS probe from a partition.
Improve the semantics of the error message replacing 'at' with
'into'.
Remove the period at the end of the log message.
2024-04-01 13:02:46 +02:00
OpenGnSys Support Team a97fd4acad live: display info logging when restoring image starts
instead of using debug level, this is very useful to track the process.
2024-03-27 17:15:59 +01:00
Alejandro Sirgo Rica 25b00bfd69 live: use .ant image as main image after image creation error
Restore image file from .ant to original file name if new image
creation fails. Remove new imagen and move the .ant image file in
place of the original as previously an error meant a rename of the
image file without a revert to keep the image available.
2024-03-27 10:34:22 +01:00
Alejandro Sirgo Rica c3ce5342c9 utils: make init_cache() use the cache mountpoint
Make init_cache() use the actual cache mountpoint returned by the
function mount_cache() for the creation of the cache directories
instead of a hardcoded path.
2024-03-26 13:32:58 +01:00
Alejandro Sirgo Rica 3aa76e4039 utils: remove redundant return statements from mount_mkdir
Remove return statement the program won't reach and simplify the
return logic with a return from an if and a fallback return
statement.
2024-03-26 13:32:58 +01:00
Alejandro Sirgo Rica 55fadef718 utils: drop ogCopyEfiBootLoader script
Implement a Python equivalent of ogCopyEfiBootLoader as the
function copy_efi_bootloader. This function copies the contents of
the folder of the EFI loader in the ESP into a ogBoot folder at
the root of the partition target of an image creation.
copy_efi_bootloader is a Windows only functionality.
2024-03-26 13:32:58 +01:00
Alejandro Sirgo Rica 57787dab54 live: improve lzop and partclone error handling
Control non 0 returncode of the lzop and partclone subprocess
in image creation and restoration because this means that either
lzop or partclone has failed.
The implementation must cover cases such as not enough storage
space and log errors into /tmp/command.log and the log file of
the client handling the request.
Check the returncode of lzop and partclone subprocesses and
log the stderr of the process reporting non zero returncode.
2024-03-26 13:32:48 +01:00
Alejandro Sirgo Rica 16dcc9b25b live: improve logging in image_create
Log the whole context of the error when an exception happens.
The previous exception handling was hidding important information
about the cause of the error.
2024-03-26 13:23:04 +01:00
Alejandro Sirgo Rica 97647c32aa utils: add enforce_gpt argument to get_efi_partition()
The Windows bootloader only supports a UEFI boot from a GPT
partition. Set enforce_gpt to True in every codepath related to
Windows. When enforce_gpt is set to True get_efi_partition()
raises an exception when an MBR partition scheme is detected.
2024-03-26 13:23:04 +01:00
Alejandro Sirgo Rica 42791a1a7c revert 7f18485: improve uefi detection mechanism
Make is_uefi_supported() only check for /sys/firmware/efi as
get_efi_partition() will detect a missing ESP or an invalid
partition scheme. Stop using get_efi_partition() inside
is_uefi_supported() as the former is eventually called in every
UEFI related code.
UEFI supports both MBR and GPT as partition schemes and this is
a required change to handle the particular case of Windows not
being able to boot UEFI from a MBR partition scheme.
2024-03-26 13:15:58 +01:00
Alejandro Sirgo Rica 049b7a5a2b src: make exception messages more contextual and explicit
Provide more information in exception messages as those are the
source of the logging messages. Add information about paths, files
or configuration related to the operation associated to the
exception.
2024-03-21 10:29:57 +01:00
Alejandro Sirgo Rica 8741b2e272 src: change generic exception types to be more explicit
Replace exception types to be more explicit about the nature of
the error.
Improve the exception raising semantics by using the 'from' keyword,
this wraps an older exception into a new one so it is still considered
the same object.
2024-03-21 10:29:57 +01:00
Alejandro Sirgo Rica 167fd29634 utils: fix string not being defined as f-strings when they should
Add the string prefix f'' to string instances formated as f-string
but not properly constructed to expand the inline variables.
2024-03-21 10:29:57 +01:00
Alejandro Sirgo Rica 657af13351 virtual: add missing check=True to subprocess.run()
Raise exception from subprocess.run() calls as previous code is
trying to capture these exceptions to handle de errors.
2024-03-21 10:29:57 +01:00
Alejandro Sirgo Rica 2a4ce65a20 src: centralize error logging into send_internal_server_error
Use only the exception messages as the main resource for error
messages.
The previous error code had string duplication in the form of:
	logging.error('msg here')
	raise Exception('msg here')

That approach also has the downside of having log duplication as
it had the local logging.err() and a global logging.exception()
inside send_internal_server_error capturing the exception message.
The actual code only requires raising an exception with a proper
error message.
Improve exception messages to give more error context.
Log every AssertionError as a backtrace.
Use the 'raise Exception from e' syntax to modify the a previously
raised exception 'e' into an exception with aditional context or
different type. This also prevents the message that warns about
newer exceptions being launch after an initial exception.
2024-03-21 10:29:57 +01:00
Alejandro Sirgo Rica 0cbf16461e ogclient: consolidate logging in client core
The main function must be able to handle the login of critical
error in the main ogClient class instance. Add a try except block
to the ogCLient run logic and move the relevant  error logs into
the except block.
Delegate the error messages to the exception message. This is the
first step towards error message deduplication.
2024-03-21 10:29:57 +01:00
Alejandro Sirgo Rica 8012562302 utils: implement BIOS boot for windows
Create ogboot.me and ogboot.secondboot as empty files and
ogboot.firstboot with the value "iniciado" in the root of
the BIOS Windows system partition.
The files must contain data for GRUB to be able to write content,
therefore these are created containing 3072 null bytes.
The Windows boot process is handled by the "pxe" profile.
There the files ogboot.me, ogboot.firstboot and ogboot.secondboot
are used as a state machine to chose between booting Windows and
ogLive.
The first Windows boot happens if ogboot.me and ogboot.firstboot
are identical, then "iniciado" is written in ogboot.firstboot.
We skip this stage as we create ogboot.firstboot with 'iniciado'.
The second Windows boot occurs if ogboot.me and ogboot.secondboot
are boot identical, then "iniciado" is written in ogboot.secondboot.
After the Windows boot ogLive is booted.
2024-03-21 10:29:21 +01:00
Alejandro Sirgo Rica ddf08779ae utils: add disk index checks in get_partition_device
Control the possibility of a bad disk index. Handle the checks in
a similar fashion to the get_efi_partition function.
2024-03-21 10:29:13 +01:00
Alejandro Sirgo Rica a3ffdf2370 utils: implement BIOS boot for Linux
Create a bios.py file to hold all the BIOS specific functions.
Implement the _boot_bios_linux in Python. The new boot process
tries to find the vmlinuz and initrd binaries at the desired
partition. Then it tries to load them with kexec with the proper
Grub boot params.
One step closer to the removal of the boot legacy script.
2024-03-21 10:29:13 +01:00
Alejandro Sirgo Rica 37600660f3 live: check if cache partition is available before calling tiptorrent
The image restore command must check if the cache partition is
available. Otherwise if the user forgets to create the cache
tiptorrent fails.
2024-03-21 10:29:06 +01:00
Alejandro Sirgo Rica 52ab38fc28 utils: handle exceptions caused by the hivex package
The mage creation process was being interrupted by an error
trying to read the Windows registry by the Hivex library.
Now the exceptions are handled and an error is reported.
2024-03-08 13:03:33 +01:00
Alejandro Sirgo Rica f5501aac91 utils: implement linux distro id detection
The OS probe logic must be able to check a distro programmatically,
add get_linux_distro_id to return an id whitout versioning.
Ensure the availability of 'ubuntu' when we need to ensure certain
features are only used with a supported system.
2024-03-08 13:03:33 +01:00
Alejandro Sirgo Rica 4d4171e459 utils: move all boot from OS functionality into boot.py
This change is a preparative for reimplementing the BIOS boot
in order to deprecate the legacy script. All the codepaths to
boot systems located at a partition are now called from the
boot_os_at function enabling an easier structure for the incoming
code.
2024-03-08 13:03:00 +01:00
Alejandro Sirgo Rica 7f18485eff utils: improve uefi detection mechanism
Checking the existence /sys/firmware/efi as it might appear
sometimes in BIOS installs if the BIOS configuration is not
proper. Checking for the EFI partition is the safest method
to veryfy the install type.
2024-03-08 12:43:10 +01:00
Alejandro Sirgo Rica 9970c8e33d utils: handle missing file in getlinuxversion function
The function getlinuxversion receives a path to the os-release
file. The case of not being able to open it was not handled and
thus causing an unwanted exception.
2024-03-08 12:43:10 +01:00
Alejandro Sirgo Rica aa34704b4d utils: improve logging in the get_efi_partition function
Log each partition that gets checked and make the exception messages
more informative.
2024-03-08 12:43:01 +01:00
OpenGnSys Support Team 673cada250 uefi: update EFIBOOTMGR_BIN to use /opt/opengnsys/sbin/efibootmgr
debian package with json support provides the binary through this path, update it.
2024-03-05 15:37:34 +01:00
Alejandro Sirgo Rica 8e8ed280f9 uefi: define EFIBOOTMGR_BIN to ease changing the efibootmgr binary
The json functionality proposed upstream might be merged one day
in efibootmgr so deploying a fork would not be needed anymore.
This change aims to ease the migration once that day comes.
2024-03-04 11:33:10 +01:00
Alejandro Sirgo Rica 66941e9f79 live: drop IniciarSesion script when uefi booting into linux
Replace IniciarSesion script in favor of native Python code when booting
a UEFI system into Linux. This completes the implementation of booting
into an OS on a UEFI compliant system.
2024-03-04 11:33:10 +01:00
Jose M. Guisado 23b4b1feb6 live: drop IniciarSesion script when uefi booting
Replace IniciarSesion script in favor of native Python code when booting
a UEFI system. This applies when running the "session" command.

WIP: Only UEFI boots Windows systems. Raise NotImplementedError
exception trying to boot a Linux system using UEFI.
2024-03-04 11:33:10 +01:00
Jose M. Guisado 517c99e542 utils: add boot.py
Add utility module related to the process of booting a system from a
client's partition.

The main utility function to boot a clients system is boot_os_at(), from
which firmware (UEFI or BIOS) and os-family specific private functions are invoked.

This initial commit adds UEFI windows boot function.
2024-03-04 11:33:10 +01:00
Jose M. Guisado 4129256caf utils: add uefi.py
Add UEFI related utilities inside a new utility module: uefi.py

	_check_efibootmgr_json
	======================
Check if the system efibootmgr executable supports JSON output. This is
a private function used only by other functions from uefi.py.

	is_uefi_supported
	=================
Check if the system supports UEFI firmware.

	run_efibootmgr_json
	===================
Runs efibootmgr with json output support. Return the JSON output as a
Python dict.

	efibootmgr_create_bootentry
	===========================
Create nvram boot entry. This bootentry is usually later set to boot
next just once via "BootNext" nvram variable.

	efibootmgr_delete_bootentry
	===========================
Delete a nvram boot entry. Used to avoid duplicates when booting the
same disk and partition from a given client.

	efibootmgr_bootnext
	===================
Set nvram "BootNext" variable to a given boot entry so after client
reboot, PXE is not executed and the given boot entry takes precedence.

Add dependency with efibootmgr version >= 18, and efibootmgr JSON output
which is currently out of tree from util-linux repo.
2024-03-04 11:33:10 +01:00
Jose M. Guisado e3c375f8d7 probe: add basic os family detection
Add a basic OS family enumeration: OSFamily.

Add utility function that probes for an installed Linux or Windows
system, returns the corresponding enum value, OSFamily.UNKNOWN
otherwise.
2024-03-04 11:33:10 +01:00
Jose M. Guisado bb3264d8f4 disk: add get_efi_partition function
Add utility function inside disk.py to find, if any, the first ESP
partition of a given disk.

The disk is provided as an integer (starting at 1 following OpenGnsys
scripts usual values), meaning the (n-1)th disk from the disk array
returned from get_disks(). In the future a better mechanism should be
put in place to fetch probed disks from a running client.

This change is part of the upcoming drop of "IniciarSesion" script in
favor of a Python native approach. Specifically regarding UEFI systems.
2024-03-04 11:33:10 +01:00
OpenGnSys Support Team 14752ce14c cache: improve logging
use info instead of debug to make it easier to debug problems when creating the
cache.
2024-02-22 11:41:27 +01:00
OpenGnSys Support Team e3bb01f5f1 live: improve logging with setup command
Improve logging when setting up partition, provide more hints on progress.

Fail in case partition layout is not supported.
2024-02-22 11:33:50 +01:00
OpenGnSys Support Team 26ca4c7950 fs: add swap support and improve mkfs logging 2024-02-22 10:52:03 +01:00
OpenGnSys Support Team 8ff6341b69 utils: use returncode from subprocess in ogChangeRepo()
... the exception shows the samba password in the logs

specify the error which tells us what has happened according to man mount(8)
Return Codes.
2024-02-21 11:16:19 +01:00
OpenGnSys Support Team 92ef3d68aa live: call partprobe on the specific disk
otherwise partprobe does its best to find the disk, according to what I see
through strace.
2024-02-19 11:56:25 +01:00
OpenGnSys Support Team dbda6abd22 poweroff: always call poweroff_oglive and _reboot_oglive
Remove leftover fallback to directly call utilities to poweroff and reboot.
2024-02-19 10:07:27 +01:00
Alejandro Sirgo Rica bcbbe26573 fs: improve value parsing from command output
value extraction did not have error checking and was handled in
a one-liner. The actual implementation expands the parsing logic
and moves it into a function.
2024-02-19 10:06:02 +01:00
OpenGnSys Support Team 4109bb6ecc live: split logging to warn not to turn off client during image creation
just split this log message.
2024-02-15 16:58:51 +01:00
OpenGnSys Support Team 5e11432e9d utils: remove repository change in restoreImageCustom
this is broken, it uses default uses and password, remove it.
2024-02-15 16:58:51 +01:00
OpenGnSys Support Team 2da8b98fff fs: check if writing md5sum to full.sum file fails
writing to file might fail (permission denied, disk full), check for errors.
2024-02-15 16:58:51 +01:00
OpenGnSys Support Team 8fb8a0a66d fs: return unknown if blkid fails
instead of rising an exception
2024-02-15 16:58:51 +01:00
OpenGnSys Support Team bf7eb1542d fs: logging ext4 resize error
log error in case resize2fs fails.
2024-02-15 16:58:51 +01:00
OpenGnSys Support Team d6c32bba5d fs: check if ntfsresize actually succeded to shrink filesystem
According to ntfsresize.c, this retuns 0 in case nothing needs to be done.
It should be safe to check for non-zero error and bail out in that case.
2024-02-15 16:58:46 +01:00
OpenGnSys Support Team 0f30b1349d fs: disentagle dry-run ntfsresize loop to probe for best shrink size
Revisit 5056b8f0d5 ("fs: validate ntfsresize dry-run output") that has
introduced a possible infinity loop.

Disentangle this loop while at it: iterate until best smallest size is
found by probing.
2024-02-15 16:36:28 +01:00
OpenGnSys Support Team 0fc7f8f33e src: ogChangeRepo returns zero on success and -1 on error
do not return the returncode, instead return an integer.

do not use

	except CalledProcessError as e:

it causes a another exception while handling exception.

Remount the original image repository.

it should be possible to simplify this further by:

- stacking mounts, no need to umount initial repo and mount it again
  when switching to the new repo, because remount back initial repo
  might fail (!)

- use check=False and simply check for x.returncode
2024-02-15 16:22:23 +01:00
OpenGnSys Support Team 44250d0334 live: remove mbuffer leftover in image restore command
Remove mbuffer, this is never used.

mbuffer has been never been used since ogClient supports native image restore.

Originally this was used like this:

	partclone [...] | mbuffer -q -M 40M | lzop [...]

supposely to speed up partclone in case the device where the read happens is
slowier than the device that is used for writes.

See mbuffer(1) manpage examples.

In any case, this needs benchmarking to really make sure this is helping.

Remove it until that ever happens.
2024-02-15 16:22:23 +01:00
OpenGnSys Support Team 6b1f20faf3 live: log message improvements for image creation and restore
Provide more context information for debugging issues with image creation and
restore.
2024-02-15 16:22:13 +01:00
Alejandro Sirgo Rica 478c4447be src: improve error check in image_create and image_restore
cover more error cases where exceptions need to be raised.
check return code in the invoked subprocess.

restoreImageCustom has been intentionally left behind, it
is unclear what this custom script returns on success and
error.
2024-02-14 12:28:28 +01:00
Alejandro Sirgo Rica c1529c5eec src: fix whitespace in ogOperations.py
make whitespace conherent with the rest of the file contents.
2024-02-14 11:09:54 +01:00
OpenGnSys Support Team 5056b8f0d5 fs: validate ntfsresize dry-run output
validate 'Needed relocations: ' is in place before stepping on the split chunks

(2024-01-11 10:28:16) ogClient: [ERROR] - Exception when running "image create" subprocess
Traceback (most recent call last):
  File "/opt/opengnsys/ogClient/src/live/ogOperations.py", line 454, in image_create
    ogReduceFs(disk, partition)
  File "/opt/opengnsys/ogClient/src/utils/fs.py", line 105, in ogReduceFs
    _reduce_ntfsresize(partdev)
  File "/opt/opengnsys/ogClient/src/utils/fs.py", line 235, in _reduce_ntfsresize
    extra_size = int(out_resize_dryrun.split('Needed relocations : ')[1].split(' ')[0])*1.1+1024
IndexError: list index out of range

if not present, no need to adjust size
2024-01-11 12:55:37 +01:00
OpenGnSys Support Team 9beb55894d live: refine existing logging
- suggest to check permissions in samba folder
- fix typo, s/filesyste/filesystem/
2023-12-18 13:47:29 +01:00
OpenGnSys Support Team 32673cf337 live: adding logging to notify that image file already exists
Just informational, provide a notice that the file already exists.
2023-12-17 20:53:43 +01:00
OpenGnSys Support Team dff126cf40 live: ensure image file exists after partclone
check that there is a file and that is accessible
2023-12-17 11:27:28 +01:00
OpenGnSys Support Team 2bddf205d9 live: display filesystem and device path if image_create() fails
display filesystem and path to device.
2023-12-16 17:15:34 +01:00
OpenGnSys Support Team 5d19ff5fe9 live: validate rw access to image folder after remount
check that it is readable and writable
2023-12-16 17:14:02 +01:00
OpenGnSys Support Team 41cf2eb229 utils: use f-string in raise ValueError in run_lzop_partcloneinfo()
Otherwise it shows:

  ValueError: Unable to process image {image_path}
2023-12-15 17:31:16 +01:00
OpenGnSys Support Team 6c49815d73 live: report permissions and last update when creating image
add .permissions and .lastupdate to json to report to ogserver.
2023-12-12 17:51:50 +01:00
OpenGnSys Support Team b97c4d157a live: report image size when creating image
add .size json field to report the real size of the image file.
2023-12-12 11:33:48 +01:00
OpenGnSys Support Team d34ef0ab25 utils: sw_inventory: report unknown OS for software inventory
Users can create an image of a filesystem that contains no OS, therefore,
instead of rising an exception when no OS is detected, deliver a "unknown"
OS and an empty list of software.
2023-11-17 13:32:06 +01:00
Jose M. Guisado 4e10c46563 live: use legacy backup image suffix
Image backup is considered a legacy feature. Use the legacy mechanism of
naming image backups by adding ".ant" suffix.

Previously, by using the strftime suffix clients were reporting that the
disk were getting full rather quickly.

When a good method for image deletion is implemented then a proper
backup naming mechanism should be reconsidered.
2023-10-24 09:56:09 +02:00
Jose M. Guisado b49ec83bcd live: hw_inventory: fix empty pci storage size bug
When a client's hardware presents an empty pci storage child there is an
invalid call to _bytes_to_human a string is supplied as a default value
if the storage child does not present a 'size' attribute.

Fix this by checking if 'size' is present in the JSON output from lshw.
If size is present then map the bytes to a human readable string using
_bytes_to_human, if no size is present then use 'Empty slot' to indicate
that the memory bank is not being used.
2023-10-18 13:32:24 +02:00
Jose M. Guisado 59eac6d0d5 live: hw_inventory: fix typo
Add missing underscore to _bytes_to_human call.

Fixes: 39c13287c5 ("live: hw_inventory: fix empty memory bank bug")
2023-10-18 12:05:23 +02:00
Jose M. Guisado 39c13287c5 live: hw_inventory: fix empty memory bank bug
When a client's hardware presents an empty memory bank and invalid call
to _bytes_to_human is performed because None is passed as a parameter.

	size = _bytes_to_human(obj.get('size', None))

Fix this by checking if 'size' is present in the JSON output from lshw.
If size is present then map the bytes to a human readable string using
_bytes_to_human, if no size is present then use 'Empty slot' to indicate
that the memory bank is not being used.
2023-10-05 16:19:36 +02:00
Jose M. Guisado 49038f125a src: improve logging messages
Some users have mistakenly reported tiptorrent problems when the process
takes a long time. Specifically by rebooting or powering off the client
in the middle of the md5sum computation stage, just after the tiptorrent
transfer.

Same problem occurs when image creation command takes a long period of
time.

In order to help the user understand the different stages of commands
such as image creation or image restore using tiptorrent, the following
changes have been made to the current logging solution:

- Add log messages to warn users not to reboot or shut down the client
  during a tiptorrent transfer, and also during the md5sum computation
  stage.

- Add a log message telling the user that the image creation processes
  have started.

- Use logging.exception inside "except:" blocks to print a traceback
  with the log messsage.
  (https://docs.python.org/3/library/logging.html#logging.exception)
2023-08-01 18:26:10 +02:00
Jose M. Guisado ee0d62db44 hw_inventory: use dict.get
The first stage of parsing the "lshw -json" command output is to load
the json string into a Python dictionary. lshw output is large and
varies from machine to machine, so it's not safe to assume that
different keys will be present in the dictionary.

Use dict.get() instead of dict[key] to avoid KeyError exceptions.
2023-07-21 11:55:25 +02:00
Jose M. Guisado 035995fc8c live: add image backup option in image creation
Backup image file if image creation request included

	"backup": true

This only applies when the target image is already present in the
repository folder before running the partclone subprocess.

This parameter is ignored if the target image is not present in the
repository.
2023-07-06 17:52:52 +02:00
Jose M. Guisado 5c3cf47023 rest: add backup parameter
Support parsing of "backup" parameter inside incoming requests.

Prepare ogClient support for backup image creation in "image create"
operation.
2023-07-06 17:38:32 +02:00
Jose M. Guisado 0c03d82ca8 ogclient: add support for X-Sequence header
Enable parsing of "X-Sequence" HTTP headers from incoming requests.
Add "seq" field in restRequest class.

Enable adding "X-Sequence" to outgoing responses.
Add "seq" field inside restResponse class.

Store current client sequence number inside ogClient class.

Ideally, the restRequest object should be used to retrieve the
sequence number but not all processing functions inside ogRest.py
receive the request as parameter (eg: process_refresh).
In the other hand, all processing functions receive the ogClient object.
2023-06-14 14:50:55 +02:00
Jose M. Guisado 926a73cf33 fs: fix subprocess input inside _extend_resize2fs
The subprocess module expects bytes-like object for "input" parameter by
default. Passing a string object result in the following error:

(2023-06-13 14:44:43) ogClient: [ERROR] - Exception when running "image create" subprocess
(2023-06-13 14:44:43) ogClient: [ERROR] - Unexpected error
Traceback (most recent call last):
  File "/opt/opengnsys/ogClient/src/live/ogOperations.py", line 465, in image_create
    ogExtendFs(disk, partition)
  File "/opt/opengnsys/ogClient/src/utils/fs.py", line 124, in ogExtendFs
    _extend_ntfsresize(partdev)
  File "/opt/opengnsys/ogClient/src/utils/fs.py", line 250, in _extend_ntfsresize
    proc = subprocess.run(cmd, input='y')
  File "/usr/lib/python3.8/subprocess.py", line 495, in run
    stdout, stderr = process.communicate(input, timeout=timeout)
  File "/usr/lib/python3.8/subprocess.py", line 1013, in communicate
    self._stdin_write(input)
  File "/usr/lib/python3.8/subprocess.py", line 962, in _stdin_write
    self.stdin.write(input)
TypeError: a bytes-like object is required, not 'str'

Fixes: dd999bfe34 ("utils: rewrite ogReduceFs")
2023-06-13 17:34:20 +02:00
Jose M. Guisado 88668cb195 fs: fix bug when ntfsresize reports nothing to do
There is a corner case in which a target NTFS filesystem is already
shrunken. When this happens ntfsresize text output parsing breaks.

Check when ntfsresize reports nothing to do, warn the user about this
and stop the dry-run ntfsresize loop.
2023-06-13 17:34:04 +02:00
Jose M. Guisado 666d2fb50f fs: fix typo inside _extend_resize2fs
_extend_ntfsresize contains an incorrect variable name inside
subprocess.run referring the resize command value.

Simplify this variable name inside each specific _extend_* function:

	s/cmd_resize2fs/cmd
	s/cmd_ntfsresize/cmd
2023-06-13 09:06:13 +02:00
Jose M. Guisado fa51f2be8f src: remove unused legacy software inventory code
Remove unnecessary InventarioSoftware invocation inside image_create
operation. Software inventory is executed after image creation
(see ogRest.py).

Remove legacy 'path' parameter. This parameter was used to specify the
path of a text file in which legacy bash scripts wrote the software
inventory of the client (something like "Csft-{ip}...").

Fixes: 04bb35bd86 ("live: rewrite software inventory")
Fixes: 2e3d47b7b8 ("Avoid writting /software output to a file")
2023-05-17 12:44:50 +02:00
Jose M. Guisado 0c6dd12f4c sw_inventory: ignore invalid windows programs
Don't raise exception if any windows program is missing DisplayName
node in the windows registry.

This attribute/node should contain the program's name. This name is used
as the package's name in the software set (software inventory).

This patch should be considered a hotfix, python-hivex does not report
any helpful message about this error.

(2023-05-09 14:43:13) ogClient: [ERROR] - Unexpected error
Traceback (most recent call last):
[...]
RuntimeError: Success

Before this patch, image creation *might* fail because it cannot create
the software inventory associated with the image due to the previously
described error. The software inventory is part of the response payload
of the image creation command (see src/ogRest:image_create).

Fixes: 04bb35bd86 (live: rewrite software inventory)
2023-05-09 17:04:27 +02:00
Jose M. Guisado 66a464f7d0 live: rewrite reboot operation
Add optional 'operation' parameter to _poweroff_oglive function.
Reuse _poweroff_oglive code before the busybox subprocess when rebooting
an ogLive client.
2023-05-09 13:09:07 +02:00
Jose M. Guisado ef06618a8c live: rewrite poweroff operation
Replace legacy bash script /opt/opengnsys/client/scripts/poweroff with a
Python native solution.

Use subprocess module for any required external program when shutting
down a client. ethtool is used to ensure WoL setting is correct before
shutting down.

ogLive does not properly use a init system so busybox is used when
shutting down the system. In other live environments poweroff operation
just calls /sbin/poweroff.
2023-05-09 13:09:07 +02:00
Jose M. Guisado cf6f50e528 utils: add umount_all function
Add utility function to unmount any mountpoint present in the /mnt
folder.

This function is a simplified version of the legacy bash function
ogUnmountAll used in several operations.
2023-05-09 13:09:07 +02:00
Jose M. Guisado 803ba74510 utils: rewrite ogExtendFs
Drop subprocess call to bash function ogExtendFs. Use a native python
solution with subprocess calls to the required underlying tools.

Use get_filesystem_type to get the present filesystem from a partition
and call the corresponding filesystem grow function.

Filesystem specific functions are declared "_extend_{filesystem}" and
should not be imported elsewhere.

Each filesystem specific function wraps a subprocess call to the
required underlying program:

- NTFS filesystems: "ntfsresize -f [partition]"
- ext4 filesystems: "resize2fs -f [partition]"

Set NTFS related subprocess stdin to 'y' because human input cannot be
unset with other ntfsresize parameters.
2023-05-09 13:09:02 +02:00
Jose M. Guisado dd999bfe34 utils: rewrite ogReduceFs
Drop subprocess call to bash function ogReduceFs. Use a native python
solution with subprocess calls to the required underlying tools.

Use get_filesystem_type to get the filesystem from a partition and call
the corresponding supported filesystem shrink function.

Filesystem specific functions are declared "_reduce_{filesystem}" and
should not be imported elsewhere.

In case of NTFS filesystems, the output of 'ntfsresize' is processed
directly. This is dirty, but we can expect no changes to the output
strings if we read the following comment in the nftsresize.c source
code:
https://github.com/tuxera/ntfs-3g/blob/edge/ntfsprogs/ntfsresize.c#L12

ntfsresize requires to do previous dry-run executions to confirm
that the resizing is possible.
If a dry-run fails but a 10% increase in size is still smaller than
original filesystem then retry the operation until dry-run reports
sucess or the size increase is bigger than original.

If resizing to a smaller ntfs filesystem is not possible then ogReduceFs
will do nothing.
2023-05-02 17:31:08 +02:00
Jose M. Guisado 22dce48d3e utils: add get_filesystem_type function
Retrieve filesystem type from a partition using get_filesystem_type.
Encapsulates a subprocess call to blkid.
2023-04-25 13:33:45 +02:00
Jose M. Guisado 2ddea6d514 src: add missing copyright notices 2023-04-18 17:26:40 +02:00
Jose M. Guisado ee80dc89ad live: rewrite hardware inventory command
Replace legacy shell script InventarioHardware for helper functions
from hw_inventory.py

Use get_hardware_inventory to obtain a HardwareInventory object with
the hardware information. Map the HardwareInventory object to a legacy
response string with the legacy_list_hardware_inventory function.

Remove "Chrd-*" file reading logic, it's no longer needed. Legacy shell
script InventarioHardware uses that file.

Expect a change in the structure of hardware inventory response payload
in the future. This patch does not address the HTTP response containing
the hardware inventory as a '\n' separated string of hardware elements.
2023-04-18 17:15:57 +02:00
Jose M. Guisado 49a86bddd9 utils: add hw_inventory.py
hw_inventory.py defines classes and helpers functions enabling
fetching of hardware inventory from a running client.

Uses a subprocess call to the command 'lshw -json' to obtain hardware
information.

Relevant public functions:

> get_hardware_inventory()
	Main function encapsulating subprocess and output processing
	logic.
	Returns a HardwareInventory object.

> legacy_list_hardware_inventory(inventory)
	Legacy string representation of parameter HardwareInventory object
2023-04-18 12:02:29 +02:00
Jose M. Guisado 4c0904d8da utils: rename inventory.py to sw_inventory.py
Rename software inventory file to sw_inventory to better distinguish
it from a future hardware inventory code.

In the future sw_inventory and hw_inventory might be merged together
once each file is tidied up.
2023-04-18 10:58:00 +02:00
Jose M. Guisado 04bb35bd86 live: rewrite software inventory
Replace legacy bash script in favor of Python code. Improves error
traceability and further development.

The software inventory operation mounts the target partition and it
fetches the list of installed software (package set). Once the
operation is complete, it unmounts the target partition.

For Windows, introduce hivex library python bindings for accessing
Windows registry hive files (https://libguestfs.org/hivex.3.html).

This operation is still processed by legacy code in the server side
(ogAdmServer.c in ogServer). Legacy backend process expects the software
inventory like the following example:

"software": "Windows 10 Enterprise Evaluation 2004 \nIntel(R) Network Connections 24.0.0.11 24.0.0.11 ..."

The os name is inserted first in this list followed by a '\n' separated
string of the software packages.

The legacy server code can be found in function actualizaSoftware at
ogServer/src/ogAdmServer.c

It is expected for software inventory payload to change in the future to
a simpler solution using just a json array of strings.
2023-03-27 15:48:03 +02:00
Jose M. Guisado 2172f00cde live: fix ogChangeRepo invocation
Add missing samba credentials parameter in ogChangeRepo invocation.

Credentials are loaded from ogClient config file.

Any production deployment should use its own samba user and password.
ogChangeRepo fails when using default samba credentials in a production
environment.

Fixes: a1edbe904b ("legacy: rewrite ogChangeRepo")
Fixes: 3703fd6063 ("live: support native unicast cache image restore")
2023-03-27 15:48:03 +02:00
Jose M. Guisado c0e14e0c95 live: fix unicast cache error log message
Removes undefined 'repo' variable from error logging message.

This caused the traceback to be polluted with an unhelpful message
about this variable being undefined.

Fixes: 3703fd606 ("live: support native unicast cache image restore")
2023-03-27 15:48:03 +02:00
Jose M. Guisado 0ebcd9f776 live: add linux swap parttype
Adds linux swap partition type, mapped to the 'LINUX-SWAP' string in web
interfaces like ogCP or webconsole.

Fixes: 29c53e54e9 ("live: add parttypes.py")
2023-03-23 09:49:46 +01:00
Jose M. Guisado 97e753cbfd ogRest: improve error logging when executing operations
Capture all possible Python exceptions in the try/except block of every
opengnsys operation.

Create an error handling function to deduplicate code in the except
block. The error handling function resets the ogRest state to IDLE and
sends the corresponding 500 Internal Server Error.

This *does not cover* every possible error. There are functions inside
ogThread which contain code that may raise errors that are not covered
by any try/except block.
2023-03-10 11:26:46 +01:00
Jose M. Guisado 5b5ef607ec ogRest: remove root logger constant
Remove unnecesary root logger constant: LOGGER

The root logger is used by default when executing:

	logging.debug()
	logging.info()
	logging.warning()
	...

There is no point in doing:

	LOGGER = logging.getLogger()  # Get root logger
	LOGGER.debug()  # Use root logger
2023-03-10 11:26:46 +01:00
Jose M. Guisado b58ccca48b legacy: improve readability of ogGetImageInfo helper functions
Change the name of the helper functions used when getting opengnsys
image information (legacy ogGetImageInfo bash script). As of now the
process consist of decompressing the image file with lzop and feeding
that output to partclone.info.

Prefer a more explicit function name rather than "process_image_*"

Add comment about skipping the first two lines of partclone.info output.
Usually, partclone.info starts printing out these two lines that are not
related to the partclone image information:

	Partclone v0.3.23 http://partclone.org
	Showing info of image (-)

As long as partclone.info output doesn't change we'll be fine, but we
should not depend on human readable output. This might change in the
future (i.e. adding json output format to partclone.info).
2023-03-10 11:26:42 +01:00
Jose M. Guisado c9a3a763dd legacy: rewrite ogGetImageInfo
Rewrites this legacy script behavior using native Python code, using
subprocess module when executing programs like partclone.info or lzop

ogGetImageInfo is a bash script that retrieves information regarding an
OpenGnsys partition image, specifically:

- clonator
- compressor
- filesystem
- datasize (size of the partition image)

This rewrite only supports partclone and lzop compressed images. This is
standard behavior, we have no reports of other programs or compression
algorithms in use.

Keep this legacy function with hungarian notation to emphasize this is
still a legacy component that may be replaced in the future.
2023-03-02 13:15:10 +01:00
Jose M. Guisado a1edbe904b legacy: rewrite ogChangeRepo
Drop ogChangeRepo Bash script in favor of a native Python
approach. Use only necessary subprocess calls instead of bringing
all the logic of this function into a Bash script black box.

ogChangeRepo unmounts the current OpenGnsys image samba folder
(/opt/opengnsys/images) and mounts (connects to) a new directory using
the new provided ip address. Keeping access mode from previous mount.
If anything goes wrong when mounting the new directory, it will fallback
to mounting the previous directory.

If no previous OpenGnsys image samba directory is detected, this
functions tries to mount the new directory anyway. In this case,
it will raise CalledProcessError if something goes wrong.
2023-03-02 09:33:33 +01:00
Jose M. Guisado 1858950af1 legacy: improve readability of cambiar_accesso
Expand function docstring and do not use CalledProcessError handling to
return True or False. Just checking for returncode value is simpler.
2023-03-02 09:09:39 +01:00
Jose M. Guisado 782f46a199 live: rewrite setup operation
Rewrites the setup operation using python-libfdisk module instead of an
external bash script. Consolidating the operation into Python's code,
limiting external subprocesses to well known programs and small
concrete tasks that are difficult to fully integrate into Python.

Use parttypes.py to fetch partition types from python-libfdisk module.
Use fs.py to create any specified supported filesystem.

OpenGnsys cache partitions are created labelling the partition as
"CACHE". Stops setting non-standard MBR hexcode (0xca) to the cache
partition in addition to the filesystem label.

Any partition specified as type EMPTY will be ignored.
2023-02-09 13:26:06 +01:00
Jose M. Guisado 7801d483d4 utils: add init_cache function
init_cache() creates the default directory in which OpenGnsys stores
images when using any cache enabled transfer method.

As of this commit this folder must exist for tiptorrent.py to
work properly.

Subprocess Popen object inside tiptorrent.py use
'cwd' optional parameter like:

	cwd='/opt/opengnsys/cache/opt/opengnsys/images/'

This folder convention might change in the future.
2023-02-08 17:11:44 +01:00
Jose M. Guisado eac942660f utils: add fs.py
Adds utility module which wraps several mkfs.* calls as a subprocess.

The main utility function is mkfs(fs, disk, partition, label), which
subsequently calls the corresponding mkfs_*(partition_device) function.

mkfs() supports specifying a drive label where supported.

Other modules using fs.py should call mkfs() only.
2023-02-08 17:11:44 +01:00
Jose M. Guisado 29c53e54e9 live: add parttypes.py
Adds parttypes.py module with utility functions to get partition types
(parttypes) from python-libfdisk.

Supports standard partition types, either DOS or GPT.
DOS labels use a hex code to define partition types, python-libfdisk
exposes get_parttype_from_code to look up for DOS partition types from a
given hexcode.
GPT label uses a string (UUID) for each supported partition type,
python-libfdisk exposes get_parttype_from_string to look up for GPT
partition types from a given string.
2023-02-08 17:11:44 +01:00
Jose M. Guisado c010c42008 live: clear ogbrowser log before image_create
Remove any previous unrelated log message shown in the "real time log"
html page before executing this command.
2022-12-05 16:37:35 +01:00
Jose M. Guisado 7f6a7b664b log: add file handler for ogLive "real time log"
Clients running in ogLive can show log messages via a lighttp server.
Particularly, a html page named "real time log" consists of <text-area>
tags with the contents of two particular text files
/tmp/session.log and /tmp/command.log

Adds a Python logging handler in order to write ogClient log messages
into /tmp/session.log. This way ogClient logs are show in the "real time
log" html page too.
2022-12-05 16:19:57 +01:00
Jose M. Guisado 70f1d0d71d live: clear ogbrowser logs before image_restore
Clears content of blue text areas in the real time log view before
executing a restore image operation.

Adds private function _ogbrowser_clear_logs, this function writes to a
couple of text files present in the ogLive environment.
The contents of this file are printed out to the blue text areas
in the "real time log" view.
2022-12-01 15:22:58 +01:00
Jose M. Guisado 699a6c242a live: improve error paths
Fix error paths in live operations which do not
reset the "browser" to the main page (one with the menu).

Add error logging messages when:

* _restartBrowser fails.
* ogChangeRepo fails.

Improve checksum fetch error handling. For example, when an invalid
repository IP is specified.
2022-11-17 15:55:42 +01:00
Javier Sánchez Parra 94f6793f96 log: declare samba handler only in live mode
ogClient in linux mode only write its logs to syslog and the console.

Also, raise exception if mode its not supported.
2022-11-02 16:37:46 +01:00
Javier Sánchez Parra f1fff0b0b6 log: import fcntl only on linux
Otherwise, ogClient do not work on Windows because fcntl module do not
exists on Windows.
2022-11-02 16:37:41 +01:00
Jose M. Guisado 3703fd6063 live: support native unicast cache image restore
UNICAST-CACHE consist of:

1. Checking if the target image is already present at the opengnsys
   cache partition. If so, check for integrity (local and remote
   checksum). If the image is not present in the cache partition,
   download the target image into it.
2. Restore the image from cache partition.

This commit add support for this operation natively from ogClient
Python's code.
2022-11-02 14:09:39 +01:00
Jose M. Guisado 55c76c9d70 tiptorrent: improve raised exceptions for tip_client_get
Raise exception when tiptorrent-client subprocess runs normally but
exits with non-zero code. (For example, if download file allocation
failed)
2022-09-29 13:24:43 +02:00
Jose M. Guisado f2515fcde9 live: don't use python open() when reading image
Specifies the image path in the lzop subprocess string.

It might be interesting to study efficient mechanisms to read large
binary files in python before using open() with default parameters for
buffered binary reading.
2022-09-23 12:12:35 +02:00
Jose M. Guisado 00a95bdb61 live: rewrite image_restore
Integrates image restore command into native ogClient code. Further
reduces the need for external Bash scripts.

After a succesful image restore, OS configuration is still using
external Bash script "osConfigure/osConfigureCustom".
2022-09-14 17:12:14 +02:00
Jose M. Guisado 5d799773f6 utils: add tiptorrent.py
Utility and wrapper functions related to the usage of tiptorrent.
To be used by the image restore command.
2022-09-14 17:12:14 +02:00
Jose M. Guisado 52838e2ce6 utils: add get_partition_device
Maps a disk and partition number to the corresponding device path
('/dev/sdXY', '/dev/nvmeXnYpZ', ...)
2022-09-14 17:12:14 +02:00
Jose M. Guisado 87e738b33f image_restore: fix ogCopyEfiBootLoader
ogCopyEfiBootloader is an invalid legacy bash function name.

Rename to the correct function name 'ogCopyEfiBootLoader' and
rename utility python wrapper too.

Fixes: 0bd037c1a409c65fbcb01355ee0dd6dca770330e
2022-09-14 17:12:14 +02:00
Jose M. Guisado 91077da273 utils: minor fix for ogReduceFs and ogExtendFs
Do not return the subprocess result for ogReduceFs/ogExtendFs.

ogReduceFs works with or without the target filesystem mounted.
ogExtendFs requires the target filesystem to be mounted.

'ogMount' legacy script invocation should be replaced by a better
mount/umount wrapper.
2022-09-14 17:12:14 +02:00
Jose M. Guisado cb0bd3d194 image_create: add legacy ogCopyEfiBootloader
Use legacy script that saves the Windows-specific content from the ESP
to the image target filesystem.

Current image restore solution from OpenGnsys scripts expect the EFI
partition to be stored in the target system partition. (Only for Windows
10)

For example, storing the ESP in the NTFS partition of a Windows image.

Expect use of bash script ogCopyEfiBootloader until further
integration is merged.
2022-09-14 17:10:45 +02:00
Jose M. Guisado 3550da73e6 image_create: partial integration into python
Integrates some parts of this operation into native code, eg: the md5
checksum computation.

Wraps non native processes and commands using the subprocess module.
For example, legacy.py stores bash commands pending integration.

Supports python >=3.6, expected until more modern ogLives are put into
production environments.
2022-08-24 09:48:35 +02:00
Jose M. Guisado 74a61d6a7d refresh: use '0' if disk has no label
If disk has no label, python-libfdisk returns None when accessing

	cxt.label

Fixes bug when running refresh on computers whose disk/s have no label.
2022-08-22 17:05:12 +02:00
Jose M. Guisado 1b5281c2a1 live: enable details for libfdisk context object
Enables details in libfidsk context constructor call. Ensures size are
displayed as bytes (and not as a human readable string).

Avoids further arithmetical errors (e.g: converting from bytes to KB)
2022-06-08 10:27:06 +02:00
Jose M. Guisado c159c76294 live: remove unused parseGetConf function
parseGetConf was necessary for parsing output from OpenGnsys
script "getConfiguration", which has been replaced since commit
1ab981a539 ("live: replace getConfiguration with refresh")
2022-06-08 10:27:06 +02:00